Re: [PATCH v2 1/1] scsi: Synchronize request queue PM status only on successful resume

2019-01-03 Thread Mika Westerberg
Hi, On Thu, Jan 03, 2019 at 02:53:15PM +0800, stanley@mediatek.com wrote: > From: Stanley Chu > > The commit 356fd2663cff ("scsi: Set request queue runtime PM status > back to active on resume") fixed up the inconsistent RPM status between > request queue and device. However changing request

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-29 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 01:07:06AM -0800, dbasehore . wrote: > That's an interesting question. Part of direct complete is to leave > the device runtime suspended even after the system resumes if > possible. The comments in pm_complete_with_resume_check indicate that > the firmware may resume a devi

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-27 Thread Mika Westerberg
On Sat, Feb 27, 2016 at 12:10:03AM -0800, dbasehore . wrote: > A device is not able to use direct complete if its children do not > also use direct complete. Even though the SCSI layer leaves devices > runtime suspended, the way it does it still prevents its parent from > using direct complete. Ok

Re: [PATCH v2 3/3] scsi: allow scsi devices to use direct complete

2016-02-26 Thread Mika Westerberg
On Wed, Feb 24, 2016 at 04:22:28PM -0800, Derek Basehore wrote: > This allows scsi devices to remain runtime suspended for system > suspend. Since runtime suspend is stricter than system suspend > callbacks, this is just returning a positive number for the prepare > callback. AFAICT SCSI layer alr

Re: [PATCH 0/7] Runtime PM support for AHCI host controller driver

2016-02-19 Thread Mika Westerberg
On Thu, Feb 18, 2016 at 11:40:29AM -0500, Tejun Heo wrote: > Hello, > > Patchset looks good to me. Once Jens acks the first patch, I'll apply > the whole series to libata/for-4.6 w/ the field initialization > updated. Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-scs

Re: [PATCH 3/7] scsi: Drop runtime PM usage count after host is added

2016-02-19 Thread Mika Westerberg
On Fri, Feb 19, 2016 at 09:50:50AM +1100, Julian Calaby wrote: > Hi Mika, > > On Thu, Feb 18, 2016 at 7:54 PM, Mika Westerberg > wrote: > > Runtime PM of the SCSI host is already handled by calls to > > scsi_autopm_get_host() and scsi_autopm_put_host() from appropriate

[PATCH 0/7] Runtime PM support for AHCI host controller driver

2016-02-18 Thread Mika Westerberg
tosuspend_delay_ms --8<--8<--8<--8<--8<--8<--8<-- Mika Westerberg (7): block: Add blk_set_runtime_active() scsi: Set request queue runtime PM status back to active on resume scsi: Drop runtime PM usage count after host is added ahci: Cache ho

[PATCH 3/7] scsi: Drop runtime PM usage count after host is added

2016-02-18 Thread Mika Westerberg
scsi_autopm_put_host() will result idle request to be scheduled for the device. Signed-off-by: Mika Westerberg --- drivers/scsi/hosts.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c index 82ac1cd818ac..e46bf4d152a0 100644 --- a/drivers

[PATCH 1/7] block: Add blk_set_runtime_active()

2016-02-18 Thread Mika Westerberg
ng as it is in this state blk_pm_peek_request() returns NULL and thus prevents new requests to be processed. Add new function blk_set_runtime_active() that can be used to force the queue status back to "active" as needed. Signed-off-by: Mika Westerberg --- block/blk-core.c | 24

[PATCH 7/7] ahci: Add runtime PM support for the host controller

2016-02-18 Thread Mika Westerberg
) during runtime. Runtime PM is blocked by default and needs to be unblocked from userspace as needed (via power/* sysfs nodes). Signed-off-by: Mika Westerberg --- drivers/ata/ahci.c | 73 +- 1 file changed, 61 insertions(+), 12 deletions(-) diff

[PATCH 5/7] ahci: Convert driver to use modern PM hooks

2016-02-18 Thread Mika Westerberg
In order to add support for runtime PM to the ahci driver we first need to convert the driver to use modern non-legacy system suspend hooks. There should be no functional changes. Signed-off-by: Mika Westerberg --- drivers/ata/ahci.c | 49 ++--- 1

[PATCH 6/7] ahci: Add functions to manage runtime PM of AHCI ports

2016-02-18 Thread Mika Westerberg
sure host controller registers are available before using them. Signed-off-by: Mika Westerberg --- drivers/ata/libahci.c | 48 +++- 1 file changed, 47 insertions(+), 1 deletion(-) diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c index

[PATCH 4/7] ahci: Cache host controller version

2016-02-18 Thread Mika Westerberg
This allows sysfs nodes to read the cached value directly instead of powering up possibly runtime suspended controller. Signed-off-by: Mika Westerberg --- drivers/ata/ahci.h| 1 + drivers/ata/libahci.c | 7 +++ 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/ata

[PATCH 2/7] scsi: Set request queue runtime PM status back to active on resume

2016-02-18 Thread Mika Westerberg
"active" before the disk is resumed. Signed-off-by: Mika Westerberg --- drivers/scsi/scsi_pm.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/scsi_pm.c b/drivers/scsi/scsi_pm.c index 459abe1dcc87..b44c1bb687a2 100644 --- a/drivers/scsi/scsi_pm.c +++ b/drivers/

[PATCH] SCSI: Add Marvell Console to VPD blacklist

2016-01-27 Thread Mika Westerberg
vice. This gets away the error and the system starts up normally. Signed-off-by: Mika Westerberg Cc: Hannes Reinecke --- I'm not sure if this is most ideal fix. Comment on top of scsi_static_device_list[] says that the list is going away eventually and suggest me to use command line instead