[PATCH v2 5/9] qedi: Check for session online before getting iSCSI TLV data.

2018-11-21 Thread Nilesh Javali
From: Manish Rangankar The kernel panic was observed after switch side perturbation, BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] strcmp+0x20/0x40 PGD 0 Oops: [#1] SMP CPU: 8 PID: 647 Comm: kworker/8:1 Tainted: GW OE

[PATCH v2 7/9] qedi: add module param to set ping packet size

2018-11-21 Thread Nilesh Javali
Default packet size is 0x400. For jumbo packets set to 0x2400. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 1 - drivers/scsi/qedi/qedi_main.c | 13 + 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi

[PATCH v2 9/9] qedi: Update driver version to 8.33.0.21

2018-11-21 Thread Nilesh Javali
Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_version.h b/drivers/scsi/qedi/qedi_version.h index 8a0e523..41bcbba 100644 --- a/drivers/scsi/qedi/qedi_version.h +++ b/drivers/scsi

[PATCH v2 8/9] qedi: Move LL2 producer index processing in BH.

2018-11-21 Thread Nilesh Javali
From: Manish Rangankar 1. Removed logic to update HW producer index in interrupt context. 2. Update HW producer index after UIO ring and buffer gets initialized. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 31 +++ 1 file changed, 19

[PATCH v2 4/9] qedi: Allocate IRQs based on msix_cnt

2018-11-21 Thread Nilesh Javali
The driver load on some systems failed with error, [0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed. Allocate the IRQs based on MSIX count obtained from qed module instead of number of queues. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file

[PATCH v2 6/9] qedi: Add packet filter in light L2 Rx path.

2018-11-21 Thread Nilesh Javali
From: Manish Rangankar Add packet filter to avoid unnecessary packet processing in iscsiuio. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/qedi/qedi_main.c

[PATCH v2 3/9] qedi: Replace PAGE_SIZE with QEDI_PAGE_SIZE

2018-11-21 Thread Nilesh Javali
Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index

[PATCH v2 2/9] qedi: Fix spelling mistake "OUSTANDING" -> "OUTSTANDING"

2018-11-21 Thread Nilesh Javali
Fix trivial spelling mistake within macro definition. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 4 ++-- drivers/scsi/qedi/qedi_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index e966855

[PATCH v2 1/9] qedi: Cleanup redundant QEDI_PAGE_SIZE macro definition

2018-11-21 Thread Nilesh Javali
Remove redundant macro definition. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index a6f96b3..e966855 100644 --- a/drivers/scsi/qedi/qedi.h +++ b/drivers/scsi/qedi/qedi.h

[PATCH v2 0/9] qedi bug fixes

2018-11-21 Thread Nilesh Javali
Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Manish Rangankar (3): qedi: Check for session online before getting iSCSI TLV data. qedi: Add packet filter in light L2 Rx path. qedi: Move LL2 producer index processing in BH. Nilesh Javali (6

[PATCH 6/8] qedi: Add packet filter in light L2 Rx path.

2018-11-20 Thread Nilesh Javali
From: Manish Rangankar Add packet filter to avoid unnecessary packet processing in iscsiuio. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/scsi/qedi/qedi_main.c

[PATCH 8/8] qedi: Update driver version to 8.33.0.21

2018-11-20 Thread Nilesh Javali
Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi_version.h b/drivers/scsi/qedi/qedi_version.h index 8a0e523..41bcbba 100644 --- a/drivers/scsi/qedi/qedi_version.h +++ b/drivers/scsi

[PATCH 4/8] qedi: Allocate IRQs based on msix_cnt

2018-11-20 Thread Nilesh Javali
The driver load on some systems failed with error, [0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed. Allocate the IRQs based on MSIX count obtained from qed module instead of number of queues. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 2 +- 1 file

[PATCH 3/8] qedi: Replace PAGE_SIZE with QEDI_PAGE_SIZE

2018-11-20 Thread Nilesh Javali
Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index

[PATCH 2/8] qedi: Fix spelling mistake "OUSTANDING" -> "OUTSTANDING"

2018-11-20 Thread Nilesh Javali
Fix trivial spelling mistake within macro definition. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 4 ++-- drivers/scsi/qedi/qedi_main.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index e966855

[PATCH 7/8] qedi: Move LL2 producer index processing in BH.

2018-11-20 Thread Nilesh Javali
From: Manish Rangankar 1. Removed logic to update HW producer index in interrupt context. 2. Update HW producer index after UIO ring and buffer gets initialized. Signed-off-by: Manish Rangankar --- drivers/scsi/qedi/qedi_main.c | 31 +++ 1 file changed, 19

[PATCH 5/8] qedi: Check for session online before getting iSCSI TLV data.

2018-11-20 Thread Nilesh Javali
From: Manish Rangankar The kernel panic was observed after switch side perturbation, BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] strcmp+0x20/0x40 PGD 0 Oops: [#1] SMP CPU: 8 PID: 647 Comm: kworker/8:1 Tainted: GW OE

[PATCH 1/8] qedi: Cleanup redundant QEDI_PAGE_SIZE macro definition

2018-11-20 Thread Nilesh Javali
Remove redundant macro definition. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h index a6f96b3..e966855 100644 --- a/drivers/scsi/qedi/qedi.h +++ b/drivers/scsi/qedi/qedi.h

[PATCH 0/8] qedi bug fixes

2018-11-20 Thread Nilesh Javali
Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Manish Rangankar (3): qedi: Check for session online before getting iSCSI TLV data. qedi: Add packet filter in light L2 Rx path. qedi: Move LL2 producer index processing in BH. Nilesh Javali (5

[PATCH] qedi: Initialize the stats mutex lock

2018-09-27 Thread Nilesh Javali
] [] qed_mfw_fill_tlv_data+0x4b/0xb0 [qed] [] qed_mfw_process_tlv_req+0x299/0xbd0 [qed] [] ? __switch_to+0xce/0x580 [] qed_slowpath_task+0x5b/0x80 [qed] Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers

[PATCH] qedi: Add the CRC size within iSCSI NVM image

2018-08-30 Thread Nilesh Javali
are available [qedi_get_boot_info:2253]:10: Could not get NVM image. ret = -12 Hence add and adjust the CRC size to iSCSI NVM image to read boot info at qedi load time. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi.h | 7 ++- drivers/scsi/qedi/qedi_main.c | 28

[PATCH 2/2] qedi: Fix truncation of target name

2018-06-27 Thread Nilesh Javali
Use sprintf instead of snprintf to fix truncation of target name. This fix is extension of patch "scsi: qedi: Fix truncation of CHAP name and secret". Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/2] Bug fixes for static checker warnings

2018-06-27 Thread Nilesh Javali
Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Nilesh Javali (2): qedi: Correct the size of target name qedi: Fix truncation of target name drivers/scsi/qedi/qedi_iscsi.h | 2 +- drivers/scsi/qedi/qedi_main.c | 4 ++-- 2 files changed, 3

[PATCH 1/2] qedi: Correct the size of target name

2018-06-27 Thread Nilesh Javali
There is potential buffer overflow while getting the target name from the NVRAM. Correct the size of the buffer to avoid overflow. Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_iscsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedi/qedi_iscsi.h b

[PATCH] qedi: Fix static checker warning

2018-06-25 Thread Nilesh Javali
This patch fixes the static checker warning, drivers/scsi/qedi/qedi_main.c:891 qedi_get_boot_tgt_info() error: snprintf() is printing too much 256 vs 255 Signed-off-by: Nilesh Javali --- drivers/scsi/qedi/qedi_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH v3 2/2] qedi: Cleanup local str variable

2018-02-07 Thread Nilesh Javali
Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi_main.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index deaed93..47c45a5

[PATCH v3 1/2] qedi: Fix truncation of CHAP name and secret

2018-02-07 Thread Nilesh Javali
ed-off-by: Andrew Vasquez <andrew.vasq...@cavium.com> Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi_main.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_ma

[PATCH v3 0/2] Code cleanup and bug fix for truncated CHAP name and secret

2018-02-07 Thread Nilesh Javali
Martin, Please consider below patch set for next 'scsi-fixes' submission. Thanks, Nilesh Andrew Vasquez (1): qedi: Fix truncation of CHAP name and secret Nilesh Javali (1): qedi: Cleanup local str variable drivers/scsi/qedi/qedi_main.c | 55 --- 1

[PATCH V2 1/2] qedi: Fix truncation of CHAP name and secret

2018-02-06 Thread Nilesh Javali
From: Andrew Vasquez <andrew.vasq...@cavium.com> The data in NVRAM is not guaranteed to be NUL terminated. Copy the data upto the element size or to the first NUL in the byte-stream and then append a NUL. Signed-off-by: Andrew Vasquez <andrew.vasq...@cavium.com> Signed-off-by: N

[PATCH 2/2] qedi: Cleanup local str variable

2018-02-06 Thread Nilesh Javali
Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi_main.c | 43 --- 1 file changed, 20 insertions(+), 23 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index f3dd438..701bc72

[PATCH 0/2] Code cleanup and bug fix for truncated CHAP name and secret

2018-02-06 Thread Nilesh Javali
Nilesh Javali (1): qedi: Cleanup local str variable drivers/scsi/qedi/qedi_main.c | 76 ++- 1 file changed, 47 insertions(+), 29 deletions(-) -- 1.8.3.1

[PATCH] qedi: Fix truncation of name and secret

2018-01-31 Thread Nilesh Javali
Adjust the NULL byte added by snprintf. Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi_main.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c index 34a..c

[PATCH] qedi: Add ISCSI_BOOT_SYSFS to Kconfig

2017-07-19 Thread Nilesh Javali
' Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig index 2133145..6f3773f 100644 --- a/drivers/scsi/qedi/Kconfig +++ b/drivers/scsi/qedi/Kconfig @@ -5,

[PATCH v1 1/1] qedi: Add support for Boot from SAN over iSCSI offload

2017-06-27 Thread Nilesh Javali
t;manish.rangan...@cavium.com> Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi.h | 17 ++ drivers/scsi/qedi/qedi_main.c | 419 + drivers/scsi/qedi/qedi_nvm_iscsi_cfg.h | 210 +++

[PATCH 1/1] qedi: Add support for offload iSCSI Boot

2017-06-19 Thread Nilesh Javali
asquez <andrew.vasq...@cavium.com> Signed-off-by: Manish Rangankar <manish.rangan...@cavium.com> Signed-off-by: Nilesh Javali <nilesh.jav...@cavium.com> --- drivers/scsi/qedi/qedi.h | 17 ++ drivers/scsi/qedi/qedi_main.c | 419

[PATCH 0/1] qedi: Add iSCSI Boot-from-SAN support

2017-06-19 Thread Nilesh Javali
Martin, Please consider below patch for next 'scsi-fixes' submission. Thanks, Nilesh Nilesh Javali (1): qedi: Add support for offload iSCSI Boot drivers/scsi/qedi/qedi.h | 17 ++ drivers/scsi/qedi/qedi_main.c | 419 + drivers/scsi/qedi

Re: [PATCH] [SCSI] qla4xxx: mark symbols static where possible

2016-09-01 Thread Nilesh Javali
_for_ready(struct >scsi_qla_host *ha, > return rval; > } > >-uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, uint32_t addr1, >+static uint32_t ql4_84xx_ipmdio_rd_reg(struct scsi_qla_host *ha, >uint32_t addr1, > uint32_t addr3, uint32_t mask, u

Re: [patch] bnx2i: silence uninitialized variable warnings

2016-04-17 Thread Nilesh Javali
ofld_list) { >@@ -703,7 +703,7 @@ bnx2i_find_ep_in_destroy_list(struct bnx2i_hba *hba, >u32 iscsi_cid) > { > struct list_head *list; > struct list_head *tmp; >- struct bnx2i_endpoint *ep; >+ struct bnx2i_endpoint *ep = NULL; > > read_lock

Re: [PATCH 5/7] scsi: qla4xxx: shut up warning for rd_reg_indirect

2016-02-01 Thread Nilesh Javali
e >+ } else { >+ *data = 0x; > ql4_printk(KERN_ERR, ha, "%s: failed read of addr 0x%x!\n", > __func__, addr); >+ } > > return ret_val; > } >-- >2.7.0 > Acked-by: Nilesh Javali <nilesh.jav...@qlogic.com> -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH] qla4xxx: pass timeout as HZ independent value

2015-06-08 Thread Nilesh Javali
; set_current_state(TASK_UNINTERRUPTIBLE); - schedule_timeout(500); + schedule_timeout(msecs_to_jiffies(500)); } while (--retries); -- 1.7.10.4 Acked-by: Nilesh Javali nilesh.jav...@qlogic.com attachment

RE: [PATCH] scsi: unnecessary double init_completion removed

2014-12-31 Thread Nilesh Javali
Acked-by: Nilesh Javali nilesh.jav...@qlogic.com I will send the maintainer list update patch. Thanks, Nilesh -Original Message- From: Nicholas Mc Guire [mailto:der.h...@hofr.at] Sent: Tuesday, December 23, 2014 11:30 PM To: James E.J. Bottomley Cc: Dept-Eng iSCSI Driver; linux-scsi

RE: [PATCH] scsi: qla4xxx: ql4_os.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-30 Thread Nilesh Javali
Acked-By: Nilesh Javali nilesh.jav...@qlogic.com -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] Sent: Saturday, July 26, 2014 8:20 PM To: Vikas Chaudhary; Dept-Eng iSCSI Driver Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux

RE: [PATCH] scsi: qla4xxx: ql4_mbx.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-30 Thread Nilesh Javali
Acked-By: Nilesh Javali nilesh.jav...@qlogic.com -Original Message- From: Rickard Strandqvist [mailto:rickard_strandqv...@spectrumdigital.se] Sent: Sunday, July 27, 2014 8:28 PM To: Vikas Chaudhary; Dept-Eng iSCSI Driver Cc: Rickard Strandqvist; James E.J. Bottomley; linux-scsi; linux

RE: [PATCH] qla4xxx: check the return value of dma_alloc_coherent()

2014-07-30 Thread Nilesh Javali
Acked-By: Nilesh Javali nilesh.jav...@qlogic.com -Original Message- From: Maurizio Lombardi [mailto:mlomb...@redhat.com] Sent: Monday, July 28, 2014 6:25 PM To: Vikas Chaudhary Cc: Dept-Eng iSCSI Driver; linux-scsi; james.bottom...@hansenpartnership.com; h...@lst.de Subject: [PATCH