Re: [PATCH v2 2/2] libata-core: do not set dev->max_sectors for LBA48 devices

> Tom> is totally irrational for a general default. I mean, given that it > Tom> was 1024 (512k), try to double it? Fine. Try to quadruple it? > Tom> Alright. We'll need to deal with some alignment / boundary issue > Tom> (like the typical 65535 vs 65536 case)? Okay let's do it. But > Tom> what's

Re: [PATCH v2] [SCSI] dpt_i2o: use proper pci driver

On Wed, 17 Feb 2016 17:50:14 +0530 Sudip Mukherjee wrote: > This is a pci device but was not done in the usual way a pci driver is > done. Convert the driver into a proper pci driver. This looks completely wrong. Please read the I2O 1.5 specification document before

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

> > I would beg to differ. As a tool for understanding the differences as you > > step through the versions it's invaluable. > > This removes intentional formatting that > makes reading comments easier. And this matters at the end of the patch series because ? -- To unsubscribe from this list:

Re: [PATCH v4 69/78] ncr5380: Fix whitespace in comments using regexp

On Sat, 02 Jan 2016 23:54:28 -0800 Joe Perches wrote: > On Sun, 2016-01-03 at 16:06 +1100, Finn Thain wrote: > > Hanging indentation was a poor choice for the text inside comments. It > > has been used in the wrong places and done badly elsewhere. There is > > little

Re: [PATCH v3 66/77] ncr5380: Fix soft lockups

On Tue, 22 Dec 2015 12:18:44 +1100 Finn Thain wrote: > Because of the rudimentary design of the chip, it is necessary to poll the > SCSI bus signals during PIO and this tends to hog the CPU. The driver will > accept new commands while others execute, and this causes a

Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

On Wed, 9 Dec 2015 13:24:53 +0300 Dan Carpenter wrote: > On 64 bit CPUs there is a memory corruption bug on probe(). It should > be a u32 pointer instead of an unsigned long pointer or we write past > the end of the setupdata[] array. > > Signed-off-by: Dan Carpenter

Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

On Wed, 9 Dec 2015 16:45:12 +0300 Dan Carpenter wrote: > Everyone knows I didn't test it but it's an obvious one line fix for > memory corruption. If no one uses the code, at least this is harmless > and silences a static checker warning. > > In olden times we used to

Re: [patch RESEND] atp870u: 64 bit bug in atp885_init()

> You should just delete that code along with the Kconfig and Makefile > entries. Don't bother moving it to staging. The move to staging is > supposed to give people one last chance to yell if they absolutely need > the code. No one has compiled this code for years so no one will miss > it.

Re: [PATCH 3/3] libata: support host-aware ZAC devices

On Tue, 31 Mar 2015 10:52:43 +0200 Hannes Reinecke h...@suse.de wrote: Byte 69 bits 0:1 in the IDENTIFY DEVICE data are proposed to indicate a host-aware ZAC device. And whenever we detect a ZAC-compatible device we should be displaying the zoned block characteristics VPD page. I don't think

Re: [PATCH 1/3] libata: Whitelist SSDs that are known to properly return zeroes after TRIM

On Mon, 8 Dec 2014 10:15:59 -0500 Theodore Ts'o ty...@mit.edu wrote: On Fri, Dec 05, 2014 at 10:58:09PM +, Elliott, Robert (Server Storage) wrote: I have a Crucial_CT256MX1 (i.e. MX100) and it does reliably zero. make me concerned about this whitelist approach. I think you

Re: [regression] fix 32-bit breakage in block device read(2) (was Re: 32-bit bug in iovec iterator changes)

On Mon, 23 Jun 2014 11:43:02 -0400 Theodore Ts'o ty...@mit.edu wrote: On Mon, Jun 23, 2014 at 08:44:40AM +0100, Al Viro wrote: OK, here it is, hopefully with sufficient comments: The comments look really good. I assume you'll get this to Linus in time for 3.16-rc3? Fixes the 32GB

Re: [RFC 1/1] drivers/scsi/bfa/bfad_debugfs.c: replace 2 kzalloc/copy_from_user to memdup_user

On Fri, 30 May 2014 19:07:36 +0200 Fabian Frederick f...@skynet.be wrote: (memdup_user can be used to replace kmalloc/copy_from_user. Not sure if it's ok with kzalloc ...) + kern_buf = memdup_user((void __user *)buf, nbytes); + if (IS_ERR(kern_buf)) { +

Re: [PATCH/RESEND v2 1/2] Hard disk resume time optimization, asynchronous ata_port_resume

thus allowing the UI to come online sooner. There may be a short period after resume where the disks are still spinning up in the background, but the user shouldn't notice since the OS can function with the data left in RAM. I wonder how many marginal power supplies this will find 8) I