Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-13 Thread Pete Zaitcev
On Wed, 12 Dec 2007 15:38:15 -0500 (EST), Kiyoshi Ueda [EMAIL PROTECTED] wrote: On Tue, 11 Dec 2007 15:48:03 -0800, Pete Zaitcev [EMAIL PROTECTED] wrote: - end_that_request_first(rq, uptodate, rq-hard_nr_sectors); - end_that_request_last(rq, uptodate); + if (__blk_end_request(rq, error

Re: [PATCH 12/30] blk_end_request: changing ub (take 4)

2007-12-11 Thread Pete Zaitcev
; } - end_that_request_first(rq, uptodate, rq-hard_nr_sectors); - end_that_request_last(rq, uptodate); + if (__blk_end_request(rq, error, blk_rq_bytes(rq))) + BUG(); Acked-by: Pete Zaitcev [EMAIL PROTECTED] I follow the discussion, actually, and wanted to ask someone to look

Re: Retry counters in sd.c

2007-08-16 Thread Pete Zaitcev
On Wed, 15 Aug 2007 11:19:43 -0400 (EDT), Alan Stern [EMAIL PROTECTED] wrote: And that's not even taking into account the fact that sd_read_capcity(), together with everything else under sd_revalidate_disk(), gets called twice in a row during device scanning. (What's the reason for that,

Patch for SCSI CD-ROM getting wrong size

2005-07-05 Thread Pete Zaitcev
*/ unsigned use:1; /* is this device still supportable */ unsigned xa_flag:1; /* CD has XA sectors ? */ unsigned readcd_known:1;/* drive supports READ_CD (0xbe) */ Signed-off-by: Pete Zaitcev [EMAIL PROTECTED] It looks obvious that needs_sector_size