Re: [PATCH] Make advansys depend on CONFIG_VIRT_TO_BUS

2007-10-18 Thread Randy Dunlap
On Fri, 19 Oct 2007 15:04:31 +1000 Stephen Rothwell wrote: At least for now. Please explain why in the changelog (what changelog?). E.g.: so that make allmodconfig on powerpc will have a better chance of building. or whatever. Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] ---

Re: [patch 2/7] git scsi misc include fix

2007-10-16 Thread Randy Dunlap
On Tue, 16 Oct 2007 14:28:20 -0700 [EMAIL PROTECTED] wrote: From: Paul Jackson [EMAIL PROTECTED] The added line in scsi_eh.h: struct scatterlist sense_sgl; fails to compile, with the error: field 'sense_sgl' has incomplete type unless scatterlist.h happens to be included

[PATCH 2/2] pluto fix disable/enable irq

2007-10-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Pluto drivers uses disable/enable_irq(), so add prototypes for them. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/pluto.c |1 + 1 file changed, 1 insertion(+) --- linux-2.6.23-git7.orig/drivers/scsi/pluto.c +++ linux-2.6.23-git7

[PATCH 1/4] docbook: fix kernel-api content

2007-10-15 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-api docbook warnings. Warning(linux-2.6.23-git8//drivers/message/fusion/mptscsih.c:2618): No description found for parameter 'sc' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/message/fusion/mptscsih.c | 10 +++--- 1 file

2.6.23-git2 advansys build error

2007-10-13 Thread Randy Dunlap
Yes, I know that there is a boatload of advansys patches in the works. Anyway, today's git snapshot fails with: drivers/scsi/advansys.c: In function 'advansys_board_found': drivers/scsi/advansys.c:17781: error: implicit declaration of function 'to_pci_dev' drivers/scsi/advansys.c:17781:

Re: Scsi on sparc build break in 2.6.23.

2007-10-11 Thread Randy Dunlap
On Fri, 12 Oct 2007 01:56:59 +0200 Adrian Bunk wrote: On Thu, Oct 11, 2007 at 05:37:30PM -0500, Rob Landley wrote: On Thursday 11 October 2007 10:21:49 am Adrian Bunk wrote: I assume you have the full .config in your build directory, and could have taken it from there? Actually I

Re: [RFC] [PATCH 2/2] blk request timeout handler patches

2007-10-04 Thread Randy Dunlap
On Thu, 4 Oct 2007 11:20:03 -0700 [EMAIL PROTECTED] wrote: Fix scsi_dispatch_cmd() to stop timers. Signed-off-by: Malahal Naineni [EMAIL PROTECTED] diff -r 870bb598c977 drivers/scsi/scsi.c --- a/drivers/scsi/scsi.c Thu Sep 27 00:25:38 2007 -0700 +++ b/drivers/scsi/scsi.c Thu

Re: [RFC] [PATCH 1/2] blk request timeout handler patches

2007-10-04 Thread Randy Dunlap
On Thu, 4 Oct 2007 11:17:50 -0700 [EMAIL PROTECTED] wrote: Mike Christie's patches refreshed to 2.6.23-rc8-mm1. Signed-off-by: Mike Christie [EMAIL PROTECTED] Signed-off-by: Malahal Naineni [EMAIL PROTECTED] diff -r 3697367c6e4d block/ll_rw_blk.c --- a/block/ll_rw_blk.c Thu Sep

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-10-03 Thread Randy Dunlap
On Mon, 01 Oct 2007 11:51:48 -0400 bo yang wrote: Adding module parameters to configure max sectors per request # of cmds per lun. Signed-off-by: Bo Yang [EMAIL PROTECTED] --- drivers/scsi/megaraid/megaraid_sas.c | 68 - drivers/scsi/megaraid/megaraid_sas.h

Re: [PATCH 4/8] scsi: megaraid_sas - check max_sgl reported by FW for setting max_sectors_per_req

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:35:36 -0400 bo yang wrote: 1. Setting the max_sectors_per_req based on max SGL supported by the FW. Prior versions calculated this value from controller info's max_sectors_1, max_sectors_2. For certain controllers/FW, this was resulting in a value

Re: [PATCH 5/8] scsi: megaraid_sas - using unsigned long for sense_buff ptr

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:41:07 -0400 bo yang wrote: MegaRAID utilities expect sense_buff to be of type unsigned long. Signed-off-by: Bo Yang [EMAIL PROTECTED] --- drivers/scsi/megaraid/megaraid_sas.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff -uprN

Re: PATCH [2/8] scsi: megaraid_sas - add module param fast_load

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:22:10 -0400 bo yang wrote: Driver will skip physical devices scan for the first time if the fast_load is set. This is to reduce time for loading driver. Signed-off-by: Bo Yang [EMAIL PROTECTED] --- drivers/scsi/megaraid/megaraid_sas.c | 69

Re: [PATCH 3/8] scsi: megaraid_sas - add module param max_sectors, cmd_per_lun

2007-09-28 Thread Randy Dunlap
On Wed, 26 Sep 2007 11:27:50 -0400 bo yang wrote: Adding module parameters to configure max sectors per request # of cmds per lun. Signed-off-by: Bo Yang [EMAIL PROTECTED] --- drivers/scsi/megaraid/megaraid_sas.c | 94 - drivers/scsi/megaraid/megaraid_sas.h

[PATCH] Fixing signness of parameters in scsi module

2007-09-19 Thread Randy Dunlap
forwarding to linux-scsi mailing list: Acked-by: Randy Dunlap [EMAIL PROTECTED] ~~~ Begin forwarded message: Date: Wed, 19 Sep 2007 22:59:16 +0900 (JST) From: Masatake YAMATO [EMAIL PROTECTED] To: [EMAIL PROTECTED] Subject: [PATCH] Fixing signness

Re: sata scsi suggestion for make menuconfig

2007-09-08 Thread Randy Dunlap
On 08 Sep 2007 18:07:00 +0200 Andi Kleen wrote: Folkert van Heusden [EMAIL PROTECTED] writes: Hi, Maybe it is a nice enhancement for make menuconfig to more explicitly give a pop-up or so when someone selects for example a sata controller while no 'scsi-disk' support was selected?

more SCSI API doc. question

2007-08-20 Thread Randy Dunlap
Where should other (undocumented) SCSI API docs be added? I'll be glad to send updates/patches/ E.g.: scsi_bufflen(cmnd) scsi_sg_count(cmnd) scsi_sglist(cmnd) scsi_get_resid(cmnd) scsi_set_resid(cmnd, int) and all kernel-doc blocks from scsi_lib.c Thanks, --- ~Randy *** Remember to use

Re: [PATCH 8/9] define global BIT macro

2007-08-18 Thread Randy Dunlap
On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: define global BIT macro move all local BIT defines to the new globally define macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- include/linux/bitops.h |1 + include/video/sstfb.h

Re: [PATCH 8/9] define global BIT macro

2007-08-18 Thread Randy Dunlap
Jiri Slaby wrote: Randy Dunlap napsal(a): On Sat, 18 Aug 2007 11:44:12 +0200 (CEST) Jiri Slaby wrote: define global BIT macro move all local BIT defines to the new globally define macro. Signed-off-by: Jiri Slaby [EMAIL PROTECTED] --- include/linux/bitops.h |1

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-08-16 Thread Randy Dunlap
On Thu, 16 Aug 2007 09:39:54 -0500 James Bottomley wrote: On Wed, 2007-08-15 at 22:22 -0700, Randy Dunlap wrote: On Thu, 19 Jul 2007 10:49:30 -0700 Randy Dunlap wrote: On Thu, 19 Jul 2007 18:57:50 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: Yes, this problem has been

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-08-15 Thread Randy Dunlap
On Thu, 19 Jul 2007 10:49:30 -0700 Randy Dunlap wrote: On Thu, 19 Jul 2007 18:57:50 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: Yes, this problem has been around forever AFAIK. You didn't add to it. Do we need to file a bug report in Bugzilla or something, so people have

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Randy Dunlap
On Thu, 02 Aug 2007 14:26:47 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Wed, 01 Aug 2007 08:51:14 -0500 James Bottomley wrote: On Tue, 2007-07-31 at 11:40 -0700, Randy Dunlap wrote: On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: Since you grok all

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-08-02 Thread Randy Dunlap
On Thu, 2 Aug 2007 12:09:26 -0700 Randy Dunlap wrote: - diff --git a/drivers/scsi/aha152x.c b/drivers/scsi/aha152x.c index d30a307..5fe55d0 100644 --- a/drivers/scsi/aha152x.c

Re: [PATCH] scsi_transport_srp: remove tgt dependencies

2007-08-01 Thread Randy Dunlap
On Wed, 01 Aug 2007 11:20:04 -0500 James Bottomley wrote: On Thu, 2007-08-02 at 00:20 +0900, FUJITA Tomonori wrote: Hopefully, this works. Is there an easier way to remove tgt dependencies in scsi_transport_srp? [...] + depends on SCSI_SRP_ATTRS + depends on SCSI_TGT = y || SCSI_TGT

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-31 Thread Randy Dunlap
On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: Since you grok all of that (above), maybe you can help here: With these 6 patches applied, I do the following: 1. insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4) 2. mount -t vfat /dev

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-31 Thread Randy Dunlap
On Tue, 31 Jul 2007 10:59:51 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: Since you grok all of that (above), maybe you can help here: With these 6 patches applied, I do the following: 1. insert PCMCIA aha152x card with SCSI drive attached (/dev/sdb4) 2. mount -t vfat /dev

Re: [PATCH 5/6] aha152x.c - Fix check_condition code-path

2007-07-30 Thread Randy Dunlap
On Sun, 29 Jul 2007 22:27:06 +0300 Boaz Harrosh wrote: check_condition code-path was similar but more complicated to Reset. It went like this: 1. extra space was allocated at aha152x_scdata for mirroring scsi_cmnd members. 2. At aha152x_internal_queue() every not

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-24 Thread Randy Dunlap
On Tue, 24 Jul 2007 13:12:19 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: I prefer either of the !HIGHMEM or slave_alloc changes to adding a BUG_ON(). However, the SCSI people likely won't want to use the slave_alloc() change because then the driver may never get fixed. (Of course

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-19 Thread Randy Dunlap
On Thu, 19 Jul 2007 16:04:45 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Wed, 18 Jul 2007 19:43:35 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 14:58:18 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 10:33:20 -0700 Randy Dunlap wrote: Hi, I don't see the reset problem

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 12:29:24 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: If you could do some testing it is grate. The first 3 patches do not need scsi-misc specifically. Any post 2.6.20 tree will do. The last patch could

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 10:33:20 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 12:29:24 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: If you could do some testing it is grate. The first 3 patches do not need scsi-misc

[PATCH] aha152x in debug mode

2007-07-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] The symbol debug_locks conflicts with the rather global one in include/linux/locks.h. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/aha152x.c | 10 +- drivers/scsi/aha152x.h |2 +- 2 files changed, 6 insertions(+), 6 deletions

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 14:58:18 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 10:33:20 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 12:29:24 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: If you could do some testing

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-18 Thread Randy Dunlap
On Wed, 18 Jul 2007 19:43:35 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 14:58:18 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 10:33:20 -0700 Randy Dunlap wrote: On Wed, 18 Jul 2007 12:29:24 +0300 Boaz Harrosh wrote: Randy Dunlap wrote: On Mon, 16 Jul 2007 12:22:20

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-17 Thread Randy Dunlap
On Mon, 16 Jul 2007 12:22:20 +0300 Boaz Harrosh wrote: If you could do some testing it is grate. The first 3 patches do not need scsi-misc specifically. Any post 2.6.20 tree will do. The last patch could be done together with attached patch on any 2.6.22 tree. (Apply attached patch anywhere

Re: [patch 0/4] aha152x.c - Cleanup, need help in testing and auditing

2007-07-12 Thread Randy Dunlap
On Thu, 12 Jul 2007 12:42:07 +0300 Boaz Harrosh wrote: In motivation for the !use_sg cleanup and use of accessors I needed to do some restructuring of the aha152x.c driver. I have tried to be as careful as I could, but with out the hardware for testing, it is hard. Christoph and James You

Re: [PATCH] qla4xxx: allow hba to be online when initiator ip address is uninitialized

2007-06-14 Thread Randy Dunlap
On Thu, 14 Jun 2007 10:44:20 -0700 Andrew Vasquez wrote: On Thu, 14 Jun 2007, David Somayajulu wrote: On Thu, 2007-06-14 at 01:54 -0400, Mike Christie wrote: David C Somayajulu wrote: It looks ok, but creating the status variable and setting it like this, just to quiet the

scsi_debug fault-injection question

2007-06-11 Thread Randy Dunlap
Hi Doug, scsi_debug.c says: MODULE_PARM_DESC(every_nth, timeout every nth command(def=100)); I don't see where the default of 100 is set. #define DEF_EVERY_NTH 0 ... static int scsi_debug_every_nth = DEF_EVERY_NTH; Can you clarify for me, please? Thanks. --- ~Randy *** Remember to use

[PATCH] scsi_debug: correct parameter default text

2007-06-11 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Correct the module info text for the default value of every_nth to 0. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/scsi_debug.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-2622-rc4.orig/drivers/scsi/scsi_debug.c

[PATCH] scsi disk help file is not complete

2007-06-11 Thread Randy Dunlap
hope this can be changed so others can make a kernel for sata systems quicker. From: Randy Dunlap [EMAIL PROTECTED] Add help info for BLK_DEV_SD referring to its use in SATA or PATA driver configurations. Add help text for ATA indicating that it probably needs some SCSI config symbols enabled

Re: [PATCH] scsi: improve areca driver stability and compatibility

2007-06-05 Thread Randy Dunlap
On Wed, 6 Jun 2007 10:56:52 +0800 nickcheng(鄭守謙) wrote: Subject: [PATCH] scsi: improve areca driver stability and compatibility Description: 1. Implement PCI-Express error recovery function and AER capability 2. Implement the selection of ARCMSR_MAX_XFER_SECTORS_B=4096 if

Re: [SCSI]: JAZZ ESP and SUN ESP need SPI_ATTRS

2007-06-03 Thread Randy Dunlap
On Sun, 03 Jun 2007 17:36:25 -0700 (PDT) David Miller wrote: Reported by Meelis Roos. Signed-off-by: David S. Miller [EMAIL PROTECTED] diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig index 572034c..e2b2838 100644 --- a/drivers/scsi/Kconfig +++ b/drivers/scsi/Kconfig @@

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

2007-05-31 Thread Randy Dunlap
On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote: On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... CC arch/i386/boot/compresse HOSTCC arch/i386/boot/tools/build BUILD

Re: linux-2.6.22-rc3-g3f0a6766 build #287 failed in drivers/scsi/aic7xxx/aic7xxx.ko

2007-05-31 Thread Randy Dunlap
On Thu, 31 May 2007 16:56:31 -0700 Randy Dunlap wrote: On Thu, 31 May 2007 18:22:55 -0400 James Bottomley wrote: On Thu, 2007-05-31 at 18:35 +0200, Toralf Förster wrote: Hello, the build with the attached .config failed, make ends with: ... CC arch/i386/boot/compresse

Re: [patch 14/25] SCSI: use irq_handler_t where appropriate

2007-05-24 Thread Randy Dunlap
On Thu, 24 May 2007 09:04:06 -0500 James Bottomley wrote: On Thu, 2007-05-24 at 01:51 -0400, Jeff Garzik wrote: James Bottomley wrote: It's not a bug fix or even an enhancement. Historically, it is quite difficult to get maintainers to ack these ... particularly if you don't cc them.

Re: [patch 1/7] libata: check for AN support

2007-05-10 Thread Randy Dunlap
On Wed, 9 May 2007 22:09:52 -0700 Andrew Morton wrote: On Wed, 9 May 2007 16:38:09 -0700 Kristen Carlson Accardi [EMAIL PROTECTED] wrote: /** + * ata_dev_set_AN - Issue SET FEATURES - SATA FEATURES + * with sector count set to indicate + *

Re: 2.6.21 broke arm scsi on qemu -M volatilepb

2007-05-10 Thread Randy Dunlap
[adding linux-scsi] On Thu, 10 May 2007 23:59:10 -0400 Rob Landley wrote: Booting a 2.6.20 kernel under qemu works fine and gets me to a shell prompt, but booting a 2.6.21.1 kernel cycles endlessly on scsi, going: Loading iSCSI transport class v2.0-724. PCI: enabling device :00:0c.0

qla_wxyz pci_set_mwi question

2007-04-11 Thread Randy Dunlap
Both scsi/qla2xxx/qla_init.c and scsi/qla4xxx/ql4_init.c use pci_set_mwi() like this: mwi = 0; if (pci_set_mwi(ha-pdev)) mwi = PCI_COMMAND_INVALIDATE; and then go on to set the PCI_COMMAND word based on that value. I don't quite get it. pci_set_mwi() returns 0

Re: SCSI breakage on PowerMac 9500 (oldworld) between 2.6.19.7 and 2.6.20

2007-04-10 Thread Randy Dunlap
On Wed, 11 Apr 2007 03:08:50 +0200 Martin Geier wrote: Hi On Tue, Apr 10, 2007 at 03:53:59PM -0700, Randy Dunlap wrote: On Wed, 11 Apr 2007 00:12:17 +0200 Martin Geier wrote: (..) Maybe it's connected to http://marc.info/?l=linux-scsim=117596425706527w=2 but my test of 2.6.21-rc5

Re: imm module issues

2007-04-07 Thread Randy Dunlap
On Fri, 6 Apr 2007 22:34:33 -0700 Randy Dunlap wrote: [moving from lkml to linux-scsi] On Sat, 10 Mar 2007 16:00:28 +0100 Grozdan Nikolov wrote: Hi, I've compiled the 2.6.20.2 kernel today (I took the SuSE HEAD kernel instead of the vanilla one) and I'm having issues

Re: imm module issues

2007-04-06 Thread Randy Dunlap
[moving from lkml to linux-scsi] On Sat, 10 Mar 2007 16:00:28 +0100 Grozdan Nikolov wrote: Hi, I've compiled the 2.6.20.2 kernel today (I took the SuSE HEAD kernel instead of the vanilla one) and I'm having issues with the imm module. I still use a ZIP drive here for small backups and

Re: difference between arcmsr (areca) 1.20.0X.13 2.6.20 in tree driver?

2007-04-03 Thread Randy Dunlap
On Mon, 2 Apr 2007 17:21:35 -1000 Joshua Hoblitt wrote: [adding linux-scsi] Has anyone else noticed this regression? -J -- - Forwarded message from Joshua Hoblitt [EMAIL PROTECTED] - From: Joshua Hoblitt [EMAIL PROTECTED] Date: Thu, 29 Mar 2007 16:38:20 -1000 To: [EMAIL

Re: [PATCH 2/2][v3] ibmvscsi: add slave_configure to allow device restart

2007-03-29 Thread Randy Dunlap
On Thu, 29 Mar 2007 12:30:40 -0500 Robert Jennings wrote: Fixed the kernel-doc comment for ibmvscsi_slave_configure. Thanks to Randy Dunlap for pointing this out. Adding a slave_configure function for the driver. Now the disks can be restarted by the scsi mid-layer when

Re: [PATCH 2/2] ibmvscsi: add slave_configure to allow device restart

2007-03-28 Thread Randy Dunlap
On Wed, 28 Mar 2007 12:47:04 -0500 Robert Jennings wrote: Adding a slave_configure function for the driver. Now the disks can be restarted by the scsi mid-layer when the are disconnected and reconnected. Signed-off-by: Robert Jennings [EMAIL PROTECTED] Signed-off-by: Santiago Leon [EMAIL

Re: [GIT PATCH] SCSI bug fixes for 2.6.21-rc5

2007-03-27 Thread Randy Dunlap
On Tue, 27 Mar 2007 11:24:37 -0500 James Bottomley wrote: This is a fairly basic rollup of 3 basic double free or oops based bug fixes. It's disappointing that kernel-doc fixes are not being merged. Yes, they are not code bug fixes, but they are doc bug fixes, and some of us do work to try to

Re: troubles with DAC960

2007-03-24 Thread Randy Dunlap
On Sat, 24 Mar 2007 15:21:16 +0100 Boris Andratzek wrote: Boris Andratzek wrote: Hello members of the kernel-list, I'm new to this and hope I don't misuse the list in any way. Doing the update from debian sarge to etch on my server I ran into the bug documented here:

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0) + return err; Traditionally, this should be if (err) return err; The reason is that 0 is a

Re: [PATCH 2/2] fusion - honour return value of pci_enable_device() in mpt_resume()

2007-03-16 Thread Randy Dunlap
On Fri, 16 Mar 2007 11:14:51 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 08:06 -0700, Randy Dunlap wrote: On Fri, 16 Mar 2007 09:27:26 -0500 James Bottomley wrote: On Fri, 2007-03-16 at 16:05 +0900, Horms wrote: + err = pci_enable_device(pdev); + if (err 0

[PATCH] fusion kernel-doc warning fixes

2007-02-20 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix kernel-doc warnings in fusion driver code. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/message/fusion/mptbase.c | 22 +++--- drivers/message/fusion/mptscsih.c | 15 ++- drivers/message/fusion/mptspi.c

Re: Random scsi disk disappearing

2007-02-07 Thread Randy Dunlap
[lkml dropped] [old thread] On Fri, 18 Aug 2006 11:11:39 +0200 Andreas Herrmann wrote: On 18.08.2006 00:33 Stefan Richter [EMAIL PROTECTED] wrote: Andreas Herrmann wrote: Anyone interested in a script to conveniently interpret or change the SCSI logging level? Such a script

[patch] Re: SCSI logging sucks

2007-02-07 Thread Randy Dunlap
, at least for highlevel events. You need to set the level to 80 to see driver loads and that means wading through tons of extraneous crap. The logging should show more verbosity at the higher numbers, not start out with the most verbose output at the low numbers. From: Randy Dunlap [EMAIL

Re: Random scsi disk disappearing

2007-02-07 Thread Randy Dunlap
Douglas Gilbert wrote: Randy Dunlap wrote: [lkml dropped] [old thread] On Fri, 18 Aug 2006 11:11:39 +0200 Andreas Herrmann wrote: On 18.08.2006 00:33 Stefan Richter [EMAIL PROTECTED] wrote: Andreas Herrmann wrote: Anyone interested in a script to conveniently interpret or change the SCSI

Re: [BUG] Unable to handle kernel NULL pointer dereference...as_move_to_dispatch+0x11/0x135

2007-02-02 Thread Randy Dunlap
On Fri, 2 Feb 2007 16:25:41 -0800 Andrew Morton wrote: On Fri, 2 Feb 2007 12:56:30 -0800 Andrew Vasquez [EMAIL PROTECTED] wrote: dt of=/dev/raw/raw1 procs=8 oncerr=abort bs=16k disable=stats limit=2m passes=100 pattern=iot dlimit=2048 What is this mysterious dt

Re: [PATCH] Add VPD support to aacraid

2007-01-25 Thread Randy Dunlap
On Thu, 25 Jan 2007 10:47:35 +0100 Hannes Reinecke wrote: +/* Function: setinqserial + * + * Arguments: [1] pointer to void [1] int Hi-- What does that notation mean? (I know, you copied it. :) Parts of this source file use kernel-doc and parts don't. Would be nice to see it converted to all

Re: OnStream DI30: undescriptive message: CoD != 0 in idescsi_pc_intr

2007-01-21 Thread Randy Dunlap
is 2.6.19.1) -- it's a good thing it's calling our attention. There's no data corruption, btw. However, said message is quite useless because undescriptive and too terse. Not sure that this helps much. --- From: Randy Dunlap [EMAIL PROTECTED] Expand on a terse ide-scsi message. Something

Re: description on KEYs in .config file

2007-01-09 Thread Randy Dunlap
On Tue, 9 Jan 2007 16:40:05 -0800 Allexio Ju wrote: Hi, Where can I get detail description on each KEYs in .config file? I'm trying to understand what are the meaning of those before turn thme on/off. In the many Kconfig and Kconfig.* files in the kernel tree. Or by using one of the

[PATCH] megaraid: more kernel-doc fixes

2007-01-09 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] More megaraid kernel-doc fixes. Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/megaraid/mbox_defs.h |2 +- drivers/scsi/megaraid/mega_common.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.20-rc3-mm1.orig

Re: [PATCH] scsi: megaraid_{mm,mbox} init fix for kdump

2007-01-05 Thread Randy Dunlap
On Fri, 05 Jan 2007 07:10:09 -0800 Sumant Patro wrote: Hi, --- Documentation/scsi/ChangeLog.megaraid | 16 ++ drivers/scsi/megaraid/megaraid_mbox.c | 140 +++- drivers/scsi/megaraid/megaraid_mbox.h |4 3 files changed, 130 insertions(+), 30 deletions(-) diff

Re: [PATCH] scsi: megaraid_{mm,mbox} init fix for kdump

2007-01-05 Thread Randy Dunlap
submitted form. I have no problem with that as long as you'll allow it to be corrected to match kernel-doc syntax. Or don't use kernel-doc syntax there at all. Regards, Sumant -Original Message- From: Randy Dunlap [mailto:[EMAIL PROTECTED] Sent: Friday, January 05, 2007 1:35 PM To: Patro

[PATCH] megaraid: fix kernel-doc

2007-01-05 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] kernel-doc modifications: - change @param var notation to @var; - change function/description separator from ':' to '-'; - change var/description separator from '-' to ':'; - fix a few doc. typos; - don't use kernel-doc /** lead-in when the doc. block

Re: [PATCH] megaraid: fix kernel-doc

2007-01-05 Thread Randy Dunlap
On Fri, 5 Jan 2007 22:41:48 -0800 Randy Dunlap wrote: From: Randy Dunlap [EMAIL PROTECTED] Oh, this applies on top of today's patch from Sumant (which Andrew has put into -mm)... kernel-doc modifications: - change @param var notation to @var; - change function/description separator from

Re: [Patch] scsi: megaraid_{mm,mbox}: init fix for kdump

2006-12-30 Thread Randy Dunlap
On Sat, 30 Dec 2006 09:31:38 -0500 Douglas Gilbert wrote: Randy Dunlap wrote: On Fri, 29 Dec 2006 08:02:17 -0800 Sumant Patro wrote: See Documentation/SubmittingPatches: Please include output of diffstat -p1 -w70 so that we can easily see the scope of the changes. and see

[PATCH] cciss: build with PROC_FS=n

2006-12-26 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] RAID_UNKNOWN is used even when PROC_FS=n, so move it outside of the CONFIG_PROC_FS block. drivers/block/cciss.c:1910: error: 'RAID_UNKNOWN' undeclared (first use in this function) Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/block/cciss.c

Re: [PATCH 1/5] Update Documentation/pci.txt

2006-12-22 Thread Randy Dunlap
On Mon, 18 Dec 2006 00:11:33 -0700 Grant Grundler wrote: Full version of pci.txt (v6 is 677 lines): http://www.parisc-linux.org/~grundler/Documentation/pci.txt-06 I've appended patch v6 (823 lines!) and commit log entry is below. diff --git a/Documentation/pci.txt

Re: [patch 01/30] drivers/scsi/: small cleanups

2006-12-15 Thread Randy Dunlap
On Mon, 04 Dec 2006 15:18:20 -0800 [EMAIL PROTECTED] wrote: Hi, What's the status of these 30 scsi patches from akpm? Thanks. From: Adrian Bunk [EMAIL PROTECTED] This patch contains the following cleanups: - make needlessly global functions static - every file should #include the headers

Re: [PATCH] imbvscsi: use 4k buffer to transfer config data

2006-12-08 Thread Randy Dunlap
On Fri, 08 Dec 2006 20:51:37 -0600 Linda Xie wrote: Hi James, This patch changes the size of the buffer used for transfering config data to 4K. It was tested against 2.6.19-rc2 tree. Please consider it for inclusion in upstream. +/* host data buffer size */ +#define buff_size 4096

Re: Hosting of a git tree for linux-scsi

2006-12-02 Thread Randy Dunlap
On Sat, 02 Dec 2006 19:46:51 -0800 Sean Bruno wrote: Just curious if there already exists a git tree that is maintained for the purposes of patching and pulling. If one doesn't exist, is there a place to host it? I could ask around my company and see if we could host it there. There are

[PATCH] qla2xyz: use NULL instead of 0

2006-11-27 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Use NULL instead of 0 for pointers (sparse warning): drivers/scsi/qla2xxx/qla_attr.c:393:4: warning: Using plain integer as NULL pointer Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/scsi/qla2xxx/qla_attr.c |2 +- 1 file changed, 1 insertion

[PATCH] megaraid: build with PROC_FS=n

2006-11-18 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Fix megaraid build error when PROC_FS=n: drivers/built-in.o: In function `megaraid_probe_one': megaraid.c:(.text.megaraid_probe_one+0xf68): undefined reference to `mega_create_proc_entry' make: *** [.tmp_vmlinux1] Error 1 and these warnings: drivers/scsi

<    1   2