Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-07-24 Thread Robert LeBlanc
On Wed, Jun 14, 2017 at 10:47 AM, Robert LeBlanc wrote: > On Wed, Jun 14, 2017 at 3:20 AM, Rangankar, Manish > wrote: >> >> On 13/06/17 10:19 PM, "Robert LeBlanc" wrote: >> >>>On Wed, Jun 7, 2017 at 12:30 PM, Robert LeBlanc >>>wrote: >

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-14 Thread Robert LeBlanc
On Wed, Jun 14, 2017 at 3:20 AM, Rangankar, Manish wrote: > > On 13/06/17 10:19 PM, "Robert LeBlanc" wrote: > >>On Wed, Jun 7, 2017 at 12:30 PM, Robert LeBlanc >>wrote: >>> On Wed, Jun 7, 2017 at 10:28 AM, Chris Leech wrote: >>>> On Tue, Ju

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-13 Thread Robert LeBlanc
On Wed, Jun 7, 2017 at 12:30 PM, Robert LeBlanc wrote: > On Wed, Jun 7, 2017 at 10:28 AM, Chris Leech wrote: >> On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: >>> This patchset enables iSCSI offload drivers to have access to the iface >>> informati

Re: [PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-07 Thread Robert LeBlanc
On Wed, Jun 7, 2017 at 10:28 AM, Chris Leech wrote: > On Tue, Jun 06, 2017 at 12:07:10PM -0600, Robert LeBlanc wrote: >> This patchset enables iSCSI offload drivers to have access to the iface >> information provided by iscsid. This allows users to have more control >> of ho

[PATCH] Pass iface for connection

2017-06-06 Thread Robert LeBlanc
--- usr/netlink.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/usr/netlink.c b/usr/netlink.c index 1a0bf80..c474375 100644 --- a/usr/netlink.c +++ b/usr/netlink.c @@ -848,10 +848,13 @@ krecv_pdu_end(struct iscsi_conn *conn) int ktransport_ep_connect(iscs

[PATCH 2/7] scsi/scsi_transport_iscsi: Update ep_connect to include iface.

2017-06-06 Thread Robert LeBlanc
Update the ep_connect function to include the iface in the parameters passed to the driver. Since we have to make a change, also change the dst_addr to sockaddr_storage so that it is future proof and a static size. Signed-off-by: Robert LeBlanc --- drivers/scsi/scsi_transport_iscsi.c | 9

[PATCH 4/7] scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update Emulex BladeEngine driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/be2iscsi/be_cmds.c | 1 + drivers/scsi/be2iscsi/be_iscsi.c | 8 +--- drivers/scsi

[PATCH 6/7] scsi/cxgbi: Update cxgbi_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update Chelsio iSCSI driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/cxgbi/libcxgbi.c | 15 --- drivers/scsi/cxgbi/libcxgbi.h | 2 +- 2 files changed

[PATCH 3/7] ib/iSER: Add binding to source IP address.

2017-06-06 Thread Robert LeBlanc
If the iface passed in has ip address set, then attept to create an RDMA connection using it as the source IP address. This allows iSER to use multiple ports on the same network or in more complex routing configurations. Also update to accepting sockaddr_storage. Signed-off-by: Robert LeBlanc

[PATCH 7/7] scsi/qla4xxx: Update qla4xxx_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update QLogic ISP4XXX and ISP82XX drivers to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/qla4xxx/ql4_os.c | 15 --- 1 file changed, 8 insertions(+), 7

[PATCH 5/7] scsi/bnx2i: Update bnx2i_ep_connect to accept iface and sockaddr_storage.

2017-06-06 Thread Robert LeBlanc
Update QLogic NetXtreme II driver to accept the session iface for creating the iSCSI connection. Also accept dst_addr as sockaddr_storage instead of sockaddr. Signed-off-by: Robert LeBlanc --- drivers/scsi/bnx2i/bnx2i_hwi.c | 1 + drivers/scsi/bnx2i/bnx2i_iscsi.c | 13 - 2 files

[PATCH 0/7] Enable iSCSI offload drivers to use information from iface.

2017-06-06 Thread Robert LeBlanc
. This is dependent on updates to Open-iSCSI. Robert LeBlanc (7): scsi/scsi_transport_iscsi: Add iface struct to kernel. scsi/scsi_transport_iscsi: Update ep_connect to include iface. ib/iSER: Add binding to source IP address. scsi/be2iscsi: Update beiscsi_ep_connect to accept iface and

[PATCH 1/7] scsi/scsi_transport_iscsi: Add iface struct to kernel.

2017-06-06 Thread Robert LeBlanc
Allow the userspace iscsiadm to pass the iface struct of the connection so that the underlying driver can use what is most appropriate to create the iSCSI connection. Signed-off-by: Robert LeBlanc --- include/scsi/scsi_transport_iscsi.h | 95 + 1 file changed

Re: iscsi_trx going into D state

2017-01-13 Thread Robert LeBlanc
test and it should trigger automatically. Looking at release notes on the ConnectX-4-LX cards, the latest firmware may fix the bug that so easily exposes the problem with that card. My cards are SuperMicro branded cards and don't have the new firmware available yet. Good luck. Rober

Re: iscsi_trx going into D state

2017-01-12 Thread Robert LeBlanc
Sorry sent prematurely... On Thu, Jan 12, 2017 at 2:22 PM, Robert LeBlanc wrote: > I'm having trouble replicating the D state issue on Infiniband (I was > able to trigger it reliably a couple weeks back, I don't know if OFED > to verify the same results happen there as well.

Re: iscsi_trx going into D state

2017-01-12 Thread Robert LeBlanc
ead+0x380/0x380 [ 292.444075] [] kthread+0xd9/0xf0 [ 292.444076] [] ? kthread_park+0x60/0x60 [ 292.444077] [] ret_from_fork+0x25/0x30 [ 292.444078] ---[ end trace 721cfe26853c53b7 ]--- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Fri, Jan 6, 201

Re: iscsi_trx going into D state

2017-01-06 Thread Robert LeBlanc
"Reject", "IFMarker": "No", "ImmediateData": "Yes", "InitialR2T": "Yes", "MaxBurstLength": "262144", "MaxConnections": "1",

Re: iscsi_trx going into D state

2017-01-03 Thread Robert LeBlanc
71748] target_wait_for_sess_cmds calling wait_for_completion. [ 224.997636] Calling wait_for_common. [ 225.001936] Starting __wait_for_common. [ 225.006226] Calling do_wait_for_common. Thanks Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Tue, Jan 3, 2017 at

Re: iscsi_trx going into D state

2017-01-03 Thread Robert LeBlanc
tack [] target_wait_for_sess_cmds+0x49/0x190 [] isert_wait_conn+0x1a4/0x2d0 [ib_isert] [] iscsit_close_connection+0x157/0x860 [] iscsit_take_action_for_connection_exit+0x7b/0xf0 [] iscsi_target_tx_thread+0x150/0x1d0 [] kthread+0xd9/0xf0 [] ret_from_fork+0x25/0x30 [] 0xffffffff --

Re: iscsi_trx going into D state

2016-12-30 Thread Robert LeBlanc
to 10 Gb. This second is in isert (target) where when a session isn't cleanly closed, it gets hung on cleaning up the session. It seems that bug #1 triggers bug #2 much easier than on Infiniband. I hope this is useful. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A

Re: iscsi_trx going into D state

2016-12-29 Thread Robert LeBlanc
OK, I've drilled down a little more and timeout = action(timeout); in do_wait_for_common() in kernel/sched/completion.c is not returning. I'll have to see if I can make more progress tomorrow. -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62

Re: iscsi_trx going into D state

2016-12-29 Thread Robert LeBlanc
ing to call complete. [Thu Dec 29 14:02:55 2016] &sdrain.done->done = 1. [Thu Dec 29 14:02:55 2016] Returned from wait_for_completion. [Thu Dec 29 14:02:55 2016] ib_drain_qp_done going to call complete. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3B

Re: iscsi_trx going into D state

2016-12-28 Thread Robert LeBlanc
Good news! I found a 10 Gb switch laying around and put it in place of the Linux router. I'm getting the same failure with the switch, so it is not something funky with the Linux router and easier to replicate. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E

Re: iscsi_trx going into D state

2016-12-28 Thread Robert LeBlanc
some time, the fio process will report the file system is read only and the iscsi processes will be in D state on Host 1 It does seem the problem is in iser and not specific to the generic RDMA stack. I'll keep digging and reporting back. Robert LeBlanc PGP Fingerprint 79A

Re: iscsi_trx going into D state

2016-12-27 Thread Robert LeBlanc
obert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Tue, Dec 27, 2016 at 1:22 PM, Robert LeBlanc wrote: > I looked at this code and it is quiet above my ability. I created this > patch, but I don't know how to interrogate the queue to see how many >

Re: iscsi_trx going into D state

2016-12-27 Thread Robert LeBlanc
in callback. [ 1760.908991] Starting init_completion. [ 1760.911206] Calling ib_modify_qp. [ 1760.915214] Calling ib_post_send. [ 1760.917062] Starting wait_for_completion. [ 1778.230821] Setting up drain callback. [ 1778.233116] Starting init_completion. [ 1778.237510] Calling ib_modify_qp. [ 1778.2

Re: iscsi_trx going into D state

2016-12-21 Thread Robert LeBlanc
0 ?D16:12 0:00 [iscsi_np] root 21342 0.0 0.0 0 0 ?D16:29 0:00 [iscsi_trx] Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Thu, Dec 15, 2016 at 1:38 PM, Robert LeBlanc wrote: > Nicholas, >

Re: iscsi_trx going into D state

2016-12-15 Thread Robert LeBlanc
ar.xz Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Dec 12, 2016 at 4:57 PM, Robert LeBlanc wrote: > Nicholas, > > After lots of set backs and having to give up trying to get kernel > dumps on our "production" systems, I&#

Re: iscsi_trx going into D state

2016-12-12 Thread Robert LeBlanc
ce/crash.tar.xz Thanks, Robert -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Fri, Nov 4, 2016 at 3:57 PM, Robert LeBlanc wrote: > We hit this yesterday, this time it was on the tx thread (the other > ones before seem to be on the r

Re: iscsi_trx going into D state

2016-11-04 Thread Robert LeBlanc
2] Unexpected ret: -104 send data 360 [ 405.721711] tx_data returned -32, expecting 360. ---- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Oct 31, 2016 at 10:34 AM, Robert LeBlanc wrote: > Nicholas, > > Thanks for following up on

Re: iscsi_trx going into D state

2016-10-31 Thread Robert LeBlanc
haven't been able to test it well either. We will keep you updated. Thank you, Robert LeBlanc Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Sat, Oct 29, 2016 at 4:29 PM, Nicholas A. Bellinger wrote: > Hi Robert, > > On Wed, 2016-

Re: iscsi_trx going into D state

2016-10-19 Thread Robert LeBlanc
me know. It was kind of a vague request so I'm not sure what exactly is important to you. Thanks for helping us with this, Robert LeBlanc When we have problems, we usually see this in the logs: Oct 17 08:57:50 prv-0-12-sanstack kernel: iSCSI Login timeout on Network Portal 0.0.0.0:3260 Oct 17 08:

Re: iscsi_trx going into D state

2016-10-18 Thread Robert LeBlanc
nd do some more testing, but so far it has given us a little bit of hope that we may be narrowing down on the root cause. We will report back once we have some more info. Thank you, Robert LeBlanc -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 O

Re: iscsi_trx going into D state

2016-10-17 Thread Robert LeBlanc
way over my head. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Oct 17, 2016 at 9:06 PM, Zhu Lingshan wrote: > Hi Robert, > > I think the reason why you can not logout the targets is that iscsi_np in D > status. I think

Re: iscsi_trx going into D state

2016-10-17 Thread Robert LeBlanc
an up these sessions possibly due to tasks in D state. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Oct 17, 2016 at 10:32 AM, Robert LeBlanc wrote: > Some more info as we hit this this morning. We have volumes mirrored > between

Re: iscsi_trx going into D state

2016-10-17 Thread Robert LeBlanc
In addition, on the client we see: Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Oct 17, 2016 at 10:32 AM, Robert LeBlanc wrote: > Some more info as we hit this this morning. We have volumes mirrored > between two targets and

Re: iscsi_trx going into D state

2016-10-17 Thread Robert LeBlanc
state. I don't know if stale sessions on the clients could be contributing to this issue (the target trying to close non-existent sessions??). This is on 4.4.23. Any more debug info we can throw at this problem to help? Thank you, Robert LeBlanc # ps aux | grep D | grep iscsi root 16525

Re: iscsi_trx going into D state

2016-10-05 Thread Robert LeBlanc
Thanks, we will apply that too. We'd like to get this stable. We'll report back on what we find with these patches. -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Wed, Oct 5, 2016 at 12:03 PM, Christoph Hellwig wrote: > Hi

Re: iscsi_trx going into D state

2016-10-05 Thread Robert LeBlanc
We are not able to identify the patch that you mentioned from Lee, can you give us a commit or a link to the patch? Thanks, Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Tue, Oct 4, 2016 at 5:46 AM, Christoph Hellwig wrote: > On Tue,

Re: iscsi_trx going into D state

2016-10-04 Thread Robert LeBlanc
Do you want me to try this patch or wait for some of the suggestions Christoph brought up to be Incorporated? Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Tue, Oct 4, 2016 at 5:46 AM, Christoph Hellwig wrote: > On Tue, Oct 04, 2016 at

iscsi_trx going into D state

2016-09-30 Thread Robert LeBlanc
/0x40 [] iscsi_target_do_login+0x140/0x640 [] iscsi_target_start_negotiation+0x1c/0xb0 [] iscsi_target_login_thread+0xa9b/0xfc0 [] kthread+0xd8/0xf0 [] ret_from_fork+0x3f/0x70 [] 0x What can we do to help get this resolved? Thanks, Robert LeBlanc PGP Fingerprint 79A2

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-24 Thread Robert LeBlanc
;10.218.128.17;3760864;940216;22305 block;sdd;10.219.128.17;3763564;940891;22289 block;sde;10.220.128.17;4965436;1241359;16894 It seems that mlx_tune marginally helps, but not really providing anything groundbreaking. Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Wed, Jun

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-22 Thread Robert LeBlanc
me to know when I was reaching the theoretical max of the card/links/PCIe. I just may have my scripts run the three tests in succession. Thanks for looking at this. Please let me know what you think would be most helpful so that I'm making the best use of your and my time. Thanks,

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-22 Thread Robert LeBlanc
I hope that clears up the confusion, if not, please ask for more clarification. On Jun 22, 2016 2:18 AM, "Bart Van Assche" wrote: > > On 06/21/2016 10:26 PM, Robert LeBlanc wrote: >> >> Srpt keeps crashing couldn't test > > > If this is reproducible with the

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-21 Thread Robert LeBlanc
0911;17463 sdd;10.220.202.17;4832982;1208245;17357 sde;10.220.203.17;4809430;1202357;17442 sdf;10.220.204.17;4808878;1202219;17444 mlx5_0;sdd;2986864;746716;28085 mlx5_0;sdc;2963648;740912;28305 mlx4_0;sdb;3317228;829307;25288 Thanks, -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-21 Thread Robert LeBlanc
04.17;3444164;861041;24356 sdb;10.220.128.17;4803646;1200911;17463 sdd;10.220.202.17;4832982;1208245;17357 sde;10.220.203.17;4809430;1202357;17442 sdf;10.220.204.17;4808878;1202219;17444 Thanks for the suggestions, I'll work to get some of the requested data back to you guys quickly. Robert LeBlanc

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-20 Thread Robert LeBlanc
I can test with SRP and report back what I find (haven't used SRP in years so I'll need to brush up on it). -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Mon, Jun 20, 2016 at 3:27 PM, Max Gurtovoy wrote: > Did you see

Re: Connect-IB not performing as well as ConnectX-3 with iSER

2016-06-20 Thread Robert LeBlanc
t. If there is anything I can do to help out, please let me know. Thank you, ---- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 On Fri, Jun 10, 2016 at 3:36 PM, Robert LeBlanc wrote: > I bisected the kernel and it looks like the performance o

Re: Performance degradation on 4.6

2016-06-02 Thread Robert LeBlanc
I'm trying to bisect this (target,initiator, kernel commit), but I'm having issues replicating my 4.4 results at the moment. Once I get that done, hopefully I can get to the bottom of where things are slowing down. -------- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904

Performance degradation on 4.6

2016-05-31 Thread Robert LeBlanc
information I can provide that would be useful? Thanks, ---- Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC4 45DD A904 C70E E654 3BB2 FA62 B9F1 -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@vger.kernel.org More m

Follow up on iSCSI and MQ/MCS discussion

2016-05-23 Thread Robert LeBlanc
t? With the 4.4 kernel, I think I'm still seeing the "old" behavior. Please include me in the reply as I'm not subscribed to the list. [0] http://marc.info/?l=linux-scsi&m=142064790924994&w=2 Thanks, Robert LeBlanc PGP Fingerprint 79A2 9CA4 6CC