Open-FCoE Maintainer Transition

Hello community, It is with mixed feelings that I send this mail to state that I am transitioning maintainership of Open-FCoE. I'm still working on Linux solutions, but now I'm focusing on SDN/NfV technologies. I'll still be around and I'll continue to help where I can. Vasu Dev will

[PATCH] Transition maintainership to Vasu.

Acked-by: Vasu Dev vasu@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- MAINTAINERS |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 8ccf31c..c9afcf3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3539,7 +3539,7 @@ F

[PATCH 07/19] libfc: Clarify fc_exch_find()

From: Bart Van Assche bvanass...@acm.org The condition ep != NULL ep-xid != xid can never be met. Make this explicit. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c

[PATCH 03/19] fcoe: cleanup return codes from fcoe_rcv

From: Neil Horman nhor...@tuxdriver.com the return codes from fcoe_rcv should be NET_RX_*, not 0 or -1. Signed-off-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 05/19] libfc: Debug code fixes

...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |8 drivers/scsi/libfc/fc_lport.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc

[PATCH 08/19] libfc: Fix a race in fc_exch_timer_set_locked()

code with poisoning enabled in the memory allocator. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH 09/19] libfc: Protect ep-esb_stat changes via ex_lock

Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index 7000203..bc0aba4 100644

[PATCH 01/19] fcoe: ensure that skb placed on the fip_recv_list are unshared

. The fix is pretty easy, just make sure that we clone the skb if its got multiple users with the skb_share_check function, like other protocols do. Signed-off-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c |3 +++ 1 file

[PATCH 02/19] fcoe: make sure fcoe frames are unshared prior to manipulating them

the skb is unshared prior to doing anything with it. Signed-off-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c

[PATCH 10/19] libfc: Avoid that sending after an abort triggers a kernel warning

-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/libfc

[PATCH 00/19] libfc, libfcoe, and fcoe updates for 3.13

are unshared fcoe: make sure fcoe frames are unshared prior to manipulating them fcoe: cleanup return codes from fcoe_rcv fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path Robert Love (1): libfcoe: Make fcoe_sysfs optional / fix fnic NULL exception drivers

[PATCH 17/19] libfcoe: Make fcoe_sysfs optional / fix fnic NULL exception

with fcoe_sysfs. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com Tested-by: Hiral Patel hiral...@cisco.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |1 drivers/scsi/fcoe/fcoe.c |1 drivers/scsi/fcoe/fcoe_ctlr.c | 94

[PATCH 18/19] fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path

merge this with it, or apply it on top of what you already have, that would be great. Thanks! Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: the...@redhat.com Reported-by: the...@redhat.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c |1 + 1 file

[PATCH 19/19] scsi: Convert uses of compare_ether_addr to ether_addr_equal

) + ether_addr_equal(a, b) Signed-off-by: Joe Perches j...@perches.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |3 +-- drivers/scsi/fcoe/fcoe.c |2 +- drivers/scsi/fcoe/fcoe_ctlr.c | 22 +++--- drivers/scsi/fcoe/fcoe_sysfs.c

[PATCH 14/19] fcoe: Declare fcoe_ctlr_mode_set() static

From: Bart Van Assche bvanass...@acm.org The function fcoe_ctlr_mode_set() is local, hence declare it static. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c |4

[PATCH 15/19] fcoe: Add missing newlines in debug messages

From: Bart Van Assche bvanass...@acm.org FCoE debug statements must end in a newline. Add one where it is missing. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 12

[PATCH 12/19] libfc: Do not invoke the response handler after fc_exch_done()

a command has been aborted. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c | 131 +- include/scsi/libfc.h |9 +++ 2 files

[PATCH 13/19] fcp: Do not interpret check condition as underrun

-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_fcp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 5fd0f1f..1d7e76e 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi

[PATCH 16/19] fcoe: Reduce fcoe_sysfs_fcf_add() stack usage

-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c

[PATCH 11/19] libfc: Reduce exchange lock contention in fc_exch_recv_abts()

From: Bart Van Assche bvanass...@acm.org Reduce the time during which the exchange lock is held by allocating a frame before obtaining the exchange lock. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com

[PATCH 06/19] libfc: Micro-optimize fc_setup_exch_mgr()

From: Bart Van Assche bvanass...@acm.org Convert a loop into an ilog2() call. Although this code is not performance sensitive this conversion makes this code easier to read. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love

[PATCH 04/19] libfc: Source code comment spelling fixes

From: Bart Van Assche bvanass...@acm.org Change 'initiaive' into 'initiative', 'remainig' into 'remaining' and change 'exected' into 'expected'. Signed-off-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |5

fcoe request pull 3.13

them fcoe: cleanup return codes from fcoe_rcv fcoe: Fix missing mutex_unlock in fcoe_sysfs_fcf_add error path Robert Love (1): libfcoe: Make fcoe_sysfs optional / fix fnic NULL exception drivers/scsi/bnx2fc/bnx2fc_fcoe.c |4 +- drivers/scsi/fcoe/fcoe.c | 25

[PATCH 03/16] fcoe: cleanup return codes from fcoe_rcv

From: Neil Horman nhor...@tuxdriver.com the return codes from fcoe_rcv should be NET_RX_*, not 0 or -1. Signed-off-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH 13/16] fcp: Do not interpret check condition as underrun

-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_fcp.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_fcp.c b/drivers/scsi/libfc/fc_fcp.c index 5fd0f1f..1d7e76e 100644 --- a/drivers/scsi/libfc/fc_fcp.c +++ b/drivers/scsi

[PATCH 05/16] libfc: Debug code fixes

...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |8 drivers/scsi/libfc/fc_lport.c |2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc

[PATCH 14/16] fcoe: Declare fcoe_ctlr_mode_set() static

From: Bart Van Assche bvanass...@acm.org The function fcoe_ctlr_mode_set() is local, hence declare it static. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c |4

[PATCH 04/16] libfc: Source code comment spelling fixes

From: Bart Van Assche bvanass...@acm.org Change 'initiaive' into 'initiative', 'remainig' into 'remaining' and change 'exected' into 'expected'. Signed-off-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |5

[PATCH 16/16] fcoe: Reduce fcoe_sysfs_fcf_add() stack usage

-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c | 40 +++- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c

[PATCH 09/16] libfc: Protect ep-esb_stat changes via ex_lock

Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/libfc/fc_exch.c b/drivers/scsi/libfc/fc_exch.c index 7000203..bc0aba4 100644

[PATCH 08/16] libfc: Fix a race in fc_exch_timer_set_locked()

code with poisoning enabled in the memory allocator. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff

[PATCH 02/16] fcoe: make sure fcoe frames are unshared prior to manipulating them

the skb is unshared prior to doing anything with it. Signed-off-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c

[PATCH 07/16] libfc: Clarify fc_exch_find()

From: Bart Van Assche bvanass...@acm.org The condition ep != NULL ep-xid != xid can never be met. Make this explicit. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c

[PATCH 10/16] libfc: Avoid that sending after an abort triggers a kernel warning

-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c | 59 ++ 1 file changed, 37 insertions(+), 22 deletions(-) diff --git a/drivers/scsi/libfc

[PATCH 06/16] libfc: Micro-optimize fc_setup_exch_mgr()

From: Bart Van Assche bvanass...@acm.org Convert a loop into an ilog2() call. Although this code is not performance sensitive this conversion makes this code easier to read. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love

[PATCH 11/16] libfc: Reduce exchange lock contention in fc_exch_recv_abts()

From: Bart Van Assche bvanass...@acm.org Reduce the time during which the exchange lock is held by allocating a frame before obtaining the exchange lock. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com

[PATCH 00/16] libfc, libfcoe, fcoe updates for 3.12(+)

The following series implements some fixes and enhancements. I know this series may be a bit late for the merge window. They have been in my tree so they could see some testing. Now that that is done I don't want to hold them back anymore. Please pull when appropriate. --- Bart Van Assche

[PATCH 15/16] fcoe: Add missing newlines in debug messages

From: Bart Van Assche bvanass...@acm.org FCoE debug statements must end in a newline. Add one where it is missing. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 12

[PATCH 0/8] libfc, libfcoe, fcoe updates for 3.11(+)

Rustad (2): libfc: Reject PLOGI from nodes with incompatible role fcoe: Stop fc_rport_priv structure leak Neerav Parikh (1): fcoe: Fix smatch warning in fcoe_fdmi_info function Robert Love (3): libfc: Remove extra space in fc_exch_timer_cancel definition libfc

[PATCH 2/8] fcoe: Fix smatch warning in fcoe_fdmi_info function

Tested-by: Jack Morgan jack.mor...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 26 +++--- 1 file changed, 15 insertions(+), 11 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c index 32ae6c6..3336e57

[PATCH 3/8] fcoe: fix the link error status block sparse warnings

directly. This fixes the warning from sparse check. Signed-off-by: Yi Zou yi@intel.com Reported-by: Fengguang Wu fengguang...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_transport.c | 22

[PATCH 5/8] libfc: Differentiate echange timer cancellation debug statements

There are two debug statements with the same output string regarding echange timer cancellation. This patch simply changes the output of one string so that they can be differentiated. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Acked-by: Neil

[PATCH 4/8] libfc: Remove extra space in fc_exch_timer_cancel definition

Simply remove an extra space that violates coding style. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/libfc/fc_exch.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PATCH 1/8] libfc: Reject PLOGI from nodes with incompatible role

-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_rport.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 6bbb944..c710d90 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers

[PATCH 6/8] libfcoe: Fix meaningless log statement

ctlr_dev was initialized to NULL, and never re-assigned. This caused the log statement to always report failure. This patch removes the unused variable and fixes the log statement to always report 'success', as that is what should be logged if the code reaches this point. Signed-off-by: Robert

[PATCH 7/8] fcoe: Stop fc_rport_priv structure leak

mark.d.rus...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c |4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index 795843d..203415e 100644

[PATCH 8/8] fcoe: Reduce number of sparse warnings

From: Bart Van Assche bvanass...@acm.org Declare local variables and functions 'static'. This patch does not change any functionality. Signed-off-by: Bart Van Assche bvanass...@acm.org Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_sysfs.c | 24

[PATCH 0/4] libfc, libfcoe, fcoe updates for 3.10-rc

The following series implements a few random fixes. --- Krishna Mohan (1): libfcoe: Fix Conflicting FCFs issue in the fabric Mark Rustad (1): libfc: Correct check for initiator role Neil Horman (2): libfc: extend ex_lock to protect all of fc_seq_send MAINTAINERS: Fix

[PATCH 1/4] libfcoe: Fix Conflicting FCFs issue in the fabric

Reviewed-by: Bhanu Prakash Gollapudi bprak...@broadcom.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c | 15 +-- 1 file changed, 5 insertions(+), 10 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index a762472

[PATCH 2/4] libfc: Correct check for initiator role

-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_rport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index d518d17..6bbb944 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b/drivers/scsi

[PATCH 3/4] libfc: extend ex_lock to protect all of fc_seq_send

through the entire fc_seq_send path Signed-off-by: Neil Horman nhor...@tuxdriver.com Reported-by: Gris Ge f...@redhat.com CC: Robert Love robert.w.l...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_exch.c | 37 - 1

[PATCH 4/4] MAINTAINERS: Fix fcoe mailing list

From: Neil Horman nhor...@tuxdriver.com The FCoE mailing list has moved, updte it in the MAINTAINERS file Signed-off-by: Neil Horman nhor...@tuxdriver.com CC: Robert Love robert.w.l...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- MAINTAINERS |2 +- 1 file changed, 1

[PATCH 0/5] libfc, bnx2fc, fcoe fixes for 3.9-rc

These patches are needed to allow fcoe to move to the new sysfs interfaces. I would like to see these pushed upstream for 3.9-rc. A pull-request mail will immediately follow this series. --- Robert Love (5): bnx2fc: Make the fcoe_cltr the SCSI host parent fcoe: Fix deadlock between

[PATCH 2/5] fcoe: Fix deadlock between create and destroy paths

[ 4200.503308] [81087070] ? kthread_create_on_node+0x160/0x160 Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com --- drivers/scsi/fcoe/fcoe.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/fcoe

[PATCH 1/5] bnx2fc: Make the fcoe_cltr the SCSI host parent

for bnx2fc. This patch sets up the correct linkage for bnx2fc such that fcoemon will work correctly with fcoe_sysfs and bnx2fc. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Bhanu Prakash Gollapudi bprak...@broadcom.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c |5 ++--- 1 file changed

[PATCH 3/5] libfc, fcoe, bnx2fc: Always use fcoe_disc_init for discovery layer initialization

Currently libfcoe is doing some libfc discovery layer initialization outside of libfc. This patch moves this code into libfc and sets up a split in discovery (one time) initialization code and (re-configurable) settings that will come in the next patch. Signed-off-by: Robert Love robert.w.l

[PATCH 4/5] libfc, fcoe, bnx2fc: Split fc_disc_init into fc_disc_{init, config}

Split discovery initialization in code that is setup once (fcoe_disc_init) and code that can be re-configured (fcoe_disc_config). Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Reviewed-by: Bhanu Prakash Gollapudi bprak...@broadcom.com --- drivers

[PATCH 5/5] libfcoe: Fix fcoe_sysfs VN2VN mode

-by: Robert Love robert.w.l...@intel.com Tested-by: Jack Morgan jack.mor...@intel.com Reviewed-by: Bhanu Prakash Gollapudi bprak...@broadcom.com --- drivers/scsi/fcoe/fcoe_ctlr.c | 60 +++-- 1 file changed, 45 insertions(+), 15 deletions(-) diff --git

[PATCH 01/21] libfc: fix REC handling

order won't cause any issue during clearing FC_RP_FLAGS_REC_SUPPORTED on failed IO with target not supporting FC_RP_FLAGS_REC_SUPPORTED, since retry on failed IO would succeed. Signed-off-by: Vasu Dev vasu@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com Signed-off-by: Robert Love

[PATCH 00/21] libfc, libfcoe and fcoe updates for 3.9

: close race on link speed detection in fcoe code Robert Love (7): Documentation: Add missing devices/ to devices path libfcoe: Save some memory and optimize name lookups libfcoe: Add fcoe_sysfs debug logging level libfcoe, fcoe, bnx2fc: Add new fcoe control interface

[PATCH 03/21] libfcoe: Save some memory and optimize name lookups

with a latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love robert.w.l

[PATCH 04/21] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions

[PATCH 02/21] Documentation: Add missing devices/ to devices path

Add missing 'devices/ subdirectory to /sys/bus/fcoe/devices/ctlr_X and /sys/bus/fcoe/devices/fcf_X references. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com --- Documentation/ABI/testing/sysfs-bus-fcoe |4 ++-- 1 file changed, 2

[PATCH 06/21] fcoe: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love robert.w.l...@intel.com Acked

[PATCH 05/21] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

that the enalbed state has changed. This patch maintains the old FCoE control interfaces as module parameters, but it adds comments pointing out that the old interfaces are deprecated. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- Documentation/ABI

[PATCH 08/21] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info

Convert libfc, libfcoe and fcoe's debug_logging macros to use pr_info() instead of printk(KERN_INFO, ...). checkpatch.pl now complains about this, so convert libfcoe to preferred method. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com

[PATCH 09/21] fcoe: prep work to start consolidate the usage of fcoe_netdev

to make use of it. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- include/scsi/libfcoe.h |1 + 1 file changed, 1 insertion(+) diff --git a/include

[PATCH 10/21] fcoe: add support to the get_netdev() for fcoe_interface

From: Yi Zou yi@intel.com Adds support to fcoe_port's newly added get_netdev fucntion pointer. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com

[PATCH 11/21] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it

Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 35 --- drivers/scsi/fcoe/fcoe_transport.c | 35 +++ include/scsi/libfcoe.h |1 + 3 files changed, 36 insertions(+), 35

[PATCH 12/21] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb

Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 40 --- drivers/scsi/fcoe/fcoe_transport.c | 54 include/scsi/libfcoe.h |2 + 3 files changed

[PATCH 13/21] bnx2fc: add support to get_netdev for bnx2f_interface

From: Yi Zou yi@intel.com Adds support to fcoe_port's newly added get_netdev fucntion pointer for bnx2fc. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l

[PATCH 14/21] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe

-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 9b9ccc9..a1c687c 100644

[PATCH 15/21] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe

From: Yi Zou yi@intel.com Drop the bnx2fc_xxx versions as they are basically the same. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers

[PATCH 16/21] debris left by [SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks

... Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_transport.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index

[PATCH 18/21] fcoe: close race on link speed detection in fcoe code

by Robert Love to satisfy checkpatch.pl ] Signed-off-by: Neil Horman nhor...@tuxdriver.com Reviewed-by: Yi Zou yi@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff

[PATCH 20/21] libfcoe: Handle CVL while waiting to select an FCF

reject the FLOGI, as it has cleared its internal state, and expects the initiator to start FIP discovery protocol. Fix this condition by resetting the fcoe controller. Signed-off-by: Bhanu Prakash Gollapudi bprak...@broadcom.com Reviewed-by: Yi Zou yi@intel.com Signed-off-by: Robert Love

[PATCH 19/21] fcoe: Fix deadlock while deleting FCoE interface with NPIV ports

lport before continuing with the removal of the root lport. Signed-off-by: Neerav Parikh neerav.par...@intel.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 23

[PATCH 21/21] libfc: XenServer fails to mount root filesystem.

...@cisco.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/libfc/fc_rport.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/libfc/fc_rport.c b/drivers/scsi/libfc/fc_rport.c index 83aa1ef..d518d17 100644 --- a/drivers/scsi/libfc/fc_rport.c +++ b

[PATCH] libfcoe: Check for unusable FCFs before looking for conflicting FCFs

...@broadcom.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_ctlr.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c index aff3c44..7aca9fd 100644 --- a/drivers/scsi

[PATCH v2] libfcoe: Save some memory and optimize name lookups

with a latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love robert.w.l

FCoE Updates for 3.8 (v2)

(1): debris left by [SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks Robert Love (7): Documentation: Add missing devices/ to devices path libfcoe: Save some memory and optimize name lookups libfcoe: Add fcoe_sysfs debug logging level libfcoe, fcoe, bnx2fc

[PATCH 02/16] Documentation: Add missing devices/ to devices path

Add missing 'devices/ subdirectory to /sys/bus/fcoe/devices/ctlr_X and /sys/bus/fcoe/devices/fcf_X references. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Ross Brattain ross.b.bratt...@intel.com --- Documentation/ABI/testing/sysfs-bus-fcoe |4 ++-- 1 file changed, 2

[PATCH 03/16] libfcoe: Save some memory and optimize name lookups

with a latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love robert.w.l

[PATCH 04/16] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love robert.w.l...@intel.com Acked-by: Neil Horman nhor...@tuxdriver.com --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions

[PATCH 07/16] bnx2fc: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love robert.w.l...@intel.com Acked

[PATCH 06/16] fcoe: Use the fcoe_sysfs control interface

. The fcoe_ctlr's link state is now driven by both the netdev link state as well as the fcoe_ctlr_device's enabled attribute. The link must be up and the fcoe_ctlr_device must be enabled before the FCoE Controller starts discovery or login. Signed-off-by: Robert Love robert.w.l...@intel.com Acked

[PATCH 08/16] libfc, libfcoe, fcoe: Convert debug_logging macros to pr_info

Convert libfc, libfcoe and fcoe's debug_logging macros to use pr_info() instead of printk(KERN_INFO, ...). checkpatch.pl now complains about this, so convert libfcoe to preferred method. Signed-off-by: Robert Love robert.w.l...@intel.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com

[PATCH 09/16] fcoe: prep work to start consolidate the usage of fcoe_netdev

to make use of it. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- include/scsi/libfcoe.h |1 + 1 file changed, 1 insertion(+) diff --git a/include

[PATCH 10/16] fcoe: add support to the get_netdev() for fcoe_interface

From: Yi Zou yi@intel.com Adds support to fcoe_port's newly added get_netdev fucntion pointer. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com

[PATCH 12/16] libfcoe, fcoe: consolidate the fcoe_ctlr_get_lesb/fcoe_get_lesb

Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 40 --- drivers/scsi/fcoe/fcoe_transport.c | 54 include/scsi/libfcoe.h |2 + 3 files changed

[PATCH 11/16] libfcoe, fcoe: move fcoe_link_speed_update() to libfcoe and export it

Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe.c | 35 --- drivers/scsi/fcoe/fcoe_transport.c | 35 +++ include/scsi/libfcoe.h |1 + 3 files changed, 36 insertions(+), 35

[PATCH 13/16] bnx2fc: add support to get_netdev for bnx2f_interface

From: Yi Zou yi@intel.com Adds support to fcoe_port's newly added get_netdev fucntion pointer for bnx2fc. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l

[PATCH 14/16] bnx2fc: use fcoe_link_speed_update() from the exported symbol in libfcoe

-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --git a/drivers/scsi/bnx2fc/bnx2fc_fcoe.c b/drivers/scsi/bnx2fc/bnx2fc_fcoe.c index 9b9ccc9..a1c687c 100644

[PATCH 15/16] bnx2fc: use fcoe_get_lesb/fcoe_ctlr_get_lesb() directly from libfcoe

From: Yi Zou yi@intel.com Drop the bnx2fc_xxx versions as they are basically the same. Signed-off-by: Yi Zou yi@intel.com Cc: Bhanu Prakash Gollapudi bprak...@broadcom.com Tested-by: Marcus Dennis marcusx.e.den...@intel.com Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers

[PATCH 16/16] debris left by [SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks

... Signed-off-by: Al Viro v...@zeniv.linux.org.uk Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_transport.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/scsi/fcoe/fcoe_transport.c b/drivers/scsi/fcoe/fcoe_transport.c index

FCoE Updates for 3.8

to 04f0ac991b5dd2a32c3fa3dcb2cf34830949afa5: debris left by [SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks (2012-12-11 10:22:36 -0800) Al Viro (1): debris left by [SCSI] libfcoe: Remove mutex_trylock/restart_syscall checks Robert

[RFC PATCH v4 0/5] Add new fcoe_sysfs based control interfaces to libfcoe, bnx2fc and fcoe

upstream after v3.5, anyone who compiles this can ignore section mismatch warning. Also note that a modified fcoemon is needed to use the fcoe system service against this kernel modification. I'd be happy to provide that fcoemon code on request. --- Robert Love (5): libfcoe: Save some memory

[RFC PATCH v4 1/5] libfcoe: Save some memory and optimize name lookups

with a latter patch that will add more fcoe_sysfs attributes that will also use the fcoe_enum_name_search macro. One attribute will also do a reverse lookup which requires less code when the enum-to-string mappings are organized as this patch makes them to be. Signed-off-by: Robert Love robert.w.l

[RFC PATCH v4 2/5] libfcoe: Add fcoe_sysfs debug logging level

Add a macro to print fcoe_sysfs debug statements. Signed-off-by: Robert Love robert.w.l...@intel.com --- drivers/scsi/fcoe/fcoe_sysfs.c |7 +++ drivers/scsi/fcoe/libfcoe.h| 11 --- 2 files changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/fcoe

[RFC PATCH v4 3/5] libfcoe, fcoe, bnx2fc: Add new fcoe control interface

that the enalbed state has changed. This patch maintains the old FCoE control interfaces as module parameters, but it adds comments pointing out that the old interfaces are deprecated. Signed-off-by: Robert Love robert.w.l...@intel.com --- Documentation/ABI/testing/sysfs-bus-fcoe | 42 + drivers

  1   2   >