Do you think that the appropriate patches could be copied to the
appropriate people please?
On Thu, Jan 11, 2018 at 04:46:24PM -0800, Dan Williams wrote:
> Changes since v1 [1]:
> * fixup the ifence definition to use alternative_2 per recent AMD
> changes in tip/x86/pti (Tom)
>
> * drop
phy_interface;
^~~
Add linux/phy.h to macb.h
Signed-off-by: Russell King <rmk+ker...@armlinux.org.uk>
---
drivers/net/ethernet/cadence/macb.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/cadence/macb.h
b/drivers/net/ethernet/cadence/macb.h
index d67ada
y: Ondrej Zary <li...@rainbow-software.org>
> Tested-by: Michael Schmitz <schmitz...@gmail.com>
> ---
> drivers/scsi/arm/cumana_1.c | 60
> drivers/scsi/arm/oak.c | 23
For these two,
Acked-by: Russell King <rmk+ker...
t;
> Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
> Reviewed-by: Hannes Reinecke <h...@suse.com>
> Tested-by: Ondrej Zary <li...@rainbow-software.org>
> Tested-by: Michael Schmitz <schmitz...@gmail.com>
> ---
> drivers/scsi/arm/cumana_1.c | 20 +++-----
On Mon, Oct 10, 2016 at 12:46:52AM -0400, Finn Thain wrote:
> Signed-off-by: Finn Thain <fth...@telegraphics.com.au>
> Reviewed-by: Hannes Reinecke <h...@suse.com>
Thanks.
Acked-by: Russell King <rmk+ker...@armlinux.org.uk>
--
RMK's Patch system: http://www.armlinux.
On Mon, Oct 10, 2016 at 12:46:53AM -0400, Finn Thain wrote:
> Avoid the call to NCR5380_poll_politely2() when possible. The call is
> easily short-circuited on the PIO fast path, using the inline wrapper.
> This requires that the NCR5380_read macro be made available before
> any #include
d-off-by: Finn Thain <fth...@telegraphics.com.au>
> Reviewed-by: Hannes Reinecke <h...@suse.com>
> Tested-by: Ondrej Zary <li...@rainbow-software.org>
> Tested-by: Michael Schmitz <schmitz...@gmail.com>
> ---
> drivers/scsi/arm/cumana_1.c | 26 ++-
On Mon, Nov 16, 2015 at 05:49:23PM +0100, Arnd Bergmann wrote:
> It turns out that the commit that introduced this used the cpu_to_le32()
> incorrectly on an 8-bit field, which results in the sense_len to always
> be set to zero, as the SCSI_SENSE_BUFFERSIZE value gets moved to upper
> byte of the
On Wed, Apr 01, 2015 at 12:31:16PM -0400, Tejun Heo wrote:
On Wed, Apr 01, 2015 at 12:13:36PM -0400, Tejun Heo wrote:
Signed-off-by : Suman Tripathi stripa...@apm.com
Applied to libata/for-4.1 w/ minor edit.
Reverted due to build failure from missing asm/cputype.h.
I'm guessing this
On Wed, Apr 01, 2015 at 06:00:33PM +0100, Catalin Marinas wrote:
On Wed, Apr 01, 2015 at 05:39:56PM +0100, Russell King - ARM Linux wrote:
On Wed, Apr 01, 2015 at 12:31:16PM -0400, Tejun Heo wrote:
On Wed, Apr 01, 2015 at 12:13:36PM -0400, Tejun Heo wrote:
Signed-off-by : Suman Tripathi
Torvalds 2005-04-16 15:20:36 -0700 39) {
^1da177e (Linus Torvalds 2005-04-16 15:20:36 -0700 40) }
~/linux-next$
Great, that gets me off the hook :)
Acked-by: Russell King rmk+ker...@arm.linux.org.uk
--
FTTC broadband for 0.8mile line: currently at 9.5Mbps down 400kbps up
according to speedtest.net
On Sat, Dec 20, 2014 at 09:35:53AM -0800, James Bottomley wrote:
On Sat, 2014-12-20 at 16:58 +, Russell King - ARM Linux wrote:
On Sat, Dec 20, 2014 at 08:50:45AM -0800, Jeremiah Mahler wrote:
On Sat, Dec 20, 2014 at 05:36:15PM +0100, Rickard Strandqvist wrote:
Remove the function
On Mon, Sep 15, 2014 at 04:44:52PM +0900, Tejun Heo wrote:
On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote:
[suman] : So the posted version is acceptable ? Any others comments on this
patch ?
I'm suggesting setting ctx-cs_mux to NULL on failure. IOW,
if (res) {
much effort into it. As no one else seems to care about it (given
the number of years it's been left alone), removing the linked command
stuff is fine.
Acked-by: Russell King rmk+ker...@arm.linux.org.uk
--
FTTC broadband for 0.8mile line: now at 9.7Mbps down 460kbps up... slowly
improving
On Sat, Mar 22, 2014 at 03:59:11PM -0700, James Bottomley wrote:
On Sat, 2014-03-22 at 22:52 +, Russell King - ARM Linux wrote:
And I'm disagreeing with that statement which implies that it's something
that is an architecture wide property for any particular architecture.
Right now
On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
Perhaps now might be the time to ask which are the remaining
architectures that cannot do SG chaining and then we can fix them and
pull the whole thing out.
Not quite. You're making the assumption that we can be sure that all
On Sat, Mar 22, 2014 at 03:37:40PM -0700, James Bottomley wrote:
On Sat, 2014-03-22 at 22:23 +, Russell King - ARM Linux wrote:
On Sat, Mar 22, 2014 at 02:31:21PM -0700, James Bottomley wrote:
Perhaps now might be the time to ask which are the remaining
architectures that cannot do SG
On Tue, Feb 18, 2014 at 03:49:03PM -0800, Linus Torvalds wrote:
On Mon, Feb 17, 2014 at 3:46 PM, Russell King r...@arm.linux.org.uk wrote:
One fix touches code outside of arch/arm, which is related to sorting
out the DMA masks correctly. There is a long standing issue with the
conversion
On Thu, Feb 13, 2014 at 08:01:12PM +, Russell King - ARM Linux wrote:
On Thu, Feb 13, 2014 at 10:07:01AM -0800, James Bottomley wrote:
On Thu, 2014-02-13 at 17:11 +, Russell King - ARM Linux wrote:
On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote:
This doesn't
On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote:
This doesn't really look like the right fix. You replaced dev-dma_mask
with a calculation on dev_max_pfn(). Since dev-dma_mask is always u64
and dev_max_pfn is supposed to be returning the pfn of the dma_mask, it
should
On Thu, Feb 13, 2014 at 10:07:01AM -0800, James Bottomley wrote:
On Thu, 2014-02-13 at 17:11 +, Russell King - ARM Linux wrote:
On Thu, Feb 13, 2014 at 08:58:10AM -0800, James Bottomley wrote:
This doesn't really look like the right fix. You replaced dev-dma_mask
with a calculation
for
bounce_limit calculations)
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
While poking about with the Cubox-i4 and investigating why my UHS-1
SD card wasn't achieving its full potential, I came across a slight
problem... the SDHCI host sets a mask of 0x, but with the
start
On Thu, Oct 31, 2013 at 09:46:40AM -0200, Mauro Carvalho Chehab wrote:
Hi Russell,
Em Mon, 30 Sep 2013 13:57:47 +0200
Hans Verkuil hverk...@xs4all.nl escreveu:
On 09/19/2013 11:44 PM, Russell King wrote:
Replace the following sequence:
dma_set_mask(dev, mask
On Thu, Sep 26, 2013 at 10:23:08PM +0200, Rafał Miłecki wrote:
2013/9/19 Russell King - ARM Linux li...@arm.linux.org.uk:
This email is only being sent to the mailing lists in question, not to
anyone personally. The list of individuals is far to great to do that.
I'm hoping no mailing
On Mon, Sep 23, 2013 at 03:55:33PM +0530, Vinod Koul wrote:
On Fri, Sep 20, 2013 at 12:15:39AM +0100, Russell King wrote:
register_platform_device_full() can setup the DMA mask provided the
appropriate member is set in struct platform_device_info. So lets
make that be the case
On Mon, Sep 23, 2013 at 02:27:39PM -0400, Alan Stern wrote:
On Thu, 19 Sep 2013, Russell King wrote:
The correct way for a driver to specify the coherent DMA mask is
not to directly access the field in the struct device, but to use
dma_set_coherent_mask(). Only arch and bus code should
On Fri, Sep 20, 2013 at 07:26:27PM +0200, Heiko Stübner wrote:
Am Donnerstag, 19. September 2013, 23:49:01 schrieb Russell King:
The DMA API requires drivers to call the appropriate dma_set_mask()
functions before doing any DMA mapping. Add this required call to
the AMBA PL08x driver
...@ti.com
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/arm/include/asm/dma-mapping.h |8
arch/arm/mm/init.c | 10 --
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/arch/arm/include/asm/dma-mapping.h
b/arch/arm/include/asm
architectures. So make use of
dma_max_pfn() which is expected to return the DMAable maximum pfn
value across architectures.
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/mmc/card/queue.c |3 ++-
1 files changed, 2
architectures. So make use of
dma_max_pfn() which is expected to return the DMAable maximum pfn
value across architectures.
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/scsi/scsi_lib.c |2 +-
1 files changed, 1 insertions
...@ti.com
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
include/linux/dma-mapping.h |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index 27d1421..fd4aee2 100644
--- a/include/linux/dma-mapping.h
assumptions about dma_mask wherever it could
be miss-interpreted.
Signed-off-by: Santosh Shilimkar santosh.shilim...@ti.com
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
block/blk-settings.c |8
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/block/blk
This driver doesn't need to directly access DMA masks if it uses the
platform_device_register_full() API rather than
platform_device_register_simple() - the former function can initialize
the DMA mask appropriately.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/firmware
the DMA mask to a PFN using
the device specific dma_to_pfn() macro. This is the reverse of the
pfn_to_dma() macro which is used to get the DMA address for the device.
This gives us a PFN mask, which we can then check against the PFN
limit of the DMA zone.
Signed-off-by: Russell King rmk+ker
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/musb/am35x.c| 50 ++
drivers/usb/musb/da8xx.c| 49 ++---
drivers/usb/musb/davinci.c | 48 ++--
drivers/usb/musb
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/crypto/ixp4xx_crypto.c | 13 -
1 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 8306185..214357e 100644
--- a/drivers/crypto
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/ata/pata_ixp4xx_cf.c |5 -
drivers/gpu/drm/exynos/exynos_drm_drv.c |6 +-
drivers/gpu/drm/omapdrm/omap_dmm_tiler.c |5 +++--
3 files changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers/ata/pata_ixp4xx_cf.c
AMBA Primecell devices always treat streaming and coherent DMA exactly
the same, so there's no point in having the masks separated.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/amba/bus.c |6 +-
drivers/of/platform.c|3 ---
include/linux/amba/bus.h
The DMA API requires drivers to call the appropriate dma_set_mask()
functions before doing any DMA mapping. Add this required call to
the AMBA PL08x driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/pl330.c |4
1 files changed, 4 insertions(+), 0 deletions
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/emulex/benet/be_main.c | 12 ++--
1
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/sfc/efx.c | 12 +---
1 files changed
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/et131x/et131x.c | 17 ++---
1 files
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/e1000/e1000_main.c |9 ++---
1
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/block/nvme-core.c | 10 --
1 files changed, 4
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/media/dt3155v4l/dt3155v4l.c |5 +
1 files
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/broadcom/bnx2x/bnx2x_main.c |8 ++--
1
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/wireless/b43legacy/dma.c |9 +++--
1 files
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/host/bcma-hcd.c |3 +--
1 files changed, 1
The DMA API requires drivers to call the appropriate dma_set_mask()
functions before doing any DMA mapping. Add this required call to
the AMBA PL08x driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/video/amba-clcd.c |5 +
1 files changed, 5 insertions(+), 0
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/host/ssb-hcd.c |3 +--
1 files changed, 1 insertions
Add a comment to explain why this driver doesn't call any of the DMA
API dma_set_mask() functions.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/host/ohci-sa.c |6 ++
1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/usb/host/ohci-sa
with via dma_set_mask()/
dma_is_supported().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
include/linux/dma-mapping.h | 10 ++
1 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h
index ec951f9..27d1421
dma_coerce_coherent_and_mask()
function.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
sound/arm/pxa2xx-pcm.c |9 +++--
sound/soc/atmel/atmel-pcm.c | 11 ---
sound/soc/blackfin/bf5xx-ac97-pcm.c | 11 ---
sound/soc/blackfin/bf5xx-i2s-pcm.c | 10
Convert this code sequence:
pdev-dev.coherent_dma_mask = DMA_BIT_MASK(64);
pdev-dev.dma_mask = pdev-dev.coherent_dma_mask;
to use dma_coerce_mask_and_coherent() to avoid bypassing the architecture
check on the DMA mask.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
(), avoiding the direct initialization
of this mask.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/dw/platform.c |8 +++-
1 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/dw/platform.c b/drivers/dma/dw/platform.c
index e35d975..453822c 100644
initialization
of this mask.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/media/platform/omap3isp/isp.c |6 +++---
drivers/media/platform/omap3isp/isp.h |3 ---
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/omap3isp/isp.c
b/drivers
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/wireless/b43/dma.c |9 +++--
1 files changed, 3
The code sequence:
dev-dma_mask = dev-coherent_dma_mask;
dev-coherent_dma_mask = dma_mask;
bypasses the architectures check on the DMA mask. It can be replaced
with dma_coerce_mask_and_coherent(), avoiding the direct initialization
of this mask.
Signed-off-by: Russell King rmk
.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/nxp/lpc_eth.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/nxp/lpc_eth.c
b/drivers/net/ethernet/nxp/lpc_eth.c
index a061b93..ba3ca18 100644
--- a/drivers/net
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/octeon/octeon_mgmt.c |5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/octeon/octeon_mgmt.c
b/drivers/net/ethernet/octeon/octeon_mgmt.c
index 622aa75..2006a07 100644
--- a/drivers
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/chipidea/ci_hdrc_imx.c |5 +++--
drivers/usb/dwc3/dwc3-exynos.c |5 +++--
drivers/usb/gadget/lpc32xx_udc.c |4 +++-
drivers/usb/host/ehci-atmel.c |5 +++--
drivers/usb/host/ehci-octeon.c |4 +++-
drivers/usb/host
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/usb/chipidea/ci_hdrc_imx.c |4 +---
drivers/usb/dwc3/dwc3-exynos.c |4 +---
drivers/usb/host/ehci-atmel.c |4 +---
drivers/usb/host/ehci-omap.c |4 +---
drivers/usb/host/ehci-orion.c |4
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/staging/dwc2/platform.c|5 +++--
drivers/staging/imx-drm/imx-drm-core.c |8 ++--
drivers/staging/imx-drm/ipuv3-crtc.c |4 +++-
3 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/dwc2/platform.c b
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/broadcom/b44.c |3 +--
1 files changed, 1
On Fri, Sep 20, 2013 at 08:11:25AM -0500, Felipe Balbi wrote:
Hi,
On Fri, Sep 20, 2013 at 12:14:38AM +0100, Russell King wrote:
Use platform_device_register_full() for those drivers which can, to
avoid messing directly with DMA masks. This can only be done when
the driver does not need
On Fri, Sep 20, 2013 at 07:16:52AM -0500, Tejun Heo wrote:
On Fri, Sep 20, 2013 at 12:11:38AM +0100, Russell King wrote:
The correct way for a driver to specify the coherent DMA mask is
not to directly access the field in the struct device, but to use
dma_set_coherent_mask(). Only arch
On Fri, Sep 20, 2013 at 02:21:37AM +0100, Ben Hutchings wrote:
On Thu, 2013-09-19 at 22:25 +0100, Russell King wrote:
[...]
-dma_set_coherent_mask() will always be able to set the same or a
-smaller mask as dma_set_mask(). However for the rare case that a
+The coherent coherent mask
-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/crypto/ixp4xx_crypto.c | 37 +
1 files changed, 17 insertions(+), 20 deletions(-)
diff --git a/drivers/crypto/ixp4xx_crypto.c b/drivers/crypto/ixp4xx_crypto.c
index 21180d6..8306185 100644
--- a/drivers
The DMA API requires drivers to call the appropriate dma_set_mask()
functions before doing any DMA mapping. Add this required call to
the AMBA PL08x driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma/amba-pl08x.c |5 +
1 files changed, 5 insertions(+), 0
Replace the following sequence:
dma_set_mask(dev, mask);
dma_set_coherent_mask(dev, mask);
with a call to the new helper dma_set_mask_and_coherent().
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
arch/powerpc/kernel/vio.c |3 +--
1 files changed, 1 insertions
The code sequence:
dev-coherent_dma_mask = DMA_BIT_MASK(24);
dev-dma_mask = dev-coherent_dma_mask;
bypasses the architectures check on the DMA mask. It can be replaced
with dma_coerce_mask_and_coherent(), avoiding the direct initialization
of this mask.
Signed-off-by: Russell
This started out as a request to look at the DMA mask situation, and how
to solve the issues which we have on ARM - notably how the DMA mask
should be setup.
However, I started off reviewing how the dma_mask and coherent_dma_mask
was being used, and what I found was rather messy, and in some
it to set the
coherent DMA mask only if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/igb/igb_main.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers
Provide a helper to set both the DMA and coherent DMA masks to the
same value - this avoids duplicated code in a number of drivers,
sometimes with buggy error handling, and also allows us identify
which drivers do things differently.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
it to set the
coherent DMA mask only if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/e1000e/netdev.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git
it to set the
coherent DMA mask only if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/igbvf/netdev.c | 18 ++
1 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/drivers
mask if we failed to
set a 32-bit DMA mask, and only if both fail do we fail the driver.
Adjust this so that if either setting fails, we fail the driver - and
thereby end up properly setting both the DMA mask and the coherent
DMA mask in the fallback case.
Signed-off-by: Russell King rmk+ker
if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/ixgb/ixgb_main.c | 16 +---
1 files changed, 5 insertions(+), 11 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgb/ixgb_main.c
b
mask only if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe
mask only if dma_set_mask() succeeded, and to error out
if either fails.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 15 +--
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel
the platform_device_register_full()
avoids some of this explicit initialization.
Convert the driver to use platform_device_register_full(), and as it
makes use of coherent DMA, also call dma_set_coherent_mask() to ensure
that the architecture gets to check the mask.
Signed-off-by: Russell King rmk+ker
register_platform_device_full() can setup the DMA mask provided the
appropriate member is set in struct platform_device_info. So lets
make that be the case. This avoids a direct reference to the DMA
masks by this driver.
Signed-off-by: Russell King rmk+ker...@arm.linux.org.uk
---
drivers/dma
On Wed, Aug 21, 2013 at 12:03:50AM +0900, Akinobu Mita wrote:
The discussion in that thread is useful. Also, I found that Russell King
proposed replacing the boilerplate by using dma_coerce_mask_and_coherent()
in his patch set Preview of DMA mask changes.
https://patchwork.kernel.org/patch
On Thu, Aug 01, 2013 at 10:34:20PM +0100, Russell King - ARM Linux wrote:
So, this patch set is a preview of the DMA mask changes which I currently
have in my tree.
Looking at the comments which this patch set has received, I see very
little in the way of feedback. So I think it's time to move
So, this patch set is a preview of the DMA mask changes which I currently
have in my tree.
This started out as a request to look at the DMA mask situation, and how
to solve the issues which we have on ARM. One of those issues is how to
deal with the DT side of things, which I haven't yet
On Fri, Jul 26, 2013 at 12:28:26PM -0400, Santosh Shilimkar wrote:
On Friday 26 July 2013 11:10 AM, Russell King - ARM Linux wrote:
On Fri, Jul 12, 2013 at 05:48:09PM -0400, Santosh Shilimkar wrote:
The series is an attempt to move ARM port to NO_BOOTMEM. As discussed
on list NO_BOOTMEM
On Mon, Jul 29, 2013 at 09:26:44AM -0400, Santosh Shilimkar wrote:
On Monday 29 July 2013 07:15 AM, Russell King - ARM Linux wrote:
Would you mind putting them all in the patch system, I can add the acks
should anyone supply them later, and I'll repost them along with my set
of dma-mask
On Fri, Jul 12, 2013 at 05:48:09PM -0400, Santosh Shilimkar wrote:
The series is an attempt to move ARM port to NO_BOOTMEM. As discussed
on list NO_BOOTMEM move needed updates to max*pfn meaning to be maximum
PFNs but that breaks the dma_mask for few block layer drivers since
ARM start of
calculation is based on max_*pfn which
don't have uniform meaning across architectures. So make use of
dma_max_pfn() which is expected to return the DMAable maximum pfn
value across architectures.
Cc: Russell King li...@arm.linux.org.uk
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Santosh
On Sat, Jul 13, 2013 at 03:42:55AM +0400, Sergei Shtylyov wrote:
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 86d5220..e8275fa 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -1668,7 +1668,7 @@ u64 scsi_calculate_bounce_limit(struct
Scsi_Host
On Thu, Jan 17, 2013 at 09:11:20AM +, James Bottomley wrote:
On Wed, 2013-01-16 at 15:18 -0800, Tejun Heo wrote:
On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote:
diff --git a/arch/arm/mm/dma-mapping.c b/arch/arm/mm/dma-mapping.c
index 6b2fb87..ab88c5b 100644
---
On Thu, Jan 17, 2013 at 10:37:42AM +, Russell King - ARM Linux wrote:
On Thu, Jan 17, 2013 at 09:11:20AM +, James Bottomley wrote:
I'd actually prefer page = pfn_to_page(page_to_pfn(page) + 1); because
it makes the code look like the hack it is. The preferred form for all
iterators
On Thu, Jan 17, 2013 at 11:01:47AM +, James Bottomley wrote:
On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote:
Also, couldn't the addition of the scatterlist offset to the page also
be buggy too?
No, fortunately, offset must be within the first page from the point
On Thu, Jan 17, 2013 at 11:19:21AM +, James Bottomley wrote:
On Thu, 2013-01-17 at 11:04 +, Russell King - ARM Linux wrote:
On Thu, Jan 17, 2013 at 11:01:47AM +, James Bottomley wrote:
On Thu, 2013-01-17 at 10:47 +, Russell King - ARM Linux wrote:
Also, couldn't
On Wed, Jan 16, 2013 at 10:32:35AM +, James Bottomley wrote:
On Wed, 2013-01-16 at 12:07 +0530, Subhash Jadavani wrote:
Now consider this call stack from MMC block driver (this is on the ARmv7
based board):
[ 98.918174] [c001b50c] (v7_dma_inv_range+0x30/0x48) from
| 2 +-
drivers/scsi/arm/oak.c| 2 +-
drivers/scsi/arm/powertec.c | 2 +-
For these drivers,
Acked-by: Russell King rmk+ker...@arm.linux.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
| 2 +-
drivers/scsi/arm/oak.c| 2 +-
drivers/scsi/arm/powertec.c | 2 +-
For these,
Acked-by: Russell King rmk+ker...@arm.linux.org.uk
--
To unsubscribe from this list: send the line unsubscribe linux-scsi in
the body of a message to majord
On Sat, Sep 15, 2012 at 10:30:43AM +, Arnd Bergmann wrote:
On Saturday 15 September 2012, Russell King - ARM Linux wrote:
On Sat, Sep 15, 2012 at 08:00:35AM +, Arnd Bergmann wrote:
On Friday 14 September 2012, Russell King - ARM Linux wrote:
On Fri, Sep 14, 2012 at 11:34:50PM
On Sat, Sep 15, 2012 at 08:00:35AM +, Arnd Bergmann wrote:
On Friday 14 September 2012, Russell King - ARM Linux wrote:
On Fri, Sep 14, 2012 at 11:34:50PM +0200, Arnd Bergmann wrote:
ARM is moving to stricter checks on readl/write functions,
so we need to use the correct types
On Fri, Sep 14, 2012 at 11:34:50PM +0200, Arnd Bergmann wrote:
ARM is moving to stricter checks on readl/write functions,
so we need to use the correct types everywhere.
There's nothing wrong with const iomem pointers. If you think
otherwise, patch x86 not to use const in its accessor
1 - 100 of 122 matches
Mail list logo
