[PATCH] MAINTAINERS: ufs - remove self

2014-10-25 Thread Santosh Y
I have moved, I do not have the hardware access anymore. Signed-off-by: Santosh Y santos...@gmail.com diff --git a/MAINTAINERS b/MAINTAINERS index 851761b..d8b5084 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8214,7 +8214,6 @@ F:include/uapi/linux/cdrom.h UNIVERSAL FLASH STORAGE

Re: [PATCH v2] ufs: fix DMA mask setting

2014-07-13 Thread Santosh Y
sthu...@codeaurora.org Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org --- * Change from v1 - use dma_set_mask_and_coherent() suggested by Santosh Y drivers/scsi/ufs/ufshcd-pci.c

Re: [PATCH resend] ufs: fix DMA mask setting

2014-07-12 Thread Santosh Y
sthu...@codeaurora.org Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org --- This patch previously required a additional change which initializes dev-dma_mask for device-tree probed

Re: [PATCH V1 1/4] scsi: ufs: query descriptor API

2014-06-03 Thread Santosh Y
: + return err; +} + +/** * ufshcd_memory_alloc - allocate memory for host memory space data structures * @hba: per adapter instance * -- 1.8.5.2 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi

Re: [PATCH V1 2/4] scsi: ufs: device query status and size check

2014-06-03 Thread Santosh Y
*/ -- 1.8.5.2 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V1 3/4] scsi: ufs: Logical Unit (LU) command queue depth

2014-06-03 Thread Santosh Y
* @data: data pointer to pass to this function * @cookie: cookie data -- 1.8.5.2 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http

Re: [PATCH V1 4/4] scsi: ufs: Fix queue depth handling for best effort cases

2014-06-03 Thread Santosh Y
, -- 1.8.5.2 -- Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] scsi: ufs: replace the deprecated flush_work_sync

2013-09-03 Thread Santosh Y
= UFSHCD_STATE_RESET; -- 1.7.0.4 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 0/6] scsi: ufs: ufshcd updates and fixes

2013-08-31 Thread Santosh Y
Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Seungwon Jeon (6): scsi: ufs: find out sense data over scsi status values scsi: ufs: fix the setting interrupt aggregation counter scsi: ufs: add dme configuration primitives scsi: ufs: add unipro attribute

[PATCH 2/6] scsi: ufs: fix the setting interrupt aggregation counter

2013-08-31 Thread Santosh Y
should be adjusted with possible value. For that, existing 'ufshcd_config_int_aggr' is split into two part [reset, configure]. Signed-off-by: Seungwon Jeon tgih@samsung.com Reviewed-by: Subhash Jadavani subha...@codeaurora.org Tested-by: Yaniv Gardi yga...@codeaurora.org Signed-off-by: Santosh Y

[PATCH 4/6] scsi: ufs: add unipro attribute IDs

2013-08-31 Thread Santosh Y
...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/unipro.h b/drivers/scsi/ufs/unipro.h new file mode 100644 index 000..3a710eb --- /dev/null +++ b/drivers/scsi/ufs/unipro.h @@ -0,0 +1,130 @@ +/* + * drivers/scsi/ufs/unipro.h + * + * Copyright (C) 2013

[PATCH 1/6] scsi: ufs: find out sense data over scsi status values

2013-08-31 Thread Santosh Y
that UPIU has Sense Data in the Data Segment area. Signed-off-by: Seungwon Jeon tgih@samsung.com Reviewed-by: Subhash Jadavani subha...@codeaurora.org Tested-by: Yaniv Gardi yga...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h

[PATCH 3/6] scsi: ufs: add dme configuration primitives

2013-08-31 Thread Santosh Y
Jadavani subha...@codeaurora.org Tested-by: Yaniv Gardi yga...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 86d7286..03ff4da 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -285,6

[PATCH 5/6] scsi: ufs: add operation for the uic power mode change

2013-08-31 Thread Santosh Y
...@codeaurora.org Tested-by: Yaniv Gardi yga...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 03ff4da..4c6d891 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -36,9 +36,11 @@ #include linux

[PATCH 6/6] scsi: ufs: configure the attribute for power mode

2013-08-31 Thread Santosh Y
Jadavani subha...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 4c6d891..d7a373f 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c @@ -1598,6 +1598,70 @@ out

Re: [PATCH V2 1/3] scsi: ufs: Allow vendor specific initialization

2013-08-29 Thread Santosh Y
+static int ufshcd_variant_hba_init(struct ufs_hba *hba) +{ + int err = 0; + + if (!hba-vops) + goto out; + + if (hba-vops-init) { + err = hba-vops-init(hba); + if (err) + goto out; + } + +

Re: [PATCH V2 2/3] scsi: ufs: Add regulator enable support

2013-08-29 Thread Santosh Y
On Tue, Aug 27, 2013 at 9:48 AM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: UFS devices are powered by at most three external power supplies - - VCC - The flash memory core power supply, 2.7V to 3.6V or 1.70V to 1.95V - VCCQ - The controller and I/O power supply, 1.1V to 1.3V - VCCQ2 -

Re: [PATCH -next] ufs: fix source address of the read descriptor

2013-08-29 Thread Santosh Y
to the unnecessary address-of operator. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Dolev Raviv dra...@codeaurora.org Cc: Sujit Reddy Thumma sthu...@codeaurora.org Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com Cc: James Bottomley jbottom...@parallels.com

Re: [PATCH 14/29] drivers/scsi/ufs/ufshcd-pltfrm.c: simplify use of devm_ioremap_resource

2013-08-14 Thread Santosh Y
On Wed, Aug 14, 2013 at 2:41 PM, Julia Lawall julia.law...@lip6.fr wrote: From: Julia Lawall julia.law...@lip6.fr Remove unneeded error handling on the result of a call to platform_get_resource when the value is passed to devm_ioremap_resource. A debugging statement in the error-handling

[PATCH 0/4] scsi: ufs: TM, fatal-error handling and other fixes

2013-08-14 Thread Santosh Y
Hi James, Please merge the following patches to 'misc' branch. The patches depend on http://thread.gmane.org/gmane.linux.scsi/83565 patch series. Thanks, Santosh Sujit Reddy Thumma (4): scsi: ufs: Fix broken task management command implementation scsi: ufs: Fix hardware race conditions

[PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-08-14 Thread Santosh Y
completion interrupt with TASK_UNINTERRUPTIBLE set. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Reviewed-by: Yaniv Gardi yga...@codeaurora.org Tested-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b

[PATCH 3/4] scsi: ufs: Fix device and host reset methods

2013-08-14 Thread Santosh Y
the error handling in such scenario by resetting the device and host and re-initializing them in proper manner. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Reviewed-by: Yaniv Gardi yga...@codeaurora.org Tested-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Santosh Y santos

Re: [PATCH 1/7] scsi: ufs: amend the ocs handling with fatal error

2013-07-29 Thread Santosh Y
On Fri, Jul 26, 2013 at 7:15 PM, Seungwon Jeon tgih@samsung.com wrote: Fatal error in OCS(overall command status) field indicates error conditions which is not covered by UFSHCI. It means that host cannot define the result of command status and therefore host may need to check transfer

Re: [PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-29 Thread Santosh Y
On Sun, Jul 28, 2013 at 10:40 PM, Santosh Y santos...@gmail.com wrote: Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among

[PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-29 Thread Santosh Y
Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among devices ufs: don't stop controller before scsi_remove_host() Dolev Raviv

[PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-07-29 Thread Santosh Y
...@codeaurora.org Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 139bc06..51b5e3f 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -36,10 +36,13 @@ #ifndef _UFS_H

[PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-07-29 Thread Santosh Y
specification for device initialization completion. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 51b5e3f..50d32f1 100644

[PATCH 3/9] scsi: ufs: Add support for host assisted background operations

2013-07-29 Thread Santosh Y
-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 50d32f1..bce09a6 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -107,6 +107,28 @@ enum { /* Flag idn for Query Requests*/ enum flag_idn { QUERY_FLAG_IDN_FDEVICEINIT

[PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver

2013-07-29 Thread Santosh Y
...@fixstars.com Cc: Seungwon Jeon tgih@samsung.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd

[PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

2013-07-29 Thread Santosh Y
...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c index 48be39a..57ea9dd 100644 --- a/drivers/scsi/ufs/ufshcd-pci.c +++ b/drivers/scsi/ufs/ufshcd-pci.c @@ -35,6 +35,7 @@ #include ufshcd.h #include linux/pci.h +#include

[PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices

2013-07-29 Thread Santosh Y
are sharing the IRQ. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs

[PATCH 7/9] ufs: don't stop controller before scsi_remove_host()

2013-07-29 Thread Santosh Y
...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 1f2caa0..b36ca9a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c

[PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe()

2013-07-29 Thread Santosh Y
From: Wei Yongjun yongjun_...@trendmicro.com.cn There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers

[PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource

2013-07-29 Thread Santosh Y
From: Wolfram Sang w...@the-dreams.de devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi

Re: [PATCH v2 06/10] scsi: ufs: use devres functions for ufshcd

2013-07-29 Thread Santosh Y
On Thu, Jun 27, 2013 at 10:01 AM, Seungwon Jeon tgih@samsung.com wrote: This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos

Re: [PATCH 2/7] scsi: ufs: find out sense data over scsi status values

2013-07-29 Thread Santosh Y
On Fri, Jul 26, 2013 at 7:16 PM, Seungwon Jeon tgih@samsung.com wrote: Except for 'GOOD' and 'CHECK CONDITION', other status value in Response UPIU may or may contain sense data. If a non-zero value is in the Data Segment Length field, it means that UPIU has Sense Data in the Data Segment

[PATCH 2/9] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-07-28 Thread Santosh Y
specification for device initialization completion. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 51b5e3f..50d32f1 100644

[PATCH 1/9] scsi: ufs: Add support for sending NOP OUT UPIU

2013-07-28 Thread Santosh Y
...@codeaurora.org Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 139bc06..51b5e3f 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -36,10 +36,13 @@ #ifndef _UFS_H

[PATCH 5/9] ufshcd-pci: release ioremapped region during removing driver

2013-07-28 Thread Santosh Y
...@fixstars.com Cc: Seungwon Jeon tgih@samsung.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd

[PATCH 0/9] scsi:ufs: query, bkops support and other fixes

2013-07-28 Thread Santosh Y
Hi James, Please apply the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (3): ufshcd-pci: release ioremapped region during removing driver ufs: don't disable_irq() if the IRQ can be shared among devices ufs: don't stop controller before scsi_remove_host() Dolev Raviv

[PATCH 3/9] scsi: ufs: Add support for host assisted background operations

2013-07-28 Thread Santosh Y
-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 50d32f1..bce09a6 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -107,6 +107,28 @@ enum { /* Flag idn for Query Requests*/ enum flag_idn { QUERY_FLAG_IDN_FDEVICEINIT

[PATCH 4/9] scsi: ufs: Add runtime PM support for UFS host controller driver

2013-07-28 Thread Santosh Y
...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs/ufshcd-pci.c index 48be39a..57ea9dd 100644 --- a/drivers/scsi/ufs/ufshcd-pci.c +++ b/drivers/scsi/ufs/ufshcd-pci.c @@ -35,6 +35,7 @@ #include ufshcd.h #include linux/pci.h +#include

[PATCH 6/9] ufs: don't disable_irq() if the IRQ can be shared among devices

2013-07-28 Thread Santosh Y
are sharing the IRQ. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi/ufs

[PATCH 8/9] ufshcd-pltfrm: remove redundant dev_err call in ufshcd_pltfrm_probe()

2013-07-28 Thread Santosh Y
From: Wei Yongjun yongjun_...@trendmicro.com.cn There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers

[PATCH 9/9] drivers/scsi/ufs: don't check resource with devm_ioremap_resource

2013-07-28 Thread Santosh Y
From: Wolfram Sang w...@the-dreams.de devm_ioremap_resource does sanity checks on the given resource. No need to duplicate this in the driver. Signed-off-by: Wolfram Sang w...@the-dreams.de Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi

[PATCH 7/9] ufs: don't stop controller before scsi_remove_host()

2013-07-28 Thread Santosh Y
...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 1f2caa0..b36ca9a 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c

Re: [RFC/PATCH 4/4] block: Add URGENT request notification support to CFQ scheduler

2013-07-11 Thread Santosh Y
On Thu, Jul 11, 2013 at 6:31 PM, Tanya Brokhman tlin...@codeaurora.org wrote: When the scheduler reports to the block layer that there is an urgent request pending, the device driver may decide to stop the transmission of the current request in order to handle the urgent one. This is done in

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-03 Thread Santosh Y
On Wed, Jul 3, 2013 at 9:22 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 7/2/2013 9:21 PM, Santosh Y wrote: On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags

Re: [PATCH V2 4/4] scsi: ufs: Improve UFS fatal error handling

2013-07-03 Thread Santosh Y
+ +/** + * ufshcd_fatal_err_handler - handle fatal errors + * @work: pointer to work structure */ static void ufshcd_fatal_err_handler(struct work_struct *work) { struct ufs_hba *hba; + unsigned long flags; + u32 err_xfer = 0; + u32 err_tm = 0; + int

Re: [PATCH 1/4] scsi: ufs: Fix broken task management command implementation

2013-07-02 Thread Santosh Y
On Fri, Jun 28, 2013 at 5:02 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/27/2013 4:49 PM, Santosh Y wrote: + spin_lock_irqsave(host-host_lock, flags); task_req_descp = hba-utmrdl_base_addr; task_req_descp += free_slot; @@ -2353,38 +2387,39

Re: [PATCH V2 3/4] scsi: ufs: Fix device and host reset methods

2013-07-02 Thread Santosh Y
+ +/** + * ufshcd_eh_device_reset_handler - device reset handler registered to + *scsi layer. + * @cmd - SCSI command pointer + * + * Returns SUCCESS/FAILED + */ +static int ufshcd_eh_device_reset_handler(struct scsi_cmnd *cmd) +{ + struct

[PATCH 05/10] scsi: ufs: Fix the response UPIU length setting

2013-06-26 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez me...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs

[PATCH 02/10] scsi: ufs: amend interrupt configuration

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y

[PATCH 04/10] scsi: ufs: rework link start-up process

2013-06-26 Thread Santosh Y
-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 2e02483..48a7645 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c

[PATCH 01/10] scsi: ufs: wrap the i/o access operations

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 00/10] scsi: ufs: link start-up rework and other fixes

2013-06-26 Thread Santosh Y
Hi James, Please merge the following patches to 'misc' branch. Thanks, Santosh Akinobu Mita (4): ufshcd-pltfrm: add missing empty slot in ufs_of_match[] ufs: fix register address in UIC error interrupt handling ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call ufs: fix DMA

[PATCH 07/10] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]

2013-06-26 Thread Santosh Y
@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 0e48827..6829a16 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -157,6 +157,7 @@ static int ufshcd_pltfrm_remove(struct

[PATCH 03/10] scsi: ufs: remove version check before IS reg clear

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos

[PATCH 06/10] scsi: ufs: use devres functions for ufshcd

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs

[PATCH 08/10] ufs: fix register address in UIC error interrupt handling

2013-06-26 Thread Santosh Y
REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER, it should be REG_UIC_ERROR_CODE_DATA_LINK_LAYER. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git

[PATCH 09/10] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call

2013-06-26 Thread Santosh Y
Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 6829a16..c42db40 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -122,12 +122,6 @@ static int ufshcd_pltfrm_probe(struct

[PATCH 10/10] ufs: fix DMA mask setting

2013-06-26 Thread Santosh Y
a valid dma_mask pointer. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pci.c b/drivers/scsi

[PATCH 01/10] scsi: ufs: wrap the i/o access operations

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 04/10] scsi: ufs: rework link start-up process

2013-06-26 Thread Santosh Y
-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 2e02483..48a7645 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c

[PATCH 06/10] scsi: ufs: use devres functions for ufshcd

2013-06-26 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com This patch replaces normal calls for resource allocation with devm_*() derivative functions. It makes resource freeing simpler. Signed-off-by: Seungwon Jeon tgih@samsung.com Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs

[PATCH 09/10] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call

2013-06-26 Thread Santosh Y
Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd-pltfrm.c b/drivers/scsi/ufs/ufshcd-pltfrm.c index 6829a16..c42db40 100644 --- a/drivers/scsi/ufs/ufshcd-pltfrm.c +++ b/drivers/scsi/ufs/ufshcd-pltfrm.c @@ -122,12 +122,6 @@ static int ufshcd_pltfrm_probe(struct

Re: [PATCH 1/2] scsi: ufs: Add support for host assisted background operations

2013-06-26 Thread Santosh Y
On Thu, Jun 13, 2013 at 7:50 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: Background operations in the UFS device can be disabled by the host to reduce the response latency of transfer requests. Add support for enabling/disabling the background operations during runtime suspend/resume

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-14 Thread Santosh Y
On Fri, Jun 14, 2013 at 1:10 PM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote: static struct scsi_host_template ufshcd_driver_template = { @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct ufs_hba **hba_handle, /*

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-14 Thread Santosh Y
On Thu, Jun 13, 2013 at 10:06 AM, Sujit Reddy Thumma sthu...@codeaurora.org wrote: On 6/12/2013 11:04 AM, Santosh Y wrote: /** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor

Re: [PATCH 1/2] [SCSI] ufshcd-pltfrm: remove unnecessary dma_set_coherent_mask() call

2013-06-12 Thread Santosh Y
On Sun, Jun 9, 2013 at 4:49 PM, Akinobu Mita m...@fixstars.com wrote: Changing the device coherent dma mask to the value that currently set has no effect. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com Cc: James

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-11 Thread Santosh Y
+/* + * ufshcd_wait_for_register - wait for register value to change + * @hba - per-adapter interface + * @reg - mmio register offset + * @mask - mask to apply to read register value + * @val - wait condition + * @interval_us - polling interval in microsecs + * @timeout_ms - timeout in

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-11 Thread Santosh Y
/** + * ufshcd_query_request() - API for issuing query request to the device. + * @hba: ufs driver context + * @query: params for query request + * @descriptor: buffer for sending/receiving descriptor + * @retries: number of times to try executing the command + * + * All necessary

Re: [PATCH 0/8] scsi: ufs: query support and other fixes

2013-06-11 Thread Santosh Y
On Sun, May 19, 2013 at 1:51 PM, Santosh Y santos...@gmail.com wrote: Hi James, Please merge the following patches to 'misc' branch. Thanks, Santosh Dolev Raviv (3): scsi: ufs: add support for query requests scsi: ufs: Add support for sending NOP OUT UPIU scsi: ufs: Set

Re: [PATCH] ufshcd-pltfrm: add missing empty slot in ufs_of_match[]

2013-05-27 Thread Santosh Y
On Sun, May 26, 2013 at 4:54 PM, Akinobu Mita m...@fixstars.com wrote: of_match_table member in struct device_driver must be terminated by empty slot as a sentinel. Signed-off-by: Akinobu Mita m...@fixstars.com Cc: Vinayak Holikatti vinholika...@gmail.com Cc: Santosh Y santos...@gmail.com

Re: [PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Santosh Y
On Fri, May 24, 2013 at 7:52 AM, Libo Chen clbchenlibo.c...@huawei.com wrote: we should check kzalloc, avoid to hit oops Signed-off-by: Libo Chen libo.c...@huawei.com --- drivers/scsi/megaraid.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

[PATCH 0/8] scsi: ufs: query support and other fixes

2013-05-19 Thread Santosh Y
Hi James, Please merge the following patches to 'misc' branch. Thanks, Santosh Dolev Raviv (3): scsi: ufs: add support for query requests scsi: ufs: Add support for sending NOP OUT UPIU scsi: ufs: Set fDeviceInit flag to initiate device initialization Seungwon Jeon (4): scsi: ufs: wrap

[PATCH 1/8] scsi: ufs: add support for query requests

2013-05-19 Thread Santosh Y
-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 139bc06..086ff03 100644 --- a/drivers/scsi/ufs/ufs.h +++ b/drivers/scsi/ufs/ufs.h @@ -36,10 +36,20 @@ #ifndef _UFS_H #define _UFS_H +#include linux/mutex.h +#include linux/types.h + #define

[PATCH 2/8] scsi: ufs: wrap the i/o access operations

2013-05-19 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index

[PATCH 3/8] scsi: ufs: amend interrupt configuration

2013-05-19 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com It makes interrupt setting more flexible especially for disabling. And wrong bit mask is fixed for ver 1.0. [17:16] is added for mask. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y

[PATCH 4/8] scsi: ufs: remove version check before IS reg clear

2013-05-19 Thread Santosh Y
From: Seungwon Jeon tgih@samsung.com There is no need to check the version to clear the interrupt status. And the order is changed prior to actual handling. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos

[PATCH 6/8] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-19 Thread Santosh Y
for sending NOP OUT UPIU to check the device connection path and test whether the UTP layer on the device side is functional during initialization. Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Tested-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com

[PATCH 5/8] scsi: ufs: rework link start-up process

2013-05-19 Thread Santosh Y
-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Tested-by: Maya Erez me...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index b1ac21e..0c570c0 100644 --- a/drivers/scsi/ufs/ufshcd.c +++ b/drivers/scsi/ufs/ufshcd.c

[PATCH 7/8] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-05-19 Thread Santosh Y
specification for device initialization completion. Signed-off-by: Dolev Raviv dra...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 086ff03..742363d 100644

[PATCH 8/8] scsi: ufs: Fix the response UPIU length setting

2013-05-19 Thread Santosh Y
From: Sujit Reddy Thumma sthu...@codeaurora.org The response UPIU length should be in DWORD and not in bytes. Signed-off-by: Maya Erez me...@codeaurora.org Signed-off-by: Sujit Reddy Thumma sthu...@codeaurora.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs

[PATCH 0/3] UFSHCD updates

2013-05-14 Thread Santosh Y
Hi James, Please merge the following patches to scsi tree. Thanks, Santosh Geert Uytterhoeven (1): SCSI_UFSHCD should depend on SCSI_DMA Sachin Kamat (1): ufs: Remove redundant platform_set_drvdata() Sujit Reddy Thumma (1): Documentation: devicetree: Add DT bindings for UFS host

[PATCH 1/3] ufs: Remove redundant platform_set_drvdata()

2013-05-14 Thread Santosh Y
From: Sachin Kamat sachin.ka...@linaro.org Commit 0998d06310 (device-core: Ensure drvdata = NULL when no driver is bound) removes the need to set driver data field to NULL. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi

[PATCH 2/3] SCSI_UFSHCD should depend on SCSI_DMA

2013-05-14 Thread Santosh Y
Cc: linux-scsi@vger.kernel.org Signed-off-by: Santosh Y santos...@gmail.com diff --git a/drivers/scsi/ufs/Kconfig b/drivers/scsi/ufs/Kconfig index 35faf24..f07f901 100644 --- a/drivers/scsi/ufs/Kconfig +++ b/drivers/scsi/ufs/Kconfig @@ -34,7 +34,7 @@ config SCSI_UFSHCD tristate Universal

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-09 Thread Santosh Y
On Thu, May 9, 2013 at 12:09 PM, Seungwon Jeon tgih@samsung.com wrote: On Thursday, May 09, 2013 Santosh wrote: There are two patches remained. These are applied with your final comments. Do you have any idea? [PATCH v4 5/6] scsi: ufs: add dme configuration primitives [PATCH v4 6/6]

Re: [PATCH v4 5/6] scsi: ufs: add dme configuration primitives

2013-05-09 Thread Santosh Y
) |\ +((sel) 0x)) +#define UIC_ARG_ATTR_SET(type) (((type) 0xFF) 16) +#define GET_UIC_ATTR_ID(val) (((val) 16) 0x) + /* UIC Commands */ enum { UIC_CMD_DME_GET = 0x01, -- 1.7.0.4 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh

Re: [PATCH v4 6/6] scsi: ufs: add dme control primitives

2013-05-09 Thread Santosh Y
= 0x03, + PWR_ERROR_CAP = 0x04, + PWR_FATAL_ERROR = 0x05, +}; + /* HCE - Host Controller Enable 34h */ #define CONTROLLER_ENABLE UFS_BIT(0) #define CONTROLLER_DISABLE 0x0 -- 1.7.0.4 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
is the character set or something else... Hi James, Please consider Acked-by: Santosh Y santos...@gmail.com, if you are able to apply the patches. -- ~Santosh -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH v4 2/6] scsi: ufs: amend interrupt configuration

2013-05-08 Thread Santosh Y
, + INTERRUPT_MASK_RW_VER_10= 0x3, /* Interrupt disable mask for UFSHCI v1.1 */ - INTERRUPT_DISABLE_MASK_11 = 0x0, + INTERRUPT_MASK_ALL_VER_11 = 0x31FFF, }; /* -- 1.7.0.4 Acked-by: Santosh Y santos...@gmail.com -- ~Santosh -- To unsubscribe from this list

Re: [PATCH v4 3/6] scsi: ufs: fix interrupt status clears

2013-05-08 Thread Santosh Y
interrupt status register */ - if (hba-ufs_version == UFSHCI_VERSION_10) - ufshcd_writel(hba, intr_status, REG_INTERRUPT_STATUS); retval = IRQ_HANDLED; } spin_unlock(hba-host-host_lock); -- 1.7.0.4 Acked-by: Santosh Y santos

Re: [PATCH v4 4/6] scsi: ufs: rework link start-up process

2013-05-08 Thread Santosh Y
; unsigned long tm_condition; @@ -194,7 +199,6 @@ struct ufs_hba { u32 intr_mask; /* Work Queues */ - struct work_struct uic_workq; struct work_struct feh_workq; /* HBA Errors */ -- 1.7.0.4 Acked-by: Santosh Y santos...@gmail.com

Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Santosh Y
it on Seungwon's V4 patch series and you can add my Acked-by: Santosh Y santos...@gmail.com + %s: NULL pointer hba = %p, query = %p response = %p\n, + __func__, hba, query, response); + return -EINVAL; + } + + /* +* A SCSI

Re: [PATCH V4 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-08 Thread Santosh Y
; @@ -117,6 +119,8 @@ struct ufshcd_lrb { int command_type; int task_tag; unsigned int lun; + bool intr_cmd; + struct completion *completion; }; /** Please re-base it on Seungwon's V4 patch series and you can add my Acked-by: Santosh Y santos

Re: [PATCH v4 1/6] scsi: ufs: wrap the i/o access operations

2013-05-08 Thread Santosh Y
There are two patches remained. These are applied with your final comments. Do you have any idea? [PATCH v4 5/6] scsi: ufs: add dme configuration primitives [PATCH v4 6/6] scsi: ufs: add dme control primitives Since there is no use case for these implementations yet, except for

Re: [PATCH v3 1/6] scsi: ufs: wrap the i/o access operations

2013-05-06 Thread Santosh Y
On Mon, May 6, 2013 at 11:07 AM, Seungwon Jeon tgih@samsung.com wrote: Simplify operations with hiding mmio_base. Signed-off-by: Seungwon Jeon tgih@samsung.com Tested-by: Maya Erez me...@codeaurora.org --- drivers/scsi/ufs/ufshcd.c | 105

Re: [PATCH v3 5/6] scsi: ufs: add dme configuration primitives

2013-05-06 Thread Santosh Y
/** + * ufshcd_dme_xxx_set - UIC command for DME_SET, DME_PEER_SET + * @hba: per adapter instance + * @attr_sel: uic command argument1 + * @attr_set: attribute set type as uic command argument2 + * @mib_val: setting value as uic command argument3 + * @peer: indicate wherter peer or

Re: [PATCH v3 6/6] scsi: ufs: add dme control primitives

2013-05-06 Thread Santosh Y
/** + * ufshcd_dme_power_xxx - UIC command for DME_POWERON, DME_POWEROFF + * @hba: per adapter instance + * @on: indicate wherter power_on or power_off + * + * Returns 0 on success, non-zero value on failure + */ +int ufshcd_dme_power_xxx(struct ufs_hba *hba, u8 on) +{ + struct

  1   2   >