RE: [GIT PULL] SCSI fixes for 4.17-rc2

2018-04-25 Thread Sathya Prakash Veerichetty
James, The mpt3sas should be changed to mptsas. Just responding back to have record on this problem is with old mptsas and not with mpt3sas managed controllers. Thanks Sathya -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of

RE: [PATCH v1] scsi: mpt3sas: Use lo_hi_writeq() helper

2018-02-14 Thread Sathya Prakash Veerichetty
The writeq is defined to ensure both the registers are written without any interleaved access in between the two writels in 32 bit systems. Also we want to retain the order of writing the registers. If needed I can dig out the issue we have faced using writeq in 32 bit systems (happened five/six

RE: [PATCH 13/14] megaraid_sas: NVME passthru command support

2018-01-11 Thread Sathya Prakash Veerichetty
>>So even when used as a RAID member, there will be a device handle at /dev/sdX for each NVMe device the megaraid controller manages? In megaraid controller, you can expose bare NVMe drives and RAID volumes created out of NVMe drives, when the RAID volume is created underlying member drives will

RE: [PATCH 13/14] megaraid_sas: NVME passthru command support

2018-01-10 Thread Sathya Prakash Veerichetty
Bart et al, Broadcom's Tri-mode HBAs and MegaRAID controllers are capable of connecting with SAS, SATA, NVMe drives, SAS expanders and PCIe switches (with NVMe drives connected behind that) and are capable of creating RAID volumes on top of similar family of drives. In the case of RAID

RE: [patch 2/2] scsi: mpt3sas: remove a stray KERN_INFO

2017-11-08 Thread Sathya Prakash Veerichetty
Thanks. Acked-by: Sathya Prakash Veerichetty <sathya.prak...@broadcom.com> -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, November 8, 2017 1:38 AM To: Sathya Prakash; Suganath Prabu Subramani Cc: Chaitra P B; James E.J. Bottomley; Ma

RE: [PATCH 1/2] scsi: mpt3sas: cleanup _scsih_pcie_enumeration_event()

2017-11-08 Thread Sathya Prakash Veerichetty
Thanks. Acked-by: Sathya Prakash Veerichetty <sathya.prak...@broadcom.com> -Original Message- From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Sent: Wednesday, November 8, 2017 1:38 AM To: Sathya Prakash; Suganath Prabu Subramani Cc: Chaitra P B; James E.J. Bottomley; Ma

RE: [bug report] scsi: mpt3sas: Added support for nvme encapsulated request message.

2017-11-07 Thread Sathya Prakash Veerichetty
Dan, The MPI structures are of variable length and can go up to a maximum of 128 bytes (a MPI frame size) and as MPI standard the variable length MPI structures are left out with the last element as a single dword array. Can we ignore the warning? If not we need to modify the MPI structure to

RE: [PATCH] mpt3sas: fix dma_addr_t casts

2017-11-06 Thread Sathya Prakash Veerichetty
Acked-by: Sathya Prakash Veerichetty <sathya.prak...@broadcom.com> -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Monday, November 6, 2017 6:35 AM To: Sathya Prakash; Chaitra P B; Suganath Prabu Subramani; James E.J. Bottomley; Martin K. Petersen Cc: Arnd Be

RE: [PATCH 3.10 141/319] scsi: mpt3sas: Fix secure erase premature termination

2017-02-06 Thread Sathya Prakash Veerichetty
Willy, I think this patch had a problem and later modified to a different blocking mechanism. Could you please pull in the latest change for this? Thanks Sathya -Original Message- From: Willy Tarreau [mailto:w...@1wt.eu] Sent: Sunday, February 05, 2017 12:19 PM To:

RE: [PATCH] mpt3sas: Force request partial completion alignment

2017-01-05 Thread Sathya Prakash Veerichetty
Sreekanth, Let us discuss internally more about this before ACKING this patch. Thanks Sathya -Original Message- From: Sreekanth Reddy [mailto:sreekanth.re...@broadcom.com] Sent: Wednesday, January 04, 2017 4:33 AM To: Guilherme G. Piccoli Cc: linux-scsi@vger.kernel.org;

RE: [PATCH v4 2/4] fusion: remove iopriority handling

2016-10-13 Thread Sathya Prakash Veerichetty
By removing the code below, we put all the commands for all the types of devices (SAS/SATA) as simple-Q (requeue as the device require) and I am not sure whether it is the intention of this change. -Original Message- From: Adam Manzanares [mailto:adam.manzana...@hgst.com] Sent: Thursday,

RE: [PATCH] mpt3sas: Do scsi_remove_host() before deleting SAS PHY objects

2016-05-16 Thread Sathya Prakash Veerichetty
Our understanding is the relationship between the SCSI host and SAS end devices is a parent-child and before ripping of SCSI host we need to rip of all the children. Why the enclosure ends up trying to re-parent the SCSI device from the enclosure to the SAS PHY even after we remove the SAS Phy?.

RE: [PATCH] mptsas: fix checks for dma mapping errors

2016-04-29 Thread Sathya Prakash Veerichetty
Please consider this patch as Ack-by: Sathya Prakash Veerichetty<sathya.prak...@broadcom.com> PS: We don't have test environment to test this patch as this is for an old controller. So ACKing based on code review and similar mpt3sas driver code. -Original Message- From: Ma

RE: [PATCH] mpt3sas: Remove usage of 'struct timeval'

2016-04-15 Thread Sathya Prakash Veerichetty
Hi, Please consider this patch as Ack-by: Sathya Prakash Thanks, Sathya -Original Message- From: mpt-fusionlinux@broadcom.com [mailto:mpt-fusionlinux@broadcom.com] On Behalf Of Martin K. Petersen Sent: Thursday, April 14, 2016 8:48 PM To: Tina

RE: [PATCH] mpt3sas: fix possible NULL dereference

2016-04-15 Thread Sathya Prakash Veerichetty
We need to do some more changes in this. The concept is first pool alloc and then memory alloc in the pool, so the memory has to be freed if the memory is allocated in the pool and irrespective of memory allocated or not the pool has to be destroyed if it is created. We will work internally and

RE: [PATCH] mpt3sas - remove unused fw_event_work delayed_work

2016-04-15 Thread Sathya Prakash Veerichetty
re looking for additional details? Thanks Sathya -Original Message- From: Chaitra Basappa [mailto:chaitra.basa...@broadcom.com] Sent: Friday, April 15, 2016 3:58 AM To: Martin K. Petersen; Joe Lawrence Cc: Sathya Prakash Veerichetty; emi...@redhat.com; linux-scsi@vger.kernel.org; Suga

Off topic: Test suite for LLDs

2014-09-03 Thread Sathya Prakash Veerichetty
Hello folks, I would like to know whether we have any standard test suite for validating a low level driver by executing all the interfaces the low level driver registers with SML? Thanks Sathya -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message to