Re: [RESEND PATCH v1 2/2] trace: events: block: Add tag in block trace events

On Mon, 23 Apr 2018 14:43:13 +0200 Steffen Maier wrote: > > - TP_printk("[%s] %d", __entry->comm, __entry->nr_rq) > > + TP_printk("[%s] %d %s", __entry->comm, __entry->nr_rq, > > + __entry->explicit ? "Sync" : "Async") > > ); > > > > /** > > This

Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events

On Mon, 16 Apr 2018 21:30:54 + Bart Van Assche wrote: > Hello Steve, > > The tool I'm most concerned about is blktrace. I'm not sure though how this > tool receives event data from the block layer core. Yeah, blktrace is "special", it looks like it registers its

Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events

On Mon, 16 Apr 2018 20:49:12 + Bart Van Assche wrote: > Which tools process these strings? Has it been verified whether or not > the tools that process these strings still work fine with this patch > applied? Ideally, tools shouldn't process trace event strings, but

Re: [RESEND PATCH v1 2/2] trace: events: block: Add tag in block trace events

ron.com> I don't see any issue with the tracing part. Acked-by: Steven Rostedt (VMware) <rost...@goodmis.org> Others need to check the content. -- Steve > --- > include/trace/events/block.h | 36 +--- > 1 file changed, 25 insertions(+), 11 deletions(-) >

Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI trace events

On Mon, 16 Apr 2018 14:31:49 + "Bean Huo (beanhuo)" <bean...@micron.com> wrote: > Print the request tag along with other information > while tracing a command. > > Signed-off-by: Bean Huo <bean...@micron.com> > --- I don't see any issue with the tr

Re: [PATCH 2/2] target: remove spin_lock_assert() in __target_(attach|detach)_tg_pt_gp()

On Fri, 23 Mar 2018 17:55:54 + Bart Van Assche wrote: > Comments are not verified at runtime and hence can become outdated if the code > is modified. assert_spin_locked() and lockdep_assert_held() assertions however > are verified at runtime with the proper kernel

Re: [PATCH 1/2] target: drop spin_lock_assert() + irqs_disabled() combo checks

On Fri, 23 Mar 2018 18:17:36 +0100 "bige...@linutronix.de" wrote: > There are a few functions which check for if the lock is held > (spin_lock_assert()) and the interrupts are disabled (irqs_disabled()). > >From looking at the code, each function is static, the caller is

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

On Wed, 21 Mar 2018 11:50:01 -0700 Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(>t_state_lock); > > - WARN_ON_ONCE(!irqs_disabled()); > > + WARN_ON_ONCE_NONRT(!irqs_disabled()); > > I

Re: [patch 3/5] scsi/bnx2i: Prevent recursive cpuhotplug locking

the new percpu > rwsem based mechanism this is not longer allowed. > > Use the _cpuslocked() variants to fix this. > > Reported-by: Steven Rostedt <rost...@goodmis.org> Tested-by: Steven Rostedt (VMware) <rost...@goodmis.org> (makes the lockdep splat go away) --

Re: [PATCH v2 11/12] scsi: ufs: add trace event for ufs commands

On Tue, 13 Dec 2016 11:52:16 -0800 Subhash Jadavani wrote: > From: Lee Susman > > Use the ftrace infrastructure to conditionally trace ufs command events. > New trace event is created, which samples the following ufs command data: > - device

Re: [PATCH v2 02/12] scsi: ufs: add tracing support

On Tue, 13 Dec 2016 11:48:45 -0800 Subhash Jadavani wrote: > This change adds the ftrace support for following: > 1. UFS initialization time > 2. Clock gating states > 3. Clock scaling states > 4. Power management APIs latency > 5. BKOPs enable/disable > > Usage: >

Re: [RESEND/PATCH v8 3/3] scsi: ufs: add trace events and dump prints for debug

On Tue, 14 Apr 2015 14:51:21 +0300 Gilad Broner gbro...@codeaurora.org wrote: +static const char *ufschd_uic_link_state_to_string( + enum uic_link_state state) +{ + switch (state) { + case UIC_LINK_OFF_STATE:return OFF; + case UIC_LINK_ACTIVE_STATE:

Re: [PATCH v7 3/3] scsi: ufs: add trace events and dump prints for debug

++ For the tracing part... Acked-by: Steven Rostedt rost...@goodmis.org -- Steve 5 files changed, 790 insertions(+), 37 deletions(-) create mode 100644 include/trace/events/ufs.h -- To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a message

Re: [PATCH v5 3/3] scsi: ufs: add trace events and dump prints for debug

On Tue, 10 Mar 2015 13:47:15 +0200 Gilad Broner gbro...@codeaurora.org wrote: +++ b/include/trace/events/ufs.h @@ -0,0 +1,227 @@ +/* + * Copyright (c) 2013-2015, The Linux Foundation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it

Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

On Mon, 23 Feb 2015 09:15:15 - Dov Levenglick d...@codeaurora.org wrote: [ Cut's a 1000 lines of unneeded patch ] +#endif /* if !defined(_TRACE_UFS_H) || defined(TRACE_HEADER_MULTI_READ) */ + +/* This part must be outside protection */ +#include trace/define_trace.h -- Qualcomm

Re: [PATCH v3 3/4] scsi: ufs: add trace events and dump prints for debug

On Mon, 23 Feb 2015 10:08:16 +0200 Gilad Broner gbro...@codeaurora.org wrote: @@ -5551,14 +5956,23 @@ EXPORT_SYMBOL(ufshcd_system_suspend); int ufshcd_system_resume(struct ufs_hba *hba) { + int ret = 0; + ktime_t start = ktime_get(); + if (!hba || !hba-is_powered ||

Re: [PATCH v2 3/4] scsi: ufs: add trace events and dump prints for debug

On Tue, 10 Feb 2015 15:58:54 +0200 Gilad Broner gbro...@codeaurora.org wrote: I really hate large patches like this. So much to dig through. -#ifdef CONFIG_DEBUG_FS +#define UIC_ERR_REG_HIST_LENGTH 8 +/** + * struct ufs_uic_err_reg_hist - keeps history of uic errors + * @pos: index to

Re: [PATCH v1 3/4] scsi: ufs: add trace events and dump prints for debug

On Tue, 3 Feb 2015 17:37:19 +0200 Gilad Broner gbro...@codeaurora.org wrote: Add trace events to driver to allow monitoring and profilig of activities such as PM suspend/resume, hibernate enter/exit, clock gating and clock scaling up/down. In addition, add UFS host controller register dumps

Re: [PATCH v2 0/6] scsi: Some seq_file cleanups/optimizations

On Thu, 29 Jan 2015 10:16:16 +0100 Rasmus Villemoes li...@rasmusvillemoes.dk wrote: Steven, you've been doing some cleanup in this area, among other things trying to make all the seq_* functions return void. Could you fill me in on the status of that? Yes, the entire seq_*() operations are

Re: [PATCH 26/38] seq_buf: Move the seq_buf code to lib/

On Mon, 29 Sep 2014 13:58:55 +0200 Hannes Reinecke h...@suse.de wrote: From: Steven Rostedt (Red Hat) rost...@goodmis.org The seq_buf functions are rather useful outside of tracing. Instead of having it be dependent on CONFIG_TRACING, move the code into lib/ and allow other users to have

Re: [RFC][PATCH 1/5 v2] tracing: Add trace_seq_buffer_ptr() helper function

On Thu, 26 Jun 2014 20:14:15 -0700 James Bottomley james.bottom...@hansenpartnership.com wrote: On Thu, 2014-06-26 at 21:06 -0400, Steven Rostedt wrote: As this patch is in my 3.17 queue and it touches the kvm and scsi tracepoint code, I figured I should at least do the courtesy

[188/251] nsp32: use mdelay instead of large udelay constants

. Signed-off-by: Arnd Bergmann a...@arndb.de Acked-by: GOTO Masanori go...@debian.or.jp Cc: YOKOTA Hiroshi yok...@netlab.is.tsukuba.ac.jp Cc: James E.J. Bottomley jbottom...@parallels.com Cc: linux-scsi@vger.kernel.org Signed-off-by: Steven Rostedt rost...@goodmis.org --- drivers/scsi/nsp32.c

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

On Tue, 27 Aug 2013 18:03:25 -0400 Jörn Engel jo...@logfs.org wrote: Here is a fun patch in an early state. Essentially I want to trace scsi commands, which has already been done long ago. The problem I have is that I care about all the scsi commands for one particular device - without

Re: [RFC][PATCH] Add a flight data recorder for scsi commands

On Tue, 27 Aug 2013 18:41:47 -0400 Jörn Engel jo...@logfs.org wrote: On Tue, 27 August 2013 19:54:22 -0400, Steven Rostedt wrote: On Tue, 27 Aug 2013 18:03:25 -0400 Jörn Engel jo...@logfs.org wrote: Here is a fun patch in an early state. Essentially I want to trace scsi commands

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

On Mon, 2013-06-24 at 23:07 -0400, Matthew Wilcox wrote: On Mon, Jun 24, 2013 at 08:11:02PM -0400, Steven Rostedt wrote: What about hooking into the idle_balance code? That happens if we are about to go to idle but before the full schedule switch to the idle task. In __schedule(void

Re: RFC: Allow block drivers to poll for I/O instead of sleeping

On Mon, Jun 24, 2013 at 09:17:18AM +0200, Jens Axboe wrote: On Sun, Jun 23 2013, Linus Torvalds wrote: You could try to do that either *in* the idle thread (which would take the context switch overhead - maybe negating some of the advantages), or alternatively hook into the scheduler