Add the missing unlock before return from function hisi_sas_phy_read32()
in the error handling case.
Fixes: 784b46b7cba0 ("scsi: hisi_sas: Use block layer tag instead for IPTT")
Signed-off-by: Wei Yongjun
---
drivers/scsi/hisi_sas/hisi_sas_v2_hw.c | 4 +++-
1 file changed, 3 insert
Fix a typo in hisi_sas_task_prep().
Fixes: 7eee4b921822 ("scsi: hisi_sas: relocate smp sg map")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hisi_sas
Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/qedf/qedf_main.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/scsi/qedf/qedf_main.c b/d
Fixes the following sparse warning:
drivers/scsi/hisi_sas/hisi_sas_main.c:1691:25: warning:
symbol 'host_attrs' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 2 +-
1 file changed, 1 insertion
Fix to return error code -ENOMEM from the kzalloc() error handling
case instead of 0, as done elsewhere in this function.
Fixes: fabe6a59cc5a ("tcmu: allow max block and global max blocks to be
settable")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/target/ta
From: Wei Yongjun <weiyongj...@huawei.com>
free_irq() expects the same device identity that was passed to
corresponding request_irq(), otherwise the IRQ is not freed.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/mac_esp.c | 2 +-
1 file changed, 1 ins
From: Wei Yongjun <weiyongj...@huawei.com>
Fixes the following sparse warning:
drivers/scsi/sd.c:3087:6: warning:
symbol 'sd_devt_release' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/sd.c | 2 +-
1 file changed, 1 ins
From: Wei Yongjun <weiyongj...@huawei.com>
'conn_info' is malloced in qedi_iscsi_update_conn() and should be
freed before leaving from the error handling cases, otherwise it
will cause memory leak.
Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI
driver framework.&q
From: Wei Yongjun <weiyongj...@huawei.com>
A spin lock is taken here so we should use GFP_ATOMIC.
Fixes: 987132167f4b ("scsi: be2iscsi: Fix for crash in beiscsi_eh_device_reset")
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/be2iscsi/be_main.c | 2
From: Wei Yongjun <weiyongj...@huawei.com>
Fix to return error code -ENOMEM from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/mvsas/mv_sas.c | 4 +++-
1 file changed, 3 insertions(+)
From: Wei Yongjun <weiyongj...@huawei.com>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/ufs/ufshcd.c | 1 +
1 file changed, 1 insertion(+)
From: Wei Yongjun <weiyongj...@huawei.com>
Fix to return error code -ENOMEM from the dma mapping error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 1 +
1 fil
From: Wei Yongjun <weiyongj...@huawei.com>
Fix to return error code -ENOMEM from the workqueue alloc error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/message/fusion/mptfc.c | 4 +++-
1 fil
From: Wei Yongjun <weiyongj...@huawei.com>
Fix typo in parameter description.
Signed-off-by: Wei Yongjun <weiyongj...@huawei.com>
---
drivers/scsi/ibmvscsi/ibmvfc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/s
Fix to return error code -ENOMEM from the workqueue alloc error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <weiyj...@gmail.com>
---
drivers/scsi/ipr.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
Add the missing destroy_workqueue() before return from fcoe_init()
in the fcoe transport register failed error handling case.
Signed-off-by: Wei Yongjun <weiyj...@gmail.com>
---
drivers/scsi/fcoe/fcoe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scs
Use kfree_skb() instead of kfree() to free sk_buff.
Signed-off-by: Wei Yongjun <weiyj...@gmail.com>
---
drivers/scsi/fcoe/fcoe_ctlr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/fcoe/fcoe_ctlr.c b/drivers/scsi/fcoe/fcoe_ctlr.c
index a569c65..dcf3653
Using list_move_tail() instead of list_del() + list_add_tail().
Signed-off-by: Wei Yongjun <weiyj...@gmail.com>
---
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c
b/drivers/scsi/ibmvsc
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The variable 'sg_table' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/target_core_rd.c | 6 --
1 file changed, 6 deletions(-)
diff --git
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fixes the following sparse warning:
drivers/target/target_core_sbc.c:573:1: warning:
symbol 'sbc_check_prot' was not declared. Should it be static?
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/target_core_sbc.c | 2
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Add the missing unlock before return from function bfad_iocmd_cfg_trunk()
in the error handling case.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/bfa/bfad_bsg.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Add the missing destroy_workqueue() before return from
fcoe_init() in the error handling case.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/fcoe/fcoe.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
From: Wei Yongjun yongjun_...@trendmicro.com.cn
A spin lock is taken here so we should use GFP_ATOMIC.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/megaraid/megaraid_mm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid
From: Wei Yongjun yongjun_...@trendmicro.com.cn
In case of error, the function kthread_run() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/hpsa.c | 3
From: Wei Yongjun yongjun_...@trendmicro.com.cn
In case of error, the function scsi_host_lookup() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Remove including linux/version.h that don't need it.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/target_core_xcopy.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/target/target_core_xcopy.c
b/drivers
From: Wei Yongjun yongjun_...@trendmicro.com.cn
There is a error message within devm_ioremap_resource
already, so remove the dev_err call to avoid redundant
error message.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/ufs/ufshcd-pltfrm.c | 1 -
1 file changed, 1
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return a negative error code in the device add error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/sd.c | 3 ++-
1 file changed, 2 insertions(+), 1
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -ENOMEM in the mempool_create_slab_pool() error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/fnic/fnic_main.c | 1 +
1 file changed, 1
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -ENOMEM in the ecardm_iomap() error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/arm/acornscsi.c | 4 +++-
1 file changed, 3 insertions
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return -ENOMEM in the create workqueue error case
instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/scsi_transport_iscsi.c | 4 +++-
1 file changed, 3 insertions
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return a negative error code in the queues alloc error handling
case instead of 0, as done elsewhere in this function.
And also fix to return 0 from qla2x00_alloc_queues() when no error, otherwise
this cause if (!qla2x00_alloc_queues(ha, req
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/mvumi.c | 1 +
1 file changed, 1 insertion(+)
diff
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/message/fusion/mptfc.c | 4 +++-
1 file changed, 3
From: Wei Yongjun yongjun_...@trendmicro.com.cn
'se_tpg-tpg_lun_list' is malloced in core_tpg_register() and should be freed
before leaving from the error handling cases, otherwise it will cause memory
leak.
'se_tpg' is malloced out of this function, and will be freed if we return
error, so
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The variable 'data' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/csiostor/csio_hw.c | 5 -
1 file changed, 5 deletions(-)
diff --git
From: Wei Yongjun yongjun_...@trendmicro.com.cn
This removes an open coded simple_open() function and
replaces file operations references to the function
with simple_open() instead.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/fnic/fnic_debugfs.c | 19
From: Wei Yongjun yongjun_...@trendmicro.com.cn
In case of error, the function target_fabric_configfs_init() returns
ERR_PTR() not NULL pointer. The NULL test in the return value check
should be replaced with IS_ERR().
dpatch engine is used to auto generated this patch.
(https://github.com/weiyj
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/bfa/bfad_im.c | 8 +---
1 file
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/tcm_fc/tfc_io.c | 3 ++-
1 file
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/target_core_pr.c | 10 ++
1
From: Wei Yongjun yongjun_...@trendmicro.com.cn
The dereference should be moved below the NULL test.
spatch with a semantic match is used to found this.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/bnx2fc/bnx2fc_io.c | 4 +++-
1 file
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/bfa/bfa_ioc.c | 3
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/scsi/lpfc/lpfc_sli.c | 3
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Using list_move_tail() instead of list_del() + list_add_tail().
spatch with a semantic match is used to found this problem.
(http://coccinelle.lip6.fr/)
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
v1 - v2: add cleanup for drivers
From: Wei Yongjun yongjun_...@trendmicro.com.cn
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Remove including generated/utsrelease.h that don't need it.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/tcm_fc/tfc_cmd.c | 1 -
drivers/target/tcm_fc/tfc_io.c | 1
From: Wei Yongjun yongjun_...@trendmicro.com.cn
From: Wei Yongjun yongjun_...@trendmicro.com.cn
Remove including generated/utsrelease.h that don't need it.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
---
drivers/target/target_core_fabric_configfs.c | 1 -
drivers/target
47 matches
Mail list logo
