Re: [PATCH][V2] scsi: cxgb3i: remove redundant null check and kfree on skb

On Tue, Mar 14, 2017 at 10:48:43AM +, Colin King wrote: > From: Colin Ian King > > On the error exit path, skb is always null, so the non-null check > and __kfree_skb call are redundant. Remove the redundant code and > just directly return with the appropriate

Re: [PATCH][V2] scsi: cxgb3i: remove redundant null check and kfree on skb

Thanks! regards, dan carpenter

[PATCH][V2] scsi: cxgb3i: remove redundant null check and kfree on skb

From: Colin Ian King On the error exit path, skb is always null, so the non-null check and __kfree_skb call are redundant. Remove the redundant code and just directly return with the appropriate error return code. Detected by CoverityScan, CID#114328 ("Logically Dead