Re: [PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-06 Thread Martin K. Petersen
Bart Van Assche writes: > Now that all scsi_device_get() callers check the return value of this > function, make checking that return value mandatory. Applied to 4.12/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-06 Thread Johannes Thumshirn
On Wed, Apr 05, 2017 at 09:52:50AM -0700, Bart Van Assche wrote: > Now that all scsi_device_get() callers check the return value of this > function, make checking that return value mandatory. > > Signed-off-by: Bart Van Assche > Cc: Hannes Reinecke > Cc: Johannes Thumshirn > --- Looks good, Re

Re: [PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-06 Thread Johannes Thumshirn
On Thu, Apr 06, 2017 at 12:30:43AM +, Bart Van Assche wrote: > On Thu, 2017-04-06 at 08:27 +0800, kbuild test robot wrote: > > All warnings (new ones prefixed by >>): > > > >drivers//scsi/osd/osd_uld.c: In function 'osd_probe': > > > > drivers//scsi/osd/osd_uld.c:467:2: warning: ignoring r

Re: [PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-05 Thread Bart Van Assche
On Thu, 2017-04-06 at 08:27 +0800, kbuild test robot wrote: > All warnings (new ones prefixed by >>): > >drivers//scsi/osd/osd_uld.c: In function 'osd_probe': > > > drivers//scsi/osd/osd_uld.c:467:2: warning: ignoring return value of > > > 'scsi_device_get', declared with attribute warn_unuse

Re: [PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-05 Thread kbuild test robot
Hi Bart, [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.11-rc5 next-20170405] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Make-checking-the-scsi_dev

[PATCH] Make checking the scsi_device_get() return value mandatory

2017-04-05 Thread Bart Van Assche
Now that all scsi_device_get() callers check the return value of this function, make checking that return value mandatory. Signed-off-by: Bart Van Assche Cc: Hannes Reinecke Cc: Johannes Thumshirn --- include/scsi/scsi_device.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git