Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-22 Thread Jeff Garzik
Ke Wei wrote: Added support for Expander. Based on version 0.1 for mvsas. Signed-off-by: Ke Wei [EMAIL PROTECTED] --- diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c old mode 100644 new mode 100755 index 03638b9..3c7a154 --- a/drivers/scsi/mvsas.c +++ b/drivers/scsi/mvsas.c @@ -2,6

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-22 Thread James Bottomley
On Fri, 2008-02-22 at 11:26 -0500, Jeff Garzik wrote: 4) [major] Your email was encoded in base64, which makes it difficult for automated tools to handle, and difficult for some mail clients to view and reply-to. Yes, I echo this, there's also another problem it causes: The email didn't

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-06 Thread Jeff Garzik
Ke Wei wrote: Added support for hotplug and wide port. Signed-off-by: Ke Wei [EMAIL PROTECTED] --- drivers/scsi/mvsas.c | 445 ++ 1 files changed, 339 insertions(+), 106 deletions(-) Technically speaking, everything is looking great so far.

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-05 Thread Ke Wei
Added support for hotplug and wide port. Signed-off-by: Ke Wei [EMAIL PROTECTED] --- drivers/scsi/mvsas.c | 445 ++ 1 files changed, 339 insertions(+), 106 deletions(-) diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c index

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-02-05 Thread Luben Tuikov
--- On Tue, 2/5/08, Ke Wei [EMAIL PROTECTED] wrote: + for_each_phy(port-wide_port_phymap, no, j, mvi-chip-n_phy) { + mvs_write_port_cfg_addr(mvi, no, PHYR_WIDE_PORT); + mvs_write_port_cfg_data(mvi, no , port-wide_port_phymap); + } else { +

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-27 Thread Ke Wei
mvsas : Fixed coding problem Signed-off-by: Ke Wei [EMAIL PROTECTED] --- drivers/scsi/mvsas.c | 61 +++-- 1 files changed, 34 insertions(+), 27 deletions(-) diff --git a/drivers/scsi/mvsas.c b/drivers/scsi/mvsas.c index 321be21..3bf009b 100755 ---

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-27 Thread James Bottomley
On Sun, 2008-01-27 at 23:27 +0800, Ke Wei wrote: I really don't think you should be doing this. That single ring governs all the potential tag slots for everything in this device. If you do a simple head tail allocation, what can happen is that you get a slow tag (attached to a format

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Fri, 2008-01-25 at 09:24 -0800, Grant Grundler wrote: On Jan 25, 2008 8:43 AM, Ke Wei [EMAIL PROTECTED] wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. I know this isn't part of this patch: #define mr32(reg)readl(regs + MVS_##reg)

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Jeff Garzik
James Bottomley wrote: The lack of interrupt enable looks potentially fatal... See my comments on this specific issue, in this thread, for the reason why that function isn't used... Jeff - To unsubscribe from this list: send the line unsubscribe linux-scsi in the body of a

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Sat, 2008-01-26 at 00:43 +0800, Ke Wei wrote: struct mvs_phy { struct mvs_port *port; struct asd_sas_phy sas_phy; + struct sas_identify identify; + __le32 dev_info; + __le64 dev_sas_addr; + __le32

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Grant Grundler
On Jan 25, 2008 8:43 AM, Ke Wei [EMAIL PROTECTED] wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. Sorry, just saw some more issues in +static void mvs_hba_interrupt_enable(struct mvs_info *mvi, int enable) Three comments here: 1) This routine

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Grant Grundler
On Jan 25, 2008 8:43 AM, Ke Wei [EMAIL PROTECTED] wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. I know this isn't part of this patch: #define mr32(reg) readl(regs + MVS_##reg) #define mw32(reg,val) writel((val), regs + MVS_##reg) But

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread James Bottomley
On Sat, 2008-01-26 at 00:43 +0800, Ke Wei wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. Changelog : Merged from Jeff's branch to James's branch. Signed-off-by: Ke Wei [EMAIL PROTECTED] A compile test of this seems to show some problems:

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-25 Thread Jeff Garzik
Grant Grundler wrote: On Jan 25, 2008 8:43 AM, Ke Wei [EMAIL PROTECTED] wrote: The attached is Marvell 6440 SAS/SATA driver. I will try to send email by git-send-email. I know this isn't part of this patch: #define mr32(reg) readl(regs + MVS_##reg) #define mw32(reg,val) writel((val),

Re: [PATCH] Marvell 6440 SAS/SATA driver

2008-01-22 Thread Jeff Garzik
Comments inline, mostly minor stuff cleaning up the source. Major problem though: your mailer converted tabs to spaces, so our automated patch tools won't work on your submission. It usually takes a few attempts to get your email setup working, such that all the automated tools used in the

Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-20 Thread Ke Wei
Hello James: I read your comments. .target_alloc = sas_target_alloc, .slave_configure= sas_slave_configure, .slave_destroy = sas_slave_destroy, .change_queue_depth = sas_change_queue_depth, .change_queue_type =

Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-18 Thread James Bottomley
On Thu, 2008-01-10 at 02:21 -0500, Jeff Garzik wrote: Jeff Garzik wrote: 1) To make it easier for people to review and test the driver, I would suggest posting a diff against 2.6.24-rc7 (or 2.6.23), ignoring my original code. Thus, it would result in a patch Er, that sentence was

Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-18 Thread James Bottomley
On Thu, 2008-01-10 at 14:53 +0800, Ke Wei wrote: The 88SE6440 driver : The driver is based on bare code from Jeff Garzik. And it can work under linux kernel 2.6.23. By far, Can discover and find SAS HDD, but SATA is currently unsupported. Command queue depth can be above 1. Most error

[PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-09 Thread Ke Wei
The 88SE6440 driver : The driver is based on bare code from Jeff Garzik. And it can work under linux kernel 2.6.23. By far, Can discover and find SAS HDD, but SATA is currently unsupported. Command queue depth can be above 1. Most error handling, and some phy handling code is notably missing.

Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-09 Thread Jeff Garzik
Ke Wei wrote: The 88SE6440 driver : The driver is based on bare code from Jeff Garzik. And it can work under linux kernel 2.6.23. By far, Can discover and find SAS HDD, but SATA is currently unsupported. Command queue depth can be above 1. Most error handling, and some phy handling code is

Re: [PATCH] Marvell 6440 SAS/SATA driver (draft)

2008-01-09 Thread Jeff Garzik
Jeff Garzik wrote: 1) To make it easier for people to review and test the driver, I would suggest posting a diff against 2.6.24-rc7 (or 2.6.23), ignoring my original code. Thus, it would result in a patch Er, that sentence was incomplete. Continuing... Thus it would result in a patch that

[PATCH] Marvell 6440 SAS/SATA driver (rough draft)

2007-09-25 Thread Jeff Garzik
Same disclaimer as with broadsas... it's better to go ahead and get this work-in-progress out there for people to comment on. The chip: the 6440 has per-HBA rings for TX (delivery) and RX (completions, events). You build a DMA command descriptor describing the SSP, SMP, STP or SATA command,