Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-23 Thread Tejun Heo
On Mon, Sep 22, 2014 at 06:31:33PM +0530, Suman Tripathi wrote: > This patch fixes the error print invalid resource for the APM X-Gene > SoC AHCI SATA Host Controller driver. This print was due to the fact > that the controller 3 don't have a mux resource. This didn't result > in any errors but the

[PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-22 Thread Suman Tripathi
This patch fixes the error print invalid resource for the APM X-Gene SoC AHCI SATA Host Controller driver. This print was due to the fact that the controller 3 don't have a mux resource. This didn't result in any errors but the print seems like meaningless. Signed-off-by: Loc Ho Signed-off-by: Su

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-15 Thread Russell King - ARM Linux
On Mon, Sep 15, 2014 at 04:44:52PM +0900, Tejun Heo wrote: > On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote: > > [suman] : So the posted version is acceptable ? Any others comments on this > > patch ? > > I'm suggesting setting ctx->cs_mux to NULL on failure. IOW, > > if (r

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-15 Thread Tejun Heo
On Mon, Sep 15, 2014 at 01:10:01PM +0530, Suman Tripathi wrote: > [suman] : So the posted version is acceptable ? Any others comments on this > patch ? I'm suggesting setting ctx->cs_mux to NULL on failure. IOW, if (res) { ctx->csr_mux = devm_ioremap_resources();

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-14 Thread Tejun Heo
Hello, On Sun, Sep 14, 2014 at 11:36:51AM +0530, Suman Tripathi wrote: > We can maintain same piece (IS_ERR(ctx->csr_mux)), then we can do the > below instead of NULL ?? > > ctx->csr_mux = res ? devm_ioremap_resource(dev, res) : ERR_PTR(-EINVAL); Setting it to NULL on failure would probably mak

Re: [PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-12 Thread Tejun Heo
On Fri, Sep 12, 2014 at 01:24:08PM +0530, Suman Tripathi wrote: > This patch fixes the error print invalid resource for the APM X-Gene > SoC AHCI SATA Host Controller driver. This print was due to the fact > that the controller 3 don't have a mux resource. This didn't result > in any errors but the

[PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-12 Thread Suman Tripathi
Signed-off-by: Loc Ho Signed-off-by: Suman Tripathi --- Suman Tripathi (1): ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver. drivers/ata/ahci_xgene.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 1.8.2.1 -- To unsubscr

[PATCH] ahci_xgene: Fix the error print invalid resource for APM X-Gene SoC AHCI SATA Host Controller driver.

2014-09-12 Thread Suman Tripathi
This patch fixes the error print invalid resource for the APM X-Gene SoC AHCI SATA Host Controller driver. This print was due to the fact that the controller 3 don't have a mux resource. This didn't result in any errors but the print seems like meaningless. Signed-off-by: Loc Ho Signed-off-by: Su