Re: [RESEND][PATCH] lpfc: fix model description

2015-07-10 Thread James Smart
As mentioned previously, it's a nit, and not too meaningful, but fine. If not merged prior, we'll repost as part of an upcoming commit that cleans up sparse warnings. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 7/6/2015 5:22 PM, Sebastian Herbszt wrote: Remove

[RESEND][PATCH] lpfc: fix model description

2015-07-06 Thread Sebastian Herbszt
Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de Reviewed-By: James Smart james.sm...@avagotech.com diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 2015-04-15

Re: [PATCH] lpfc: fix model description

2015-05-28 Thread James Smart
Yes - this is acceptable. Not a big deal per-say, but good to be uniform. Reviewed-By: James Smart james.sm...@avagotech.com -- james s On 5/27/2015 5:40 PM, Sebastian Herbszt wrote: I wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de

Re: [PATCH] lpfc: fix model description

2015-05-27 Thread Sebastian Herbszt
I wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c2015-04-15 06:18:24.673045138 +0200 +++

Re: [PATCH] lpfc: fix model description

2015-04-27 Thread Bart Van Assche
On 04/27/15 00:32, Sebastian Herbszt wrote: Bart Van Assche wrote: * Switch from snprintf() to scnprintf() because the latter function guarantees '\0'-termination if the output has to be truncated. Doesn't snprintf() guarantee this too? The only difference between snprintf() and

Re: [PATCH] lpfc: fix model description

2015-04-26 Thread Sebastian Herbszt
Bart Van Assche wrote: On 04/22/15 23:16, Sebastian Herbszt wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c ---

Re: [PATCH] lpfc: fix model description

2015-04-23 Thread Bart Van Assche
On 04/22/15 23:16, Sebastian Herbszt wrote: Remove trailing space from model description. Signed-off-by: Sebastian Herbszt herb...@gmx.de diff -up 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 4.0/drivers/scsi/lpfc/lpfc_init.c --- 4.0/drivers/scsi/lpfc.orig/lpfc_init.c 2015-04-15