[PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Seokmann Ju
Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding starget_for_each_device() calls. As Matthew W. pointed out, starget_for_each_device() can be called under a spinlock being held. The change has been tested and verified on qla2xxx.ko module. Thanks Matthew W. and Hisashi H. for help.

Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Matthew Wilcox
On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding starget_for_each_device() calls. As Matthew W. pointed out, starget_for_each_device() can be called under a spinlock being held. The change has been tested and verified on

Re: [PATCH] qla2xxx: correct locking while call starget_for_each_device()

2007-01-09 Thread Andrew Vasquez
On Tue, 09 Jan 2007, Matthew Wilcox wrote: On Tue, Jan 09, 2007 at 11:37:52AM -0800, Seokmann Ju wrote: Removed spin_unlock_irq()/spin_lock_irq() pairs surrounding starget_for_each_device() calls. As Matthew W. pointed out, starget_for_each_device() can be called under a spinlock being