Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 17:47, John Snow wrote: > > > Various downstreams may have backported the VPD fix to older versions, > > > we need to be careful not to block those, too ... so targeting the core > > > behavior seems like the more strictly correct, easily maintainable > > > solution. > > > > I thi

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 17:41, John Snow wrote: > On 06/06/2016 11:05 AM, Paolo Bonzini wrote: >> For ATAPI, you have to blacklist all versions up to 2.2 inclusive. >> >> This gives: >> >> - QEMU / QEMU CD-ROM / 0.8.(this is IDE and SCSI) >> - QEMU / QEMU CD-ROM / 0.9.(this is IDE and SCSI) >> - QE

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread John Snow
On 06/06/2016 11:43 AM, Paolo Bonzini wrote: > > > On 06/06/2016 17:41, John Snow wrote: >> On 06/06/2016 11:05 AM, Paolo Bonzini wrote: >>> For ATAPI, you have to blacklist all versions up to 2.2 inclusive. >>> >>> This gives: >>> >>> - QEMU / QEMU CD-ROM / 0.8.(this is IDE and SCSI) >>> -

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread John Snow
On 06/06/2016 11:05 AM, Paolo Bonzini wrote: > > > On 06/06/2016 16:22, Hannes Reinecke wrote: >> So either we dig into what went wrong with qemu 0.8, or we figure out >> from which qemu version things start to behave nicely, and blacklist >> earlier versions. >> Either way, this patch is

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Paolo Bonzini
On 06/06/2016 16:22, Hannes Reinecke wrote: > So either we dig into what went wrong with qemu 0.8, or we figure out > from which qemu version things start to behave nicely, and blacklist > earlier versions. > > > > Either way, this patch is wrong. > > > > If we can identify which versions work,

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Hannes Reinecke
On 06/06/2016 04:11 PM, Ewan D. Milne wrote: > > > On Mon, 2016-06-06 at 09:34 +0200, Hannes Reinecke wrote: >> On 05/31/2016 03:42 PM, Ewan D. Milne wrote: >>> Linux fails to boot as a guest with a QEMU CD-ROM: >>> >>> [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 >>> [4.44

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Ewan D. Milne
On Mon, 2016-06-06 at 09:34 +0200, Hannes Reinecke wrote: > On 05/31/2016 03:42 PM, Ewan D. Milne wrote: > > Linux fails to boot as a guest with a QEMU CD-ROM: > > > > [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 > > [4.443649] ata2.00: configured for MWDMA2 > > [4.450

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-06 Thread Hannes Reinecke
On 05/31/2016 03:42 PM, Ewan D. Milne wrote: > Linux fails to boot as a guest with a QEMU CD-ROM: > > [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 > [4.443649] ata2.00: configured for MWDMA2 > [4.450267] scsi 1:0:0:0: CD-ROMQEMU QEMU CD-ROM 0.8. > P

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-03 Thread Bart Van Assche
On 05/31/2016 06:42 AM, Ewan D. Milne wrote: Linux fails to boot as a guest with a QEMU CD-ROM: ... Fix this by suppressing VPD inquiry for this device. Reviewed-by: Bart Van Assche -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majord...@v

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-03 Thread Ewan D. Milne
commit 09e2b0b14690fb13ccfc04af49f156df3e25b152 Author: Hannes Reinecke Date: Mon Nov 9 13:24:28 2015 +0100 scsi: rescan VPD attributes --- see also: commit 5ddfe0858ea7848c5d4efe3f4319e7543522e0ee Author: Hannes Reinecke Date: Fri Apr 1 08:57:36 2016 +0200 scsi: Do not attach VPD

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-03 Thread Tom Yan
What changes are you referring to? Doesn't that mean the changes are flawed and some actual follow-up fixes are needed instead? On 3 June 2016 at 22:36, Ewan D. Milne wrote: > This is an existing configuration that broke with the VPD rescan > changes. The problem is that the error causes a resca

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-03 Thread Ewan D. Milne
This is an existing configuration that broke with the VPD rescan changes. The problem is that the error causes a rescan to be initiated, which results in endless error messages. On Fri, 2016-06-03 at 03:15 +, Tom Yan wrote: > Why not get qemu have it fixed instead? > > On Tuesday, 31 May 201

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-06-02 Thread Tom Yan
Why not get qemu have it fixed instead? On 31 May 2016 at 21:43, Johannes Thumshirn wrote: > On Tue, May 31, 2016 at 09:42:29AM -0400, Ewan D. Milne wrote: >> Linux fails to boot as a guest with a QEMU CD-ROM: >> >> [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 >> [4.443649]

Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-05-31 Thread Johannes Thumshirn
On Tue, May 31, 2016 at 09:42:29AM -0400, Ewan D. Milne wrote: > Linux fails to boot as a guest with a QEMU CD-ROM: > > [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 > [4.443649] ata2.00: configured for MWDMA2 > [4.450267] scsi 1:0:0:0: CD-ROMQEMU QEMU CD-

[PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist

2016-05-31 Thread Ewan D. Milne
Linux fails to boot as a guest with a QEMU CD-ROM: [4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max UDMA/100 [4.443649] ata2.00: configured for MWDMA2 [4.450267] scsi 1:0:0:0: CD-ROMQEMU QEMU CD-ROM 0.8. PQ: 0 ANSI: 5 [4.464317] ata2.00: exception Emask 0x0