Hi
Several have remarked in the other patch for strncpy I posted. That
there is a strlcpy that works exactly as one would like to strncpy was
done :)
And the return value is like for snprintf, but quite a lot faster!
So I submit patches based with it instead, and did a couple more
exchanges of sn
Minimized the use of snprintf()
And removed a variable that was only used for the temporary storage.
Signed-off-by: Rickard Strandqvist
---
drivers/scsi/bfa/bfad_attr.c | 114 --
1 file changed, 66 insertions(+), 48 deletions(-)
diff --git a/drivers/scsi
On 06/05/14 08:55, Bart Van Assche wrote:
> On 06/04/14 20:08, Rickard Strandqvist wrote:
> This is ugly. Please use sprintf(buf, "%.*s\n", PAGE_SIZE - 1, str)
> instead of strncpy() + strlen().
(replying to my own e-mail)
The above should of course have read "sprintf(buf, "%.*s\n", PAGE_SIZE -
2
On 06/04/14 20:08, Rickard Strandqvist wrote:
> Minimized the use of snprintf()
> And removed a variable that was only used for the temporary storage.
>
> This was partly found using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist
> ---
> drivers/scsi/bfa/
Minimized the use of snprintf()
And removed a variable that was only used for the temporary storage.
This was partly found using a static code analysis program called cppcheck.
Signed-off-by: Rickard Strandqvist
---
drivers/scsi/bfa/bfad_attr.c | 14 --
1 file changed, 8 insertion
5 matches
Mail list logo
