Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-18 Thread James Bottomley
On Thu, 2018-01-18 at 11:17 +0100, Hannes Reinecke wrote: > On 01/18/2018 03:43 AM, Martin K. Petersen wrote: > > > > > > Martin, > > > > > > > > You'd like to spend a precious BLIST bit for this single device > > > which uses vendor-specific ASC/Q? > > > > I really don't want string compariso

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-18 Thread Hannes Reinecke
On 01/18/2018 03:43 AM, Martin K. Petersen wrote: > > Martin, > >> You'd like to spend a precious BLIST bit for this single device which >> uses vendor-specific ASC/Q? > > I really don't want string comparisons in the regular code paths. Also > not a fan of vendor-specific ASCs. But if you must

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-17 Thread Martin K. Petersen
Martin, > You'd like to spend a precious BLIST bit for this single device which > uses vendor-specific ASC/Q? I really don't want string comparisons in the regular code paths. Also not a fan of vendor-specific ASCs. But if you must use them, please add a flag and trigger on that. Since this is

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-17 Thread Xose Vazquez Perez
Martin Wilck wrote: > On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote: >> >> > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) >> > && >> > + !strncmp(scmd->device->model, >> > "ETERNUS_DXM", 11) && Is DXM the S3 family? >> Blacklist, please. > > To

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-16 Thread Martin Wilck
On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote: > Martin, > > > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) > > && > > + !strncmp(scmd->device->model, > > "ETERNUS_DXM", 11) && > > Blacklist, please. > To make sure I understand correctly: You'

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-16 Thread Martin K. Petersen
Martin, > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) && > +!strncmp(scmd->device->model, "ETERNUS_DXM", 11) && Blacklist, please. -- Martin K. Petersen Oracle Linux Engineering

[PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-15 Thread Martin Wilck
On Fujitsu ETERNUS systems, sense code ABORTED COMMAND with ASC/Q C1/01 is used to indicate temporary condition where the storage-internal path to a target is switched from one controller to another. SCSI commands that return with this error code must be retried unconditionally (i.e. without the "m