Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-21 Thread John Garry
On 21/11/2016 14:25, Quentin Lambert wrote: On 11/21/2016 03:16 PM, John Garry wrote: On 21/11/2016 13:20, Quentin Lambert wrote: On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe.

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-21 Thread Quentin Lambert
On 11/21/2016 03:16 PM, John Garry wrote: On 21/11/2016 13:20, Quentin Lambert wrote: On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome the

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-21 Thread John Garry
On 21/11/2016 13:20, Quentin Lambert wrote: On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome the opportunity to learn something. We call

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-21 Thread Quentin Lambert
On 11/21/2016 01:53 PM, John Garry wrote: However I have noticed that we should do a call to hisi_sas_free() for this failure, and later failures in the probe. I don't understand why, and would welcome the opportunity to learn something. Quentin -- To unsubscribe from this list: send the li

Re: [PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-21 Thread John Garry
On 19/11/2016 17:42, Quentin Lambert wrote: Most error branches following the call to hisi_sas_shost_alloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. I think that this patch is fine. However I have noticed that we should do a

[PATCH] scsi: hisi_sas: Add a missing call to kfree

2016-11-19 Thread Quentin Lambert
Most error branches following the call to hisi_sas_shost_alloc contain a call to kfree. This patch add these calls where they are missing. This issue was found with Hector. Signed-off-by: Quentin Lambert --- drivers/scsi/hisi_sas/hisi_sas_main.c |6 -- 1 file changed, 4 insertions(+),