Re: [PATCH] scsi: nsp32: fix logic bug in error handling

2017-10-16 Thread Martin K. Petersen
Masanori, >> gcc-8 points out a logic error that has existed since the start >> of the git history: >> >> drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': >> drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to >> false [-Werror=tautological-compare] >> if(((

Re: [PATCH] scsi: nsp32: fix logic bug in error handling

2017-10-15 Thread Masanori Goto
2017-09-05 16:51 GMT+09:00 Arnd Bergmann : > gcc-8 points out a logic error that has existed since the start > of the git history: > > drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': > drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to > false [-Werror=tautolo

[PATCH] scsi: nsp32: fix logic bug in error handling

2017-09-05 Thread Arnd Bergmann
gcc-8 points out a logic error that has existed since the start of the git history: drivers/scsi/nsp32.c: In function 'nsp32_selection_autoscsi': drivers/scsi/nsp32.c:607:27: error: bitwise comparison always evaluates to false [-Werror=tautological-compare] if(((phase & BUSMON_BSY) == 1) || (ph