Re: [PATCH] scsi_allocate_request() reference

2005-03-22 Thread James Bottomley
On Tue, 2005-03-22 at 12:17 +0100, Jens Axboe wrote: > You need to have io in progress. The one ref problem with > scsi_allocate_request() is easy to trigger, if you just open/close the > device repeatedly while inserting and removing it. OK, this is the python program I've been using: >>> while

Re: [PATCH] scsi_allocate_request() reference

2005-03-22 Thread Jens Axboe
On Tue, Mar 22 2005, Tejun Heo wrote: > Hello, Jens. > Hello, James. > > On Mon, Mar 21, 2005 at 05:57:52PM +0100, Jens Axboe wrote: > > On Mon, Mar 21 2005, James Bottomley wrote: > > > On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: > > > > scsi_allocate_request() doesn't hold a reference

Re: [PATCH] scsi_allocate_request() reference

2005-03-21 Thread Tejun Heo
Hello, Jens. Hello, James. On Mon, Mar 21, 2005 at 05:57:52PM +0100, Jens Axboe wrote: > On Mon, Mar 21 2005, James Bottomley wrote: > > On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: > > > scsi_allocate_request() doesn't hold a reference to the device that it > > > points to, that is not

Re: [PATCH] scsi_allocate_request() reference

2005-03-21 Thread Jens Axboe
On Mon, Mar 21 2005, James Bottomley wrote: > On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: > > scsi_allocate_request() doesn't hold a reference to the device that it > > points to, that is not good. This patch fixes that up. > > Actually, I don't think this is correct. The reference is ta

Re: [PATCH] scsi_allocate_request() reference

2005-03-21 Thread James Bottomley
On Mon, 2005-03-21 at 14:26 +0100, Jens Axboe wrote: > scsi_allocate_request() doesn't hold a reference to the device that it > points to, that is not good. This patch fixes that up. Actually, I don't think this is correct. The reference is taken when the command is attached to a request in the s

[PATCH] scsi_allocate_request() reference

2005-03-21 Thread Jens Axboe
Hi, scsi_allocate_request() doesn't hold a reference to the device that it points to, that is not good. This patch fixes that up. Signed-off-by: Jens Axboe <[EMAIL PROTECTED]> = drivers/scsi/scsi.c 1.157 vs edited = --- 1.157/drivers/scsi/scsi.c 2005-03-03 09:22:17 +01:00 +++ edited/dr