Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

2017-08-06 Thread Hannes Reinecke
On 08/05/2017 01:35 PM, Christoph Hellwig wrote: >> error = scsi_dh_add_device(sdev); >> -if (error) >> -/* >> - * device_handler is optional, so any error can be ignored >> - */ >> -sdev_printk(KERN_INFO, sdev, >> -

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

2017-08-05 Thread Christoph Hellwig
> error = scsi_dh_add_device(sdev); > - if (error) > - /* > - * device_handler is optional, so any error can be ignored > - */ > - sdev_printk(KERN_INFO, sdev, > - "failed to add device handler: %d\n", error); >

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

2017-08-04 Thread Bart Van Assche
On Fri, 2017-08-04 at 08:37 +0200, Hannes Reinecke wrote: > ALUA is only relevant for disk-like devices, so we shouldn't > be printing out warning messages for other device types. Reviewed-by: Bart Van Assche

Re: [PATCH] scsi_dh_alua: suppress errors from unsupported devices

2017-08-04 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

[PATCH] scsi_dh_alua: suppress errors from unsupported devices

2017-08-03 Thread Hannes Reinecke
ALUA is only relevant for disk-like devices, so we shouldn't be printing out warning messages for other device types. Signed-off-by: Hannes Reinecke --- drivers/scsi/device_handler/scsi_dh_alua.c | 2 ++ drivers/scsi/scsi_dh.c | 5 +++-- drivers/scsi/scsi_sysfs.c