Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-28 Thread Hannes Reinecke
On 02/27/2017 08:33 PM, Ewan D. Milne wrote: > On Thu, 2017-02-23 at 11:27 +0100, Hannes Reinecke wrote: >> The current medium access timeout counter will be increased for >> each command, so if there are enough failed commands we'll hit >> the medium access timeout for even a single failure. >>

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-27 Thread Martin K. Petersen
> "Ewan" == Ewan D Milne writes: Ewan, Ewan> So, this is good, the current implementation has a flaw in that Ewan> under certain conditions, a device will get offlined immediately, Ewan> (i.e. if there are a few medium access commands pending, and they Ewan> all timeout),

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-27 Thread Ewan D. Milne
On Thu, 2017-02-23 at 11:27 +0100, Hannes Reinecke wrote: > The current medium access timeout counter will be increased for > each command, so if there are enough failed commands we'll hit > the medium access timeout for even a single failure. > Fix this by making the timeout per EH run, ie the

Re: [PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-23 Thread Laurence Oberman
er" <ma...@de.ibm.com>, "Hannes > Reinecke" <h...@suse.com> > Sent: Thursday, February 23, 2017 5:27:19 AM > Subject: [PATCH] scsi_error: count medium access timeout only once per EH run > > The current medium access timeout counter will be increased for >

[PATCH] scsi_error: count medium access timeout only once per EH run

2017-02-23 Thread Hannes Reinecke
The current medium access timeout counter will be increased for each command, so if there are enough failed commands we'll hit the medium access timeout for even a single failure. Fix this by making the timeout per EH run, ie the counter will only be increased once per device and EH run. Cc: Ewan