Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-09-01 Thread Ming Lei
On Fri, Sep 01, 2017 at 08:24:46AM +0200, oleksa...@natalenko.name wrote: > Hi. > > 01.09.2017 05:45, Ming Lei wrote: > > Could you try the following patch against this patchset to see > > if there is still the warning? > > With this patch I wasn't able to trigger per-CPU-related warning. That

Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-09-01 Thread oleksandr
Hi. 01.09.2017 05:45, Ming Lei wrote: Could you try the following patch against this patchset to see if there is still the warning? With this patch I wasn't able to trigger per-CPU-related warning. Also, for 8th patch you've written: I have sent one delta patch in list, which will only call

Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-08-31 Thread Ming Lei
On Thu, Aug 31, 2017 at 08:31:54PM +0200, Oleksandr Natalenko wrote: > Tested against v4.13-rc7. With this patchset it looks like I/O doesn't hang, > but once (just once, not each time) I've got the following stacktrace on > resume: That looks not bad, and thanks for your test! Could you try

Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-08-31 Thread Oleksandr Natalenko
Tested against v4.13-rc7. With this patchset it looks like I/O doesn't hang, but once (just once, not each time) I've got the following stacktrace on resume: === [ 55.577173] ata1.00: Security Log not supported [ 55.580690] ata1.00: configured for UDMA/100 [ 55.582257] [ cut

Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-08-31 Thread Oleksandr Natalenko
Since I'm in CC, does this series aim to replace 2 patches I've tested before: blk-mq: add requests in the tail of hctx->dispatch blk-mq: align to legacy's implementation of blk_execute_rq ? On čtvrtek 31. srpna 2017 19:27:19 CEST Ming Lei wrote: > The current SCSI quiesce isn't safe and easy

Re: [PATCH 0/9] block/scsi: safe SCSI quiescing

2017-08-31 Thread Ming Lei
On Thu, Aug 31, 2017 at 07:34:06PM +0200, Oleksandr Natalenko wrote: > Since I'm in CC, does this series aim to replace 2 patches I've tested before: > > blk-mq: add requests in the tail of hctx->dispatch > blk-mq: align to legacy's implementation of blk_execute_rq > > ? Yeah, this solution is

[PATCH 0/9] block/scsi: safe SCSI quiescing

2017-08-31 Thread Ming Lei
The current SCSI quiesce isn't safe and easy to trigger I/O deadlock. Once SCSI device is put into QUIESCE, no new request except for RQF_PREEMPT can be dispatched to SCSI successfully, and scsi_device_quiesce() just simply waits for completion of I/Os dispatched to SCSI stack. It isn't enough at