Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

2016-04-04 Thread Sergei Shtylyov
On 04/04/2016 07:22 PM, Tejun Heo wrote: + } else { + /* Could not decode error */ + ata_dev_warn(dev, "could not decode error status 0x%x err_mask 0x%x\n", "%#x" is equivalent and takes up less space. Oops, gmail for some reason put Sergei's messages

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

2016-04-04 Thread Tejun Heo
On Mon, Apr 04, 2016 at 02:26:51PM +0300, Sergei Shtylyov wrote: > >+} else { > >+/* Could not decode error */ > >+ata_dev_warn(dev, "could not decode error status 0x%x err_mask > >0x%x\n", > >"%#x" is equivalent and takes up less space. Oops, gmail for some reaso

Re: [PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

2016-04-04 Thread Sergei Shtylyov
On 4/4/2016 12:43 PM, Hannes Reinecke wrote: ata_to_sense_error() is called conditionally, so we should be generating a default sense if the condition is not met. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/a

[PATCH 03/14] libata-scsi: sanitize ata_gen_ata_sense()

2016-04-04 Thread Hannes Reinecke
ata_to_sense_error() is called conditionally, so we should be generating a default sense if the condition is not met. Signed-off-by: Hannes Reinecke --- drivers/ata/libata-scsi.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index