[PATCH 1/1] ipr: Fix invalid array indexing for HRRQ

2015-06-25 Thread Brian King
James, Here is one more fix for a rather nasty bug where the ipr driver can start accessing memory it doesn't own. I'd like to add to the queue of ipr patches. There are now two patches on top of the previously submitted series of four. If you want me to resend everything as a complete series,

Re: [PATCH 1/1] ipr: Fix invalid array indexing for HRRQ

2015-06-25 Thread Jiri Slaby
On 06/25/2015, 03:44 PM, Brian King wrote: Fixes another signed / unsigned array indexing bug in the ipr driver. Could you be more specific? Specifically, I fail to see why you do +1 twice now. --- linux/drivers/scsi/ipr.c~ipr_hrrq_index_fix 2015-06-23 11:43:18.151741523 -0500 +++

Re: [PATCH 1/1] ipr: Fix invalid array indexing for HRRQ

2015-06-25 Thread Brian King
On 06/25/2015 09:36 AM, Jiri Slaby wrote: On 06/25/2015, 03:44 PM, Brian King wrote: Fixes another signed / unsigned array indexing bug in the ipr driver. Could you be more specific? Specifically, I fail to see why you do +1 twice now. Sure. With the code that is currently upstream, when

Re: [PATCH 1/1] ipr: Fix invalid array indexing for HRRQ

2015-06-25 Thread Brian King
On 06/25/2015 09:36 AM, Jiri Slaby wrote: On 06/25/2015, 03:44 PM, Brian King wrote: Fixes another signed / unsigned array indexing bug in the ipr driver. Could you be more specific? Specifically, I fail to see why you do +1 twice now. Regarding the extra +1, you are correct. Its not