Re: [PATCH 1/1] scsi: Fix max transfer length for 4k disks

2015-02-03 Thread Venkatesh Srinivas
On Thu, Jan 29, 2015 at 1:54 PM, Brian King wrote: > > The following patch fixes an issue observed with 4k sector disks > where the max_hw_sectors attribute was getting set too large in > sd_revalidate_disk. Since sdkp->max_xfer_blocks is in units > of SCSI logical blocks and queue_max_hw_sectors

Re: [PATCH 1/1] scsi: Fix max transfer length for 4k disks

2015-01-29 Thread Martin K. Petersen
> "Brian" == Brian King writes: Brian> on a 4k sector disk, every time we went through Brian> sd_revalidate_disk, we were taking the current value of Brian> queue_max_hw_sectors and increasing it by a factor of 8. Fix this Brian> by only shifting sdkp->max_xfer_blocks. *blush* Reviewed-by:

Re: [PATCH 1/1] scsi: Fix max transfer length for 4k disks

2015-01-29 Thread Paolo Bonzini
On 29/01/2015 22:54, Brian King wrote: > The following patch fixes an issue observed with 4k sector disks > where the max_hw_sectors attribute was getting set too large in > sd_revalidate_disk. Since sdkp->max_xfer_blocks is in units > of SCSI logical blocks and queue_max_hw_sectors is in units o

[PATCH 1/1] scsi: Fix max transfer length for 4k disks

2015-01-29 Thread Brian King
The following patch fixes an issue observed with 4k sector disks where the max_hw_sectors attribute was getting set too large in sd_revalidate_disk. Since sdkp->max_xfer_blocks is in units of SCSI logical blocks and queue_max_hw_sectors is in units of 512 byte blocks, on a 4k sector disk, every ti