Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Martin K. Petersen
Ewan, > Code is correct. > > s/TGPS/TPGS in the subject line and in one place in the patch > description. Also fixed the original, incorrect comment in the code that begat the patch description typo. Thanks! Applied to 4.12/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Ewan D. Milne
On Fri, 2017-05-26 at 12:59 -0400, Martin K. Petersen wrote: > It was not possible to enable both T10 PI and TGPS because they share > the same byte in the INQUIRY response. Logically OR the TPGS value > instead of using assignment. > > Reported-by: Ritika Srivastava

Re: [PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-31 Thread Bart Van Assche
On Fri, 2017-05-26 at 12:59 -0400, Martin K. Petersen wrote: > It was not possible to enable both T10 PI and TGPS because they share > the same byte in the INQUIRY response. Logically OR the TPGS value > instead of using assignment. Reviewed-by: Bart Van Assche

[PATCH 1/1] scsi: scsi_debug: Avoid PI being disabled when TGPS is enabled

2017-05-26 Thread Martin K. Petersen
It was not possible to enable both T10 PI and TGPS because they share the same byte in the INQUIRY response. Logically OR the TPGS value instead of using assignment. Reported-by: Ritika Srivastava Signed-off-by: Martin K. Petersen ---