Re: [PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

2018-06-15 Thread Sebastian Andrzej Siewior
On 2018-06-14 21:59:18 [-0400], Martin K. Petersen wrote: > > Sebastian, Martin, > Applied to 4.19/scsi-queue. Thank you! Thank you. Sebastian

Re: [PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

2018-06-14 Thread Martin K. Petersen
Sebastian, > Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock > management duties from lldds") the sas_ata_qc_issue() function unlocks > the ata_port.lock and disables interrupts before doing so. That lock > is always taken with disabled interrupts so at this point, the > interru

Re: [PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

2018-06-14 Thread John Garry
nit: scsi: libsas: remove irq save in sas_ata_qc_issue() On 14/06/2018 17:18, Sebastian Andrzej Siewior wrote: Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock management duties from lldds") the sas_ata_qc_issue() function unlocks the ata_port.lock and disables interrupts before d

Re: [PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

2018-06-14 Thread Dan Williams
On Thu, Jun 14, 2018 at 9:18 AM, Sebastian Andrzej Siewior wrote: > Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock > management duties from lldds") the sas_ata_qc_issue() function unlocks > the ata_port.lock and disables interrupts before doing so. > That lock is always taken with

[PATCH 1/2 v2] libsas: remove irq save in sas_ata_qc_issue()

2018-06-14 Thread Sebastian Andrzej Siewior
Since commit 312d3e56119a ("[SCSI] libsas: remove ata_port.lock management duties from lldds") the sas_ata_qc_issue() function unlocks the ata_port.lock and disables interrupts before doing so. That lock is always taken with disabled interrupts so at this point, the interrupts are already disabled.