Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-30 Thread Don Brace
On 10/30/2015 02:47 AM, Hannes Reinecke wrote: On 10/28/2015 11:04 PM, Don Brace wrote: Check for NULLs. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa.h |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/driver

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-30 Thread Hannes Reinecke
On 10/28/2015 11:04 PM, Don Brace wrote: > Check for NULLs. > > Signed-off-by: Don Brace > --- > drivers/scsi/hpsa.c |6 ++ > drivers/scsi/hpsa.h |2 +- > 2 files changed, 7 insertions(+), 1 deletion(-) > > diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c > index 864fb03..6b6e

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-29 Thread Manoj Kumar
On 10/28/2015 5:04 PM, Don Brace wrote: Check for NULLs. - int devtype; + unsigned int devtype; Don: Unrelated to the NULL argument check. Would have been preferable in a distinct patch. Reviewed-by: Manoj Kumar --- Manoj Kumar -- To unsubscribe from this list: send the line

Re: [PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-29 Thread Tomas Henzl
On 28.10.2015 23:04, Don Brace wrote: > Check for NULLs. How is the devtype change related to this? Please next time use separated patch for every change. Reviewed-by: Tomas Henzl Cheers, Tomas -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message t

[PATCH 1 03/25] hpsa: check for null arguments to dev_printk

2015-10-28 Thread Don Brace
Check for NULLs. Signed-off-by: Don Brace --- drivers/scsi/hpsa.c |6 ++ drivers/scsi/hpsa.h |2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c index 864fb03..6b6e9bb 100644 --- a/drivers/scsi/hpsa.c +++ b/drivers/scsi/hpsa.