Re: [PATCH 10/10] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

2013-06-12 Thread Saurav Kashyap
>request->msgcode == FC_BSG_RPT_ELS) kfree(fcport); done: return rval; Thanks, ~Saurav -Original Message- From: Bart Van Assche Date: Wed, 5 Jun 2013 15:09:59 +0200 To: linux-scsi Cc: Chad Dupuis , Saurav Kashyap Subject: [PATCH 10/10] qla2xxx: Fix a memory

[PATCH 10/10] qla2xxx: Fix a memory leak in an error path of qla2x00_process_els()

2013-06-05 Thread Bart Van Assche
Avoid that the fcport structure gets leaked if bsg_job->request->msgcode == FC_BSG_HST_ELS_NOLOGIN, the fcport allocation succeeds and the !vha->flags.online branch is taken. This was detected by Coverity. However, Coverity does not recognize that all qla2x00_process_els() callers specify either FC