Re: [PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select()

2015-11-19 Thread Hannes Reinecke
On 11/18/2015 09:35 AM, Finn Thain wrote: > The "failed" label in NCR5380_select() is not helpful. Some failures > return 0, others -1. Use return instead of goto to improve clarity and > brevity, like atari_NCR5380.c does. Fix the relevant comments. > > Signed-off-by: Finn Thain

[PATCH 14/71] ncr5380: Use return instead of goto in NCR5380_select()

2015-11-18 Thread Finn Thain
The "failed" label in NCR5380_select() is not helpful. Some failures return 0, others -1. Use return instead of goto to improve clarity and brevity, like atari_NCR5380.c does. Fix the relevant comments. Signed-off-by: Finn Thain --- drivers/scsi/NCR5380.c |