Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-25 Thread h...@lst.de
This looks good to me: Reviewed-by: Christoph Hellwig

Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-25 Thread Bart Van Assche
On Fri, 2017-08-25 at 17:29 +0200, h...@lst.de wrote: > On Thu, Aug 24, 2017 at 04:27:07PM +, Bart Van Assche wrote: > > > > The purpose of that check is to avoid that dev_loss_tmo * HZ can overflow. > > That check is only needed on 32-bit systems since only on these systems > > sizeof(long)

Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-25 Thread h...@lst.de
On Thu, Aug 24, 2017 at 04:27:07PM +, Bart Van Assche wrote: > > The purpose of that check is to avoid that dev_loss_tmo * HZ can overflow. > That check is only needed on 32-bit systems since only on these systems > sizeof(long) == sizeof(int). How about changing the type of the dev_loss_tmo

Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-24 Thread Bart Van Assche
On Thu, 2017-08-24 at 11:11 +0200, Christoph Hellwig wrote: > On Wed, Aug 23, 2017 at 02:40:07PM -0700, Bart Van Assche wrote: > > Avoid that the following compiler warning is reported when building > > with W=1: > > > > drivers/scsi/scsi_transport_srp.c:92:19: warning: comparison is always > >

Re: [PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-24 Thread Christoph Hellwig
On Wed, Aug 23, 2017 at 02:40:07PM -0700, Bart Van Assche wrote: > Avoid that the following compiler warning is reported when building > with W=1: > > drivers/scsi/scsi_transport_srp.c:92:19: warning: comparison is always false > due to limited range of data type [-Wtype-limits] > >

[PATCH 17/19] scsi_transport_srp: Suppress a W=1 compiler warning

2017-08-23 Thread Bart Van Assche
Avoid that the following compiler warning is reported when building with W=1: drivers/scsi/scsi_transport_srp.c:92:19: warning: comparison is always false due to limited range of data type [-Wtype-limits] Signed-off-by: Bart Van Assche Cc: Christoph Hellwig