Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Douglas Gilbert
On 2017-09-15 08:05 AM, Hannes Reinecke wrote: When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table is returned; the remaining part will then contain stale kernel memory information. This patch zeroes out the entire table to avoid this issue. Signed-off-by: Hannes Reinecke Ack

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Martin K. Petersen
Hannes, > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table > is returned; the remaining part will then contain stale kernel memory > information. This patch zeroes out the entire table to avoid this > issue. Applied to 4.14/scsi-fixes. Thank you! -- Martin K. Petersen

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Linus Torvalds
Looks good. James, I expect I'll be getting this through the normal SCSI pulls.. Linus On Fri, Sep 15, 2017 at 5:05 AM, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel m

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Eric Dumazet
On Fri, Sep 15, 2017 at 5:05 AM, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. > > Signed-off-by: Ha

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Christoph Hellwig
On Fri, Sep 15, 2017 at 02:05:16PM +0200, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. > > Signed-o

Re: [PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Bart Van Assche
On Fri, 2017-09-15 at 14:05 +0200, Hannes Reinecke wrote: > When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled > table is returned; the remaining part will then contain stale > kernel memory information. > This patch zeroes out the entire table to avoid this issue. Reviewed-by: Bart V

[PATCH 2/2] sg: fixup infoleak when using SG_GET_REQUEST_TABLE

2017-09-15 Thread Hannes Reinecke
When calling SG_GET_REQUEST_TABLE ioctl that only a half-filled table is returned; the remaining part will then contain stale kernel memory information. This patch zeroes out the entire table to avoid this issue. Signed-off-by: Hannes Reinecke --- drivers/scsi/sg.c | 5 ++--- 1 file changed, 2 i