Re: [PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return values

2014-07-18 Thread Christoph Hellwig
On Thu, Jul 17, 2014 at 02:39:21PM -0500, Robert Elliott wrote: > Two of the blk-mq based drivers do not pass back the return value > from blk_mq_alloc_tag_set, instead just returning -ENOMEM. > > blk_mq_alloc_tag_set returns -EINVAL if the number of queues or > queue depth is bad. -ENOMEM implie

[PATCH 2/3] blk-mq: pass along blk_mq_alloc_tag_set return values

2014-07-17 Thread Robert Elliott
Two of the blk-mq based drivers do not pass back the return value from blk_mq_alloc_tag_set, instead just returning -ENOMEM. blk_mq_alloc_tag_set returns -EINVAL if the number of queues or queue depth is bad. -ENOMEM implies that retrying after freeing some memory might be more successful, but th