Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

On Thu, 2017-11-23 at 14:43 +0300, Dan Carpenter wrote: > On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > > unsigned long flags; > > int nvec, i; > > > > + if (msix_enable == 0) > > + goto

Re: [PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

On Thu, Nov 23, 2017 at 09:31:14AM +0800, Ching Huang wrote: > @@ -829,12 +833,15 @@ arcmsr_request_irq(struct pci_dev *pdev, > unsigned long flags; > int nvec, i; > > + if (msix_enable == 0) > + goto msi_int0; I feel like this goto is not very beautiful, but I can't

[PATCH 2/3] scsi: arcmsr: Add driver module parameter msix_enable

From: Ching Huang Add module parameter msix_enable to has a chance to disable msix interrupt if it does not work properly. Signed-off-by: Ching Huang --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c ---