Re: [PATCH 2/6] hpsa: add support for legacy boards

2017-08-09 Thread Christoph Hellwig
On Wed, Aug 09, 2017 at 05:08:05PM +0200, Hannes Reinecke wrote: > On 08/09/2017 03:41 PM, Christoph Hellwig wrote: > > On Tue, Aug 08, 2017 at 10:35:11AM +0200, Hannes Reinecke wrote: > >> Add support for legacy boards, ensuring to enable the driver for > >> those boards only when

Re: [PATCH 2/6] hpsa: add support for legacy boards

2017-08-09 Thread Hannes Reinecke
On 08/09/2017 03:41 PM, Christoph Hellwig wrote: > On Tue, Aug 08, 2017 at 10:35:11AM +0200, Hannes Reinecke wrote: >> Add support for legacy boards, ensuring to enable the driver for >> those boards only when 'hpsa_allow_any' is set. > > Why the wildcard instead of the specific IDs from the

Re: [PATCH 2/6] hpsa: add support for legacy boards

2017-08-09 Thread Hannes Reinecke
On 08/09/2017 03:45 PM, Christoph Hellwig wrote: >> -static int hpsa_lookup_board_id(struct pci_dev *pdev, u32 *board_id) >> +static int hpsa_lookup_board_id(struct pci_dev *pdev, u32 *board_id, >> +bool *supported) >> { >> int i; >> u32 subsystem_vendor_id,

Re: [PATCH 2/6] hpsa: add support for legacy boards

2017-08-09 Thread Christoph Hellwig
> -static int hpsa_lookup_board_id(struct pci_dev *pdev, u32 *board_id) > +static int hpsa_lookup_board_id(struct pci_dev *pdev, u32 *board_id, > + bool *supported) > { > int i; > u32 subsystem_vendor_id, subsystem_device_id; > @@ -7242,9 +7266,22 @@ static

Re: [PATCH 2/6] hpsa: add support for legacy boards

2017-08-09 Thread Christoph Hellwig
On Tue, Aug 08, 2017 at 10:35:11AM +0200, Hannes Reinecke wrote: > Add support for legacy boards, ensuring to enable the driver for > those boards only when 'hpsa_allow_any' is set. Why the wildcard instead of the specific IDs from the cciss driver?

[PATCH 2/6] hpsa: add support for legacy boards

2017-08-08 Thread Hannes Reinecke
Add support for legacy boards, ensuring to enable the driver for those boards only when 'hpsa_allow_any' is set. Signed-off-by: Hannes Reinecke --- drivers/scsi/hpsa.c | 54 ++--- drivers/scsi/hpsa.h | 45