Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-31 Thread Mike Christie
Chandivade lalit.chandiv...@qlogic.com, Ravi Anand ravi.an...@qlogic.com, Harish Zunjarrao harish.zunjar...@qlogic.com Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings Come on man, same comments as last patches like this :) Could you use the same names that we

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
Come on man, same comments as last patches like this :) Could you use the same names that we currently use for existing params? Check for the inorder ones and the ones where we use en instead of enabled for the postfix. Also check the others. Also what is up with isns. If we support passing the

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Mike Christie
On 05/28/2013 03:49 AM, Mike Christie wrote: Come on man, same comments as last patches like this :) Could you use the same names that we currently use for existing params? Check for the inorder ones and the ones where we use en instead of enabled for the postfix. Also check the others.

Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-28 Thread Vikas Chaudhary
...@qlogic.com, Harish Zunjarrao harish.zunjar...@qlogic.com Subject: Re: [PATCH 2/8] iscsi_transport: Additional parameters for net settings Come on man, same comments as last patches like this :) Could you use the same names that we currently use for existing params? Check for the inorder ones

[PATCH 2/8] iscsi_transport: Additional parameters for net settings

2013-05-09 Thread vikas.chaudhary
From: Harish Zunjarrao harish.zunjar...@qlogic.com Added support to display and update additional network parameters through iscsiadm Signed-off-by: Harish Zunjarrao harish.zunjar...@qlogic.com Signed-off-by: Vikas Chaudhary vikas.chaudh...@qlogic.com --- drivers/scsi/scsi_transport_iscsi.c |