Re: [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

2015-09-23 Thread Hannes Reinecke
On 09/22/2015 09:57 PM, Ewan Milne wrote: > On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: >> When we receive a unit attention code of 'ALUA state changed' >> we should recheck the state, as it might be due to an implicit >> ALUA state transition. >> At the same time a workqueue item

Re: [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

2015-09-22 Thread Ewan Milne
On Thu, 2015-08-27 at 14:41 +0200, Hannes Reinecke wrote: > When we receive a unit attention code of 'ALUA state changed' > we should recheck the state, as it might be due to an implicit > ALUA state transition. > At the same time a workqueue item might already be queued, which > should be started

Re: [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

2015-09-01 Thread Christoph Hellwig
> - alua_check(sdev); > - return ADD_TO_MLQUEUE; > + alua_check(sdev, false); > + return NEEDS_RETRY; What's the reason for the change in return value here? -- To unsubscribe from this list: send the line "unsubscribe

[PATCH 20/23] scsi_dh_alua: Recheck state on unit attention

2015-08-27 Thread Hannes Reinecke
When we receive a unit attention code of 'ALUA state changed' we should recheck the state, as it might be due to an implicit ALUA state transition. At the same time a workqueue item might already be queued, which should be started immediately to avoid any delays. Signed-off-by: Hannes Reinecke