Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Finn Thain
On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: > If an ISA access takes 8 us, while the CPU runs at 1 GHz, i.e. 500M > loops/s, the difference will be huge. Ondrej showed that an ISA access can take about 1.6 us. I don't know what to make of the "8 uS" comment in the mainline driver. Maybe it

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Geert Uytterhoeven
Hi Finn, On Sun, Nov 29, 2015 at 11:25 AM, Finn Thain wrote: > On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: >> This still heavily depends on the processing time spent in >> NCR5380_read(). You should never use a value derived from >> loops_per_jiffy for a non-empty loop, > > Sure but the time-o

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Finn Thain
On Sun, 29 Nov 2015, Geert Uytterhoeven wrote: > This still heavily depends on the processing time spent in > NCR5380_read(). You should never use a value derived from > loops_per_jiffy for a non-empty loop, Sure but the time-out condition isn't supposed to be precise. Plus/minus a jiffy is no

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Geert Uytterhoeven
Hi Finn, On Thu, Nov 26, 2015 at 11:32 PM, Finn Thain wrote: >> The timekeeping warning does not appear when all 71 patches are applied. >> Reverse-bisected it - the warning disappears after: >> [PATCH 50/71] ncr5380: Change instance->host_lock to hostdata->lock >> > > Makes sense. I think that t

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-29 Thread Ondrej Zary
On Sunday 29 November 2015 01:46:03 Finn Thain wrote: > > On Sun, 29 Nov 2015, Ondrej Zary wrote: > > > > [...] I think that this should solve the problem: > > > > Yes, it does! > > > > [ 48.119367] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > > n_io_port 0, base 0xd8000, irq 0

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-28 Thread Finn Thain
On Sun, 29 Nov 2015, Ondrej Zary wrote: > > [...] I think that this should solve the problem: > > Yes, it does! > > [ 48.119367] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > n_io_port 0, base 0xd8000, irq 0, can_queue 16, cmd_per_lun 2, sg_tablesize > 128, this_id 7, flags { N

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-28 Thread Ondrej Zary
On Thursday 26 November 2015 23:32:46 Finn Thain wrote: > > On Thu, 26 Nov 2015, Ondrej Zary wrote: > > > > > [ 156.014234] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > > n_io_port 0, base 0xd8000, irq 0, can_queue 16, cmd_per_lun 2, sg_tablesize > > 128, this_id 7, flags { NO_D

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Finn Thain
On Thu, 26 Nov 2015, Ondrej Zary wrote: > > [ 156.014234] scsi host2: Generic NCR5380/NCR53C400 SCSI, io_port 0x0, > n_io_port 0, base 0xd8000, irq 0, can_queue 16, cmd_per_lun 2, sg_tablesize > 128, this_id 7, flags { NO_DMA_FIXUP }, options { AUTOPROBE_IRQ PSEUDO_DMA } > [ 156.020369] scsi

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Ondrej Zary
On Thursday 26 November 2015 11:23:01 Finn Thain wrote: > > On Wed, 25 Nov 2015, Ondrej Zary wrote: > > > On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > > > > > > > Bisecting slow module initialization pointed to this comm

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-26 Thread Finn Thain
On Wed, 25 Nov 2015, Ondrej Zary wrote: > On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > > > > > > Bisecting slow module initialization pointed to this commit. > > > > > > Before this commit (2 seconds): > > > [ 60.317374] scsi

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-25 Thread Ondrej Zary
On Wednesday 25 November 2015 04:17:09 Finn Thain wrote: > > On Tue, 24 Nov 2015, Ondrej Zary wrote: > > > On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > > > Linux v2.1.105 changed the algorithm for polling for the BSY signal > > > in NCR5380_select() and NCR5380_main(). > > > > > >

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-24 Thread Finn Thain
On Tue, 24 Nov 2015, Ondrej Zary wrote: > On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > > Linux v2.1.105 changed the algorithm for polling for the BSY signal > > in NCR5380_select() and NCR5380_main(). > > > > Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1)

Re: [PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-24 Thread Ondrej Zary
On Wednesday 18 November 2015 09:35:17 Finn Thain wrote: > Linux v2.1.105 changed the algorithm for polling for the BSY signal > in NCR5380_select() and NCR5380_main(). > > Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1) > meant reschedule main() after sleeping for 10 ms.

[PATCH 22/71] ncr5380: Eliminate selecting state

2015-11-18 Thread Finn Thain
Linux v2.1.105 changed the algorithm for polling for the BSY signal in NCR5380_select() and NCR5380_main(). Presently, this code has a bug. Back then, NCR5380_set_timer(hostdata, 1) meant reschedule main() after sleeping for 10 ms. Repeated 25 times this provided the recommended 250 ms selection t