Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-04 Thread Bartlomiej Zolnierkiewicz
nk about the patch below? > > > > Subject: [PATCH 26/28] blk_end_request: changing ide-cd (take 3) > > > This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request > interfaces. > > In PIO mode, ide-cd (cdrom_newpc_intr()) needs to defer > end_that_

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Kiyoshi Ueda
if (!rq->data_len) > - post_transform_command(rq); > - > spin_lock_irqsave(&ide_lock, flags); > blkdev_dequeue_request(rq); > end_that_request_last(rq, 1); Thank you for the comments. I rebased my patch on top of 2.6.24-rc3-mm2 + the patch to remove post_

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: [PATCH] ide-cd: remove dead post_transform_command() post_transform_command() call in cdrom_newpc_intr() has no effect because it is done after the request has already been fully completed (rq->bio and rq->data are always NULL). It was verified to be true reg

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 01 December 2007, Kiyoshi Ueda wrote: > This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). > > ide-cd (cdrom_newpc_intr()) has some tricky behaviors below which > need to use blk_end_request_callback(). > Needs to: > 1. call post_transform_command() to mo

[PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-11-30 Thread Kiyoshi Ueda
This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). ide-cd (cdrom_newpc_intr()) has some tricky behaviors below which need to use blk_end_request_callback(). Needs to: 1. call post_transform_command() to modify request contents 2. wait completing request until DRQ_STAT is