Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-28 Thread Finn Thain
Acked-by: Finn Thain On Tue, 27 Sep 2016, Ondrej Zary wrote: > Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c > Use pnp_driver and isa_driver to manage cards. > > In order to support multiple cards, new module parameter format is > introduced. The

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-27 Thread Finn Thain
On Tue, 27 Sep 2016, Ondrej Zary wrote: > On Monday 26 September 2016, Finn Thain wrote: > > [...] > > > > @@ -364,7 +304,7 @@ static int generic_NCR5380_release_resources(struct > > > Scsi_Host *instance) release_mem_region(instance->base, > > > hostdata->iomem_size); > > > } > > > #endif

[PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-27 Thread Ondrej Zary
Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c Use pnp_driver and isa_driver to manage cards. In order to support multiple cards, new module parameter format is introduced. The old parameters are kept for compatibility. Signed-off-by: Ondrej Zary ---

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-27 Thread Ondrej Zary
On Monday 26 September 2016, Finn Thain wrote: [...] > Instead of this: > > + if (scsi_add_host(instance, pdev)) { > > + free_irq(irq, instance); > > + goto out_unregister; > > + } > > + scsi_scan_host(instance); > > + return instance; > > please use the following

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-25 Thread Finn Thain
On Sat, 24 Sep 2016, Ondrej Zary wrote: > Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c > Use pnp_driver and isa_driver to manage cards. > > Signed-off-by: Ondrej Zary > --- > drivers/scsi/g_NCR5380.c | 310 >

Re: [PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-25 Thread Christoph Hellwig
> +static int generic_NCR5380_isa_match(struct device *pdev, unsigned int ndev) > +{ > + struct Scsi_Host *sh = NULL; > + > + sh = generic_NCR5380_hw_init(_template, pdev, base[ndev], > + irq[ndev], card[ndev]); > + if (!sh && base[ndev]) > +

[PATCH 3/3] g_NCR5380: Stop using scsi_module.c

2016-09-24 Thread Ondrej Zary
Convert g_NCR5380 to use scsi_add_host instead of scsi_module.c Use pnp_driver and isa_driver to manage cards. Signed-off-by: Ondrej Zary --- drivers/scsi/g_NCR5380.c | 310 +- drivers/scsi/g_NCR5380.h |8 -- 2 files