Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-08 Thread 'Christoph Hellwig'
On Tue, Jul 08, 2014 at 01:18:27PM +0300, Dolev Raviv wrote: > > Did you plan to change the arguments to ufshcd_is_device_present in a later > > patch? > I guess I overlooked it, thanks for bringing it to my attention. > I will resend the series without this patch. If the series works just fine w

RE: [PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-08 Thread Dolev Raviv
; sthu...@codeaurora.org; linux-arm-...@vger.kernel.org; santos...@gmail.com Subject: Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails This produces a compiler warning for me that looks serious: ../drivers/scsi/ufs/ufshcd.c: In function ‘ufshcd_link_startup’: ../drivers/scsi/ufs/ufshcd.c:

Re: [PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-07 Thread Christoph Hellwig
This produces a compiler warning for me that looks serious: ../drivers/scsi/ufs/ufshcd.c: In function ???ufshcd_link_startup???: ../drivers/scsi/ufs/ufshcd.c:1938:3: warning: passing argument 1 of ???ufshcd_is_device_present??? makes integer from pointer without a cast [enabled by default] ../driv

[PATCH 3/3] scsi: ufs: retry if the link-startup fails

2014-07-01 Thread Dolev Raviv
From: Sujit Reddy Thumma In some cases, due to hardware timing issues the Uni-Pro link-startup might fail. The UFS HCI recovery procedure contradicts the Uni-Pro sequence. The UFS HCI specifies to resend DME_LINKSTARTUP command after IS.ULLS (link-lost interrupt) is received. The Uni-Pro specifie