Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-29 Thread Akinobu Mita
Mita; Jens Axboe; James E.J. Bottomley; Douglas Gilbert Subject: [PATCH 3/4] scsi: increase upper limit for max_sectors ... - } else if (sdp-use_16_for_rw) { + } else if ((this_count 0x) || sdp-use_16_for_rw) { Suggestion: reorder those so the unlikely case of a huge this_count

Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Christoph Hellwig
On Sun, May 25, 2014 at 09:43:35PM +0900, Akinobu Mita wrote: max_sectors in struct Scsi_Host specifies maximum number of sectors allowed in a single SCSI command. The data type of max_sectors is unsigned short, so the maximum transfer length per SCSI command is limited to less than 256MB in

Re: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Akinobu Mita
Hi Christoph, Thanks for your review. 2014-05-28 19:39 GMT+09:00 Christoph Hellwig h...@infradead.org: Looks good, but I think this should be three patches, one for the ioctl in sg, one for the command selection in sd, and one to change the field with in the scsi core. OK, I'll break this

RE: [PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-28 Thread Elliott, Robert (Server Storage)
] scsi: increase upper limit for max_sectors ... - } else if (sdp-use_16_for_rw) { + } else if ((this_count 0x) || sdp-use_16_for_rw) { Suggestion: reorder those so the unlikely case of a huge this_count is on the right side of the || operator. -- To unsubscribe from this list

[PATCH 3/4] scsi: increase upper limit for max_sectors

2014-05-25 Thread Akinobu Mita
max_sectors in struct Scsi_Host specifies maximum number of sectors allowed in a single SCSI command. The data type of max_sectors is unsigned short, so the maximum transfer length per SCSI command is limited to less than 256MB in 4096-bytes sector size. (0x * 4096) This commit increases the