Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Oliver Neukum
On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) */ dprintkl(KERN_WARNING, EEProm checksum error: using default values and options.\n);

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Jingoo Han
On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) */ dprintkl(KERN_WARNING,

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Jingoo Han
On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) */ dprintkl(KERN_WARNING,

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Julian Calaby
Hi Jingoo, On Wed, Aug 7, 2013 at 5:45 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Jingoo Han
-Original Message- From: Julian Calaby [mailto:julian.cal...@gmail.com] Sent: Wednesday, August 07, 2013 5:21 PM To: Jingoo Han Cc: Oliver Neukum; James Bottomley; Ali Akcaagac; Jamie Lenehan; dc3...@twibble.org; James Bottomley; linux-scsi Subject: Re: [PATCH 3/8] [SCSI] dc395x

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Julian Calaby
...@twibble.org; James Bottomley; linux-scsi Subject: Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0 Hi Jingoo, On Wed, Aug 7, 2013 at 5:45 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Jingoo Han
On Wed, Wednesday, August 07, 2013 5:40 PM, Julian Calaby wrote: On Wed, Aug 7, 2013 at 6:36 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, August 07, 2013 5:21 PM, Julian Calaby wrote: On Wed, Aug 7, 2013 at 5:45 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, August 07,

Re: [PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-07 Thread Oliver Neukum
On Wed, 2013-08-07 at 15:58 +0900, Jingoo Han wrote: On Wednesday, August 07, 2013 3:50 PM, Oliver Neukum wrote: On Wed, 2013-08-07 at 12:55 +0900, Jingoo Han wrote: @@ -4183,15 +4183,17 @@ static void check_eeprom(struct NvRamType *eeprom, unsigned long io_port) */

[PATCH 3/8] [SCSI] dc395x: use NULL instead of 0

2013-08-06 Thread Jingoo Han
%p is used, thus NULL should be used instead of 0. Also, bit maskings are added in order to fix the following sparse warnings: drivers/scsi/dc395x.c:1525:17: warning: Using plain integer as NULL pointer drivers/scsi/dc395x.c:4186:48: warning: cast truncates bits from constant value (1de1 becomes