Re: [PATCH 4/4] sg: use standard lists for sg_requests

2017-02-03 Thread Hannes Reinecke
On 02/03/2017 11:43 AM, Christoph Hellwig wrote: >> typedef struct sg_request { /* SG_MAX_QUEUE requests outstanding per file */ >> -struct sg_request *nextrp; /* NULL -> tail request (slist) */ >> +struct list_head nextrp;/* list entry */ > > s/nextrp/entry/ > >> @@ -2078,1

Re: [PATCH 4/4] sg: use standard lists for sg_requests

2017-02-03 Thread Christoph Hellwig
> typedef struct sg_request { /* SG_MAX_QUEUE requests outstanding per file */ > - struct sg_request *nextrp; /* NULL -> tail request (slist) */ > + struct list_head nextrp;/* list entry */ s/nextrp/entry/ > @@ -2078,16 +2076,13 @@ static long sg_compat_ioctl(struct file *f

Re: [PATCH 4/4] sg: use standard lists for sg_requests

2017-02-03 Thread Johannes Thumshirn
On 02/03/2017 09:54 AM, Hannes Reinecke wrote: 'Sg_request' is using a private list implementation; convert it to standard lists. Signed-off-by: Hannes Reinecke --- Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@s

[PATCH 4/4] sg: use standard lists for sg_requests

2017-02-03 Thread Hannes Reinecke
'Sg_request' is using a private list implementation; convert it to standard lists. Signed-off-by: Hannes Reinecke --- drivers/scsi/sg.c | 107 ++ 1 file changed, 44 insertions(+), 63 deletions(-) diff --git a/drivers/scsi/sg.c b/drivers/scsi/s