Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-14 Thread Johannes Thumshirn
On Wed, Mar 14, 2018 at 11:39:47AM +0100, Douglas Gilbert wrote: > So the difference measured on a Lenovo X270 (i5-7200U) amounts to > around 7 nanoseconds. > > Doug Gilbert Wow, thanks a lot. So it's actually buying us something measurable (not all too much though). Looks good, Reviewed-by:

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-14 Thread Douglas Gilbert
On 2018-03-09 10:13 AM, Johannes Thumshirn wrote: On Tue, Mar 06, 2018 at 10:21:33PM -0500, Douglas Gilbert wrote: ChangeLog: - add likely() and unlikely() hints to conditionals on or near the fastpath - fix a comment in scsi_io_completion_action() Do you have any numbers what this

Re: [PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-09 Thread Johannes Thumshirn
On Tue, Mar 06, 2018 at 10:21:33PM -0500, Douglas Gilbert wrote: > ChangeLog: > - add likely() and unlikely() hints to conditionals on or near the > fastpath > - fix a comment in scsi_io_completion_action() Do you have any numbers what this patch buys us performance wise? Thanks,

[PATCH 4/5] scsi_io_completion: conditional hints on fastpath

2018-03-06 Thread Douglas Gilbert
ChangeLog: - add likely() and unlikely() hints to conditionals on or near the fastpath - fix a comment in scsi_io_completion_action() Signed-off-by: Douglas Gilbert --- drivers/scsi/scsi_lib.c | 26 -- 1 file changed, 12 insertions(+), 14